From: Huang Rui <ray.huang@amd.com>
To: "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: Enable SDMA MGCG for Vangogh
Date: Wed, 21 Apr 2021 15:27:59 +0800 [thread overview]
Message-ID: <20210421072759.GC404763@hr-amd> (raw)
In-Reply-To: <20210421071250.795910-1-Jinzhou.Su@amd.com>
On Wed, Apr 21, 2021 at 03:12:50PM +0800, Su, Jinzhou (Joe) wrote:
> Add flags AMD_CG_SUPPORT_SDMA_MGCG for Vangogh.
> Start to open sdma mgcg from firmware version 70.
>
> Signed-off-by: Jinzhou Su <Jinzhou.Su@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/nv.c | 1 +
> drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
> index d54af7f8801b..0142f6760ad2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nv.c
> @@ -1118,6 +1118,7 @@ static int nv_common_early_init(void *handle)
> AMD_CG_SUPPORT_MC_LS |
> AMD_CG_SUPPORT_GFX_FGCG |
> AMD_CG_SUPPORT_VCN_MGCG |
> + AMD_CG_SUPPORT_SDMA_MGCG |
> AMD_CG_SUPPORT_JPEG_MGCG;
> adev->pg_flags = AMD_PG_SUPPORT_GFX_PG |
> AMD_PG_SUPPORT_VCN |
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
> index b1ad9e52b234..4ba7fce4c0b4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
> @@ -1556,6 +1556,10 @@ static void sdma_v5_2_update_medium_grain_clock_gating(struct amdgpu_device *ade
> int i;
>
> for (i = 0; i < adev->sdma.num_instances; i++) {
> +
> + if (adev->sdma.instance[i].fw_version < 70 && adev->asic_type == CHIP_VANGOGH)
> + adev->cg_flags &= ~AMD_CG_SUPPORT_SDMA_MGCG;
> +
> if (enable && (adev->cg_flags & AMD_CG_SUPPORT_SDMA_MGCG)) {
> /* Enable sdma clock gating */
> def = data = RREG32(sdma_v5_2_get_reg_offset(adev, i, mmSDMA0_CLK_CTRL));
> --
> 2.27.0
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-04-21 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 7:12 [PATCH] drm/amdgpu: Enable SDMA MGCG for Vangogh Jinzhou Su
2021-04-21 7:27 ` Huang Rui [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-24 5:33 Jinzhou Su
2021-02-24 5:41 ` Deucher, Alexander
2021-02-24 6:27 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421072759.GC404763@hr-amd \
--to=ray.huang@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).