From: Yifan Zhang <yifan1.zhang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <Felix.Kuehling@amd.com>, Yifan Zhang <yifan1.zhang@amd.com>
Subject: [PATCH 1/2] drm/amdkfd: remove redundant iommu cleanup code
Date: Tue, 28 Sep 2021 16:28:18 +0800 [thread overview]
Message-ID: <20210928082819.205231-1-yifan1.zhang@amd.com> (raw)
kfd_resume doesn't involve iommu operation, remove
redundant iommu cleanup code.
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index c2a4d920da40..4a416231b24c 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -1085,18 +1085,12 @@ static int kfd_resume(struct kfd_dev *kfd)
int err = 0;
err = kfd->dqm->ops.start(kfd->dqm);
- if (err) {
+ if (err)
dev_err(kfd_device,
"Error starting queue manager for device %x:%x\n",
kfd->pdev->vendor, kfd->pdev->device);
- goto dqm_start_error;
- }
return err;
-
-dqm_start_error:
- kfd_iommu_suspend(kfd);
- return err;
}
static inline void kfd_queue_work(struct workqueue_struct *wq,
--
2.25.1
next reply other threads:[~2021-09-28 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 8:28 Yifan Zhang [this message]
2021-09-28 8:28 ` [PATCH 2/2] drm/amdgpu: init iommu after amdkfd device init Yifan Zhang
2021-09-28 15:41 ` Felix Kuehling
2021-09-29 13:18 ` Zhu, James
2021-10-04 9:42 ` Zhang, Yifan
2021-10-04 15:00 ` Felix Kuehling
2021-10-04 16:56 ` Zhu, James
2021-10-11 6:13 ` youling257
2021-10-11 6:17 ` youling 257
2021-10-11 6:37 ` Zhang, Yifan
2021-10-11 10:03 ` Zhang, Yifan
2021-10-11 10:20 ` youling 257
2021-10-11 12:15 ` Zhang, Yifan
2021-09-30 21:18 ` [PATCH 1/2] drm/amdkfd: remove redundant iommu cleanup code Zhu, James
-- strict thread matches above, loose matches on Subject: below --
2021-09-24 5:48 Yifan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928082819.205231-1-yifan1.zhang@amd.com \
--to=yifan1.zhang@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).