amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Maíra Canal" <mairacanal@riseup.net>
To: Harry Wentland <harry.wentland@amd.com>,
	Leo Li <sunpeng.li@amd.com>,
	Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	christian.koenig@amd.com, Xinhui.Pan@amd.com,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: magalilemes00@gmail.com, tales.aparecida@gmail.com,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	mwen@igalia.com, "Maíra Canal" <mairacanal@riseup.net>,
	"Isabella Basso" <isabbasso@riseup.net>,
	andrealmeid@riseup.net
Subject: [PATCH 10/16] drm/amd/display: Remove ModeIsSupported VBA variable
Date: Thu, 28 Jul 2022 15:20:42 -0300	[thread overview]
Message-ID: <20220728182047.264825-11-mairacanal@riseup.net> (raw)
In-Reply-To: <20220728182047.264825-1-mairacanal@riseup.net>

The ModeIsSupported variable from the struct vba_vars_st is only used on
assignments, so its value is not used on code. So, remove the
ModeIsSupported entry from the struct vba_vars_st.

Signed-off-by: Maíra Canal <mairacanal@riseup.net>
---
 drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c  | 1 -
 drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c  | 1 -
 .../gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c    | 1 -
 drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c  | 2 --
 drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h           | 1 -
 5 files changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
index 4fac83c776ad..b776a7940fac 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c
@@ -5250,7 +5250,6 @@ void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
 		for (i = v->soc.num_states; i >= 0; i--) {
 			if (i == v->soc.num_states || v->ModeSupport[i][0] == true || v->ModeSupport[i][1] == true) {
 				v->VoltageLevel = i;
-				v->ModeIsSupported = v->ModeSupport[i][0] == true || v->ModeSupport[i][1] == true;
 				if (v->ModeSupport[i][1] == true) {
 					MaximumMPCCombine = 1;
 				} else {
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c
index 9ea2d2fd56f1..b338e72d96d8 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn31/display_mode_vba_31.c
@@ -5521,7 +5521,6 @@ void dml31_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
 		for (i = v->soc.num_states; i >= 0; i--) {
 			if (i == v->soc.num_states || v->ModeSupport[i][0] == true || v->ModeSupport[i][1] == true) {
 				v->VoltageLevel = i;
-				v->ModeIsSupported = v->ModeSupport[i][0] == true || v->ModeSupport[i][1] == true;
 				if (v->ModeSupport[i][0] == true) {
 					MaximumMPCCombine = 0;
 				} else {
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c
index ae749d39db2a..6c60731687bf 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c
@@ -5636,7 +5636,6 @@ void dml314_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_
 		for (i = v->soc.num_states; i >= 0; i--) {
 			if (i == v->soc.num_states || v->ModeSupport[i][0] == true || v->ModeSupport[i][1] == true) {
 				v->VoltageLevel = i;
-				v->ModeIsSupported = v->ModeSupport[i][0] == true || v->ModeSupport[i][1] == true;
 				if (v->ModeSupport[i][0] == true) {
 					MaximumMPCCombine = 0;
 				} else {
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
index a88cfce3b771..5fce4bbb4e85 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
@@ -3668,8 +3668,6 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
 		if (i == v->soc.num_states || mode_lib->vba.ModeSupport[i][0] == true ||
 				mode_lib->vba.ModeSupport[i][1] == true) {
 			mode_lib->vba.VoltageLevel = i;
-			mode_lib->vba.ModeIsSupported = mode_lib->vba.ModeSupport[i][0] == true
-					|| mode_lib->vba.ModeSupport[i][1] == true;
 
 			if (mode_lib->vba.ModeSupport[i][0] == true) {
 				MaximumMPCCombine = 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
index ac8131b52b78..f4d4bf7b6111 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
+++ b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
@@ -1132,7 +1132,6 @@ struct vba_vars_st {
 	double VRatioChroma[DC__NUM_DPP__MAX];
 	int WritebackSourceWidth[DC__NUM_DPP__MAX];
 
-	bool ModeIsSupported;
 	bool ODMCombine4To1Supported;
 
 	unsigned int SurfaceWidthY[DC__NUM_DPP__MAX];
-- 
2.37.1


  parent reply	other threads:[~2022-07-28 18:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 18:20 [PATCH 00/16] Remove entries from struct vba_vars_st Maíra Canal
2022-07-28 18:20 ` [PATCH 01/16] drm/amd/display: Remove NonUrgentLatencyTolerance VBA variable Maíra Canal
2022-07-28 18:20 ` [PATCH 02/16] drm/amd/display: Remove CompBufReservedSpace* " Maíra Canal
2022-07-28 18:20 ` [PATCH 03/16] drm/amd/display: Remove DSCCLK_calculated " Maíra Canal
2022-07-28 18:20 ` [PATCH 04/16] drm/amd/display: Remove AllowDRAMSelfRefreshDuringVBlank " Maíra Canal
2022-07-28 18:20 ` [PATCH 05/16] drm/amd/display: Remove VStartupMargin and FirstMainPlane VBA variables Maíra Canal
2022-07-28 18:20 ` [PATCH 06/16] drm/amd/display: Remove ImmediateFlipSupportedSurface VBA variable Maíra Canal
2022-07-28 18:20 ` [PATCH 07/16] drm/amd/display: Remove WritebackAllowFCLKChangeEndPosition " Maíra Canal
2022-07-28 18:20 ` [PATCH 08/16] drm/amd/display: Remove some XFC variables from VBA Maíra Canal
2022-07-28 18:20 ` [PATCH 09/16] drm/amd/display: Remove SwathWidthCSingleDPP VBA variable Maíra Canal
2022-07-28 18:20 ` Maíra Canal [this message]
2022-07-28 18:20 ` [PATCH 11/16] drm/amd/display: Remove MPCCombineEnable " Maíra Canal
2022-07-28 18:20 ` [PATCH 12/16] drm/amd/display: Remove NumberOfDP2p0Support " Maíra Canal
2022-07-28 18:20 ` [PATCH 13/16] drm/amd/display: Remove TFinalxFill " Maíra Canal
2022-07-28 18:20 ` [PATCH 14/16] drm/amd/display: Remove MaximumDCCCompressionYSurface " Maíra Canal
2022-07-28 20:05 ` [PATCH 15/16] drm/amd/display: Remove only mencioned once VBA variables Maíra Canal
2022-07-28 20:06 ` [PATCH 16/16] drm/amd/display: Remove never used " Maíra Canal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220728182047.264825-11-mairacanal@riseup.net \
    --to=mairacanal@riseup.net \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrealmeid@riseup.net \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=harry.wentland@amd.com \
    --cc=isabbasso@riseup.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magalilemes00@gmail.com \
    --cc=mwen@igalia.com \
    --cc=sunpeng.li@amd.com \
    --cc=tales.aparecida@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).