Re: [PATCH 1/4] drm/amdgpu: don't try to reserve training bo for sriov

["Christian König" <ckoenig.leichtzumerken@gmail.com>]

Am 24.03.20 um 11:58 schrieb Monk Liu:
> 1) SRIOV guest KMD doesn't care training buffer
> 2) if we resered training buffer that will overlap with IP discovery
> reservation because training buffer is at vram_size - 0x8000 and
> IP discovery is at ()vram_size - 0x10000 => vram_size -1)
>
> Signed-off-by: Monk Liu <Monk.Liu@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index 665db23..54cfa3a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -1859,9 +1859,10 @@ int amdgpu_ttm_init(struct amdgpu_device *adev)
>   	 *The reserved vram for memory training must be pinned to the specified
>   	 *place on the VRAM, so reserve it early.
>   	 */
> -	r = amdgpu_ttm_training_reserve_vram_init(adev);
> -	if (r)
> -		return r;
> +	if (!amdgpu_sriov_vf(adev))
> +		r = amdgpu_ttm_training_reserve_vram_init(adev);
> +		if (r)
> +			return r;

Missing { } here, apart from that the series looks good to me.

Christian.

>   
>   	/* allocate memory as required for VGA
>   	 * This is used for VGA emulation and pre-OS scanout buffers to

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx