From: "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@amd.com>
To: amd-gfx@lists.freedesktop.org
Cc: Felix Kuehling <felix.kuehling@amd.com>
Subject: Re: [PATCH 2/2] drm/amdgpu: enable runtime pm on vega10 when noretry=0
Date: Wed, 24 Jun 2020 20:06:22 -0400 [thread overview]
Message-ID: <59f8ba89-24d4-cc1c-c573-41534978d262@amd.com> (raw)
In-Reply-To: <20200624190519.2378793-2-alexander.deucher@amd.com>
On 6/24/2020 3:05 PM, Alex Deucher wrote:
> [CAUTION: External Email]
>
> The failures with ROCm only happen with noretry=1, so
> enable runtime pm when noretry=0 (the current default).
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index 0fec39eed164..341d072edd95 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -176,7 +176,6 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
> case CHIP_BONAIRE:
> case CHIP_HAWAII:
> #endif
> - case CHIP_VEGA10:
> case CHIP_VEGA20:
> case CHIP_ARCTURUS:
> case CHIP_SIENNA_CICHLID:
> @@ -184,6 +183,11 @@ int amdgpu_driver_load_kms(struct drm_device *dev, unsigned long flags)
> if (amdgpu_runtime_pm > 0)
> adev->runpm = true;
> break;
> + case CHIP_VEGA10:
> + /* turn runpm on if noretry=0 */
> + if (!amdgpu_noretry)
> + adev->runpm = true;
> + break;
Though it fixes the ROCm pytorch issue but aren't there any stability
and performance optimization concerns as it will impact recoverable page
faults?
I have no objection to this otherwise.
+ felix
Acked-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@amd.com>
> default:
> /* enable runpm on VI+ */
> adev->runpm = true;
> --
> 2.25.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Crajneesh.bhardwaj%40amd.com%7Cc985ef0414bd41b48eb508d8187196ed%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637286223437553622&sdata=wRJbu3%2F3zu%2BHZ3KA%2FZmyh1yhgATM2zONRr%2FvI5KsxrM%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-06-25 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 19:05 [PATCH 1/2] drm/amdgpu: rework runtime pm enablement for BACO Alex Deucher
2020-06-24 19:05 ` [PATCH 2/2] drm/amdgpu: enable runtime pm on vega10 when noretry=0 Alex Deucher
2020-06-25 0:06 ` Bhardwaj, Rajneesh [this message]
2020-06-25 2:06 ` Felix Kuehling
2020-06-25 0:16 ` [PATCH 1/2] drm/amdgpu: rework runtime pm enablement for BACO Bhardwaj, Rajneesh
2020-06-25 13:45 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59f8ba89-24d4-cc1c-c573-41534978d262@amd.com \
--to=rajneesh.bhardwaj@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).