AMD-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: Luben Tuikov <luben.tuikov@amd.com>
To: Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
	amd-gfx@lists.freedesktop.org
Cc: alexdeucher@gmail.com, Ken.Qiao@amd.com, Marek.Olsak@amd.com,
	ckoenig.leichtzumerken@gmail.com
Subject: Re: [PATCH v2 0/4] Invalidate and flush caches at the beginning of every gfx IB
Date: Thu, 26 Mar 2020 19:20:04 -0400
Message-ID: <86b2c848-2d09-8803-2c22-66fe29c3c0fb@amd.com> (raw)
In-Reply-To: <1585252968-1218-1-git-send-email-andrey.grodzovsky@amd.com>

Looks great, except the note on patch 4 about the commit description text,
and perhaps we don't need a period in the title of patch 3.

With those fixed, the series is Reviewed-by: Luben Tuikov <luben.tuikov@amd.com>

Thank you Andrey.

Regards,
Luben


On 2020-03-26 16:02, Andrey Grodzovsky wrote:
> This patchset introduces AQUIRE_MEM packet submission at the begining of each gfx IB
> if requested by user mode client. This is helpful in solving issues with cache coherency
> during amdgpu_test and Vulkan CTS tests.
> 
> Andrey Grodzovsky (4):
>   drm/amdgpu: Add new ring callback to insert memory sync
>   drm/amdgpu: Add AQUIRE_MEM PACKET3 fields defintion
>   drm/amdgpu: Add mem_sync implementation for all the ASICs.
>   drm/amdgpu: Add a UAPI flag for user to call mem_sync
> 
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c  |  3 +-
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c   |  3 ++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h |  1 +
>  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c   | 27 +++++++++++++++++-
>  drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c    | 16 ++++++++++-
>  drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c    | 16 ++++++++++-
>  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c    | 17 ++++++++++-
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c    | 22 ++++++++++++++-
>  drivers/gpu/drm/amd/amdgpu/nvd.h         | 48 ++++++++++++++++++++++++++++++++
>  drivers/gpu/drm/amd/amdgpu/soc15d.h      | 25 ++++++++++++++++-
>  include/uapi/drm/amdgpu_drm.h            |  4 +++
>  11 files changed, 175 insertions(+), 7 deletions(-)
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 20:02 Andrey Grodzovsky
2020-03-26 20:02 ` [PATCH v2 1/4] drm/amdgpu: Add new ring callback to insert memory sync Andrey Grodzovsky
2020-03-26 20:02 ` [PATCH v2 2/4] drm/amdgpu: Add AQUIRE_MEM PACKET3 fields defintion Andrey Grodzovsky
2020-03-26 23:09   ` Luben Tuikov
2020-03-26 20:02 ` [PATCH v2 3/4] drm/amdgpu: Add mem_sync implementation for all the ASICs Andrey Grodzovsky
2020-03-26 20:02 ` [PATCH v2 4/4] drm/amdgpu: Add a UAPI flag for user to call mem_sync Andrey Grodzovsky
2020-03-26 23:17   ` Luben Tuikov
2020-03-26 23:20 ` Luben Tuikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86b2c848-2d09-8803-2c22-66fe29c3c0fb@amd.com \
    --to=luben.tuikov@amd.com \
    --cc=Ken.Qiao@amd.com \
    --cc=Marek.Olsak@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrey.grodzovsky@amd.com \
    --cc=ckoenig.leichtzumerken@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

AMD-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/amd-gfx/0 amd-gfx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 amd-gfx amd-gfx/ https://lore.kernel.org/amd-gfx \
		amd-gfx@lists.freedesktop.org
	public-inbox-index amd-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.amd-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git