From: Felix Kuehling <felix.kuehling@amd.com>
To: Philip Yang <Philip.Yang@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/amdkfd: new range accessible by all GPUs
Date: Tue, 11 May 2021 11:39:53 -0400 [thread overview]
Message-ID: <960a368b-ee89-9a30-2dd7-9c5dcba3129a@amd.com> (raw)
In-Reply-To: <20210511151504.31849-1-Philip.Yang@amd.com>
Am 2021-05-11 um 11:15 a.m. schrieb Philip Yang:
> If xnack is on, new range is created to recover retry vm fault or
> created by SVM API calls, set all GPUs have access to the range.
>
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index d9111fea724b..6a677bdfcadb 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -258,6 +258,7 @@ svm_range *svm_range_new(struct svm_range_list *svms, uint64_t start,
> {
> uint64_t size = last - start + 1;
> struct svm_range *prange;
> + struct kfd_process *p;
>
> prange = kzalloc(sizeof(*prange), GFP_KERNEL);
> if (!prange)
> @@ -277,6 +278,11 @@ svm_range *svm_range_new(struct svm_range_list *svms, uint64_t start,
> prange->validate_timestamp = 0;
> mutex_init(&prange->migrate_mutex);
> mutex_init(&prange->lock);
> +
> + p = container_of(svms, struct kfd_process, svms);
> + if (p->xnack_enabled)
> + bitmap_fill(prange->bitmap_access, MAX_GPU_INSTANCE);
> +
> svm_range_set_default_attributes(&prange->preferred_loc,
> &prange->prefetch_loc,
> &prange->granularity, &prange->flags);
> @@ -2243,7 +2249,7 @@ svm_range *svm_range_create_unregistered_range(struct amdgpu_device *adev,
>
> prange = svm_range_new(&p->svms, start, last);
> if (!prange) {
> - pr_debug("Failed to create prange in address [0x%llx]\\n", addr);
> + pr_debug("Failed to create prange in address [0x%llx]\n", addr);
> return NULL;
> }
> if (kfd_process_gpuid_from_kgd(p, adev, &gpuid, &gpuidx)) {
> @@ -2251,9 +2257,7 @@ svm_range *svm_range_create_unregistered_range(struct amdgpu_device *adev,
> svm_range_free(prange);
> return NULL;
> }
> - prange->preferred_loc = gpuid;
> - prange->actual_loc = 0;
> - /* Gurantee prange is migrate it */
> +
> svm_range_add_to_svms(prange);
> svm_range_add_notifier_locked(mm, prange);
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-05-11 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 17:56 [PATCH 1/2] drm/amdkfd: set prefetch GPU has access attribute Philip Yang
2021-05-05 17:56 ` [PATCH 2/2] drm/amdkfd: set new unregistered range accessible by GPU Philip Yang
2021-05-05 20:03 ` Felix Kuehling
2021-05-07 19:07 ` [PATCH 2/2] drm/amdkfd: unregistered range accessible by all GPUs Philip Yang
2021-05-10 12:56 ` Felix Kuehling
2021-05-11 15:14 ` philip yang
2021-05-11 15:15 ` [PATCH v2 2/2] drm/amdkfd: new " Philip Yang
2021-05-11 15:39 ` Felix Kuehling [this message]
2021-05-05 20:01 ` [PATCH 1/2] drm/amdkfd: set prefetch GPU has access attribute Felix Kuehling
2021-05-05 20:10 ` Felix Kuehling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=960a368b-ee89-9a30-2dd7-9c5dcba3129a@amd.com \
--to=felix.kuehling@amd.com \
--cc=Philip.Yang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).