amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: "Christian König" <christian.koenig@amd.com>,
	"Guchun Chen" <guchun.chen@amd.com>,
	"Luben Tuikov" <luben.tuikov@amd.com>
Cc: kernel@gpiccoli.net, Xinhui.Pan@amd.com,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	kernel-dev@igalia.com, alexander.deucher@amd.com,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v2] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini
Date: Thu, 2 Feb 2023 10:52:03 -0300	[thread overview]
Message-ID: <9f35c852-18c4-2f3f-d03b-ff76def8516a@igalia.com> (raw)
In-Reply-To: <cd0e2994-f85f-d837-609f-7056d5fb7231@amd.com>

On 02/02/2023 08:58, Christian König wrote:
> [...]
>> +		if (!ring->no_scheduler && ring->sched.ops)
>>   			drm_sched_fini(&ring->sched);
> 
> I think we should drop the check for no_scheduler here and just call 
> drm_sched_fini() when the scheduler instance was initialized before.
> 
> Background is that I've found a couple of places where we potentially 
> set no_scheduler to false after the scheduler was already initialized.
> 
> This is then probably leading to a memory leak or worth.
> 
> Regards,
> Christian.

Thanks Christian, nice finding! And thanks for the reviews Guchun / Luben =)

I just submitted a V3 [0], but didn't add the review tags from Guchun /
Luben, since the patch changed.

Cheers,


Guilherme


[0]
https://lore.kernel.org/dri-devel/20230202134856.1382169-1-gpiccoli@igalia.com/

      reply	other threads:[~2023-02-02 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 16:48 [PATCH v2] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini Guilherme G. Piccoli
2023-02-01 17:02 ` Luben Tuikov
2023-02-02  1:34 ` Chen, Guchun
2023-02-02 11:58 ` Christian König
2023-02-02 13:52   ` Guilherme G. Piccoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f35c852-18c4-2f3f-d03b-ff76def8516a@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=guchun.chen@amd.com \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=luben.tuikov@amd.com \
    --cc=mario.limonciello@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).