From: "Yang, Stanley" <Stanley.Yang@amd.com>
To: "Zhang, Hawking" <Hawking.Zhang@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Zhou1, Tao" <Tao.Zhou1@amd.com>
Cc: "Zhang, Hawking" <Hawking.Zhang@amd.com>
Subject: RE: [PATCH] drm/amdgpu: Initialize umc ras callback
Date: Mon, 20 Mar 2023 09:40:08 +0000 [thread overview]
Message-ID: <BL1PR12MB53348BC9B779601FB167010D9A809@BL1PR12MB5334.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230320093648.30914-1-Hawking.Zhang@amd.com>
[AMD Official Use Only - General]
Reviewed-by: Stanley Yang <Stanley.Yang@amd.com>
Regards,
Stanley
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Hawking Zhang
> Sent: Monday, March 20, 2023 5:37 PM
> To: amd-gfx@lists.freedesktop.org; Zhou1, Tao <Tao.Zhou1@amd.com>
> Cc: Zhang, Hawking <Hawking.Zhang@amd.com>
> Subject: [PATCH] drm/amdgpu: Initialize umc ras callback
>
> Fix a coding error which results to null interrupt handler for umc ras.
>
> Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
> index da68ceaa024c..9e2e97207e53 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
> @@ -232,7 +232,7 @@ int amdgpu_umc_ras_sw_init(struct amdgpu_device
> *adev)
> if (!ras->ras_block.ras_late_init)
> ras->ras_block.ras_late_init = amdgpu_umc_ras_late_init;
>
> - if (ras->ras_block.ras_cb)
> + if (!ras->ras_block.ras_cb)
> ras->ras_block.ras_cb = amdgpu_umc_process_ras_data_cb;
>
> return 0;
> --
> 2.17.1
prev parent reply other threads:[~2023-03-20 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 9:36 [PATCH] drm/amdgpu: Initialize umc ras callback Hawking Zhang
2023-03-20 9:40 ` Yang, Stanley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR12MB53348BC9B779601FB167010D9A809@BL1PR12MB5334.namprd12.prod.outlook.com \
--to=stanley.yang@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Tao.Zhou1@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).