amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: Dave Airlie <airlied@linux.ie>,
	Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/radeon/cik: remove set but not used variables
Date: Thu, 15 Apr 2021 12:20:16 -0400	[thread overview]
Message-ID: <CADnq5_M-236qN22kyypzVDvOj0RnFLegqoiTkSFuquqe6o0JYg@mail.gmail.com> (raw)
In-Reply-To: <1618284379-28126-1-git-send-email-tiantao6@hisilicon.com>

On Mon, Apr 12, 2021 at 11:26 PM Tian Tao <tiantao6@hisilicon.com> wrote:
>
> The value of pipe_id and queue_id  are not used under certain
> circumstances, so just delete.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/cik.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
> index 8b7a4f7..42a8afa 100644
> --- a/drivers/gpu/drm/radeon/cik.c
> +++ b/drivers/gpu/drm/radeon/cik.c
> @@ -7948,8 +7948,6 @@ int cik_irq_process(struct radeon_device *rdev)
>                         DRM_ERROR("Illegal register access in command stream\n");
>                         /* XXX check the bitfield order! */
>                         me_id = (ring_id & 0x60) >> 5;
> -                       pipe_id = (ring_id & 0x18) >> 3;
> -                       queue_id = (ring_id & 0x7) >> 0;
>                         switch (me_id) {
>                         case 0:
>                                 /* This results in a full GPU reset, but all we need to do is soft
> @@ -7971,8 +7969,6 @@ int cik_irq_process(struct radeon_device *rdev)
>                         DRM_ERROR("Illegal instruction in command stream\n");
>                         /* XXX check the bitfield order! */
>                         me_id = (ring_id & 0x60) >> 5;
> -                       pipe_id = (ring_id & 0x18) >> 3;
> -                       queue_id = (ring_id & 0x7) >> 0;
>                         switch (me_id) {
>                         case 0:
>                                 /* This results in a full GPU reset, but all we need to do is soft
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      reply	other threads:[~2021-04-15 16:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13  3:26 [PATCH] drm/radeon/cik: remove set but not used variables Tian Tao
2021-04-15 16:20 ` Alex Deucher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADnq5_M-236qN22kyypzVDvOj0RnFLegqoiTkSFuquqe6o0JYg@mail.gmail.com \
    --to=alexdeucher@gmail.com \
    --cc=airlied@linux.ie \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tiantao6@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).