From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6F2C4363A for ; Fri, 30 Oct 2020 03:53:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC55C2068E for ; Fri, 30 Oct 2020 03:53:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lDwiUGqe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC55C2068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E97536E94C; Fri, 30 Oct 2020 03:53:28 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5711D6E94C; Fri, 30 Oct 2020 03:53:28 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id c16so1706706wmd.2; Thu, 29 Oct 2020 20:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2FD2h7D4v2HS4oDKnH1ozkl5z/Z0lmckPIvoRH81OaE=; b=lDwiUGqe31YYTdcVzh2ub/9hCxgwWbd4hg6znAi74KYcScH0EqreAG4C1XmeV0kkpr 4BHK/9Z/rRbK5WVSko+DcPz1K3OA66BJL1FcM2WKFTJLpzyLYh4bMPZlt3zpL4AZ5ooQ O2qjHrGiWXyqLfyoxsNaWpXnF0OGpNTufvrdVm6r2UF6TuUQozh+/zKS8Xu7R5GmeC3d gMSFPgfX7Iuvsql+XtxR/7WZlqAuM/h+pTu5k7WTc0nJBQ+xZIbtjuxsv+H5T5vFP8ti RlGlPocWeEzuPBf3DvYMWXIMAi0XJe0lg1hKn0i+u04cDID55sfZMqnhL6k4/Ff3219L E2gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2FD2h7D4v2HS4oDKnH1ozkl5z/Z0lmckPIvoRH81OaE=; b=UElQChjy/ASIXw4YKZishcaZCAOlDpeLZ3MJ3oRJsNMQoueBYYAzmVgwMj5OA0EdAA 6DSe8hueYdrdlYBe0hzUJdx3Z8YajqTlTxxU3LaF2ViH9jD014bfD0DXT88Pjg45Zxhz jO6TSN7E7h5zwkQthk8eoAWlFFbtlOuC5TMfPQ36QEmjvl0LgOHe5+5HrTr590Hn9Jd8 EE+na7n4WOs8v1Um56F37qfrvEfuv8LELMDJlrp1l7UkwlunDkrPOplATHOZ8i/kztw5 ay+1Suw/r3R0Qjpk+KLrq1jY+VsJSQ4QUmWX1ISRIM4jfOfm9H0PqFWNZs6XxXaoPRrg Sc1A== X-Gm-Message-State: AOAM532neHjo9jHuUKKZ3fbA9mKanvma5rXX7qPa5QQhpGfyFwp5FhZx lacf8xWTDK7CqZhBZkPsEQBsPs1as1U/zy4XJkQ= X-Google-Smtp-Source: ABdhPJwmM5iqHlfZ6Cf/n9mn4d3K9CcA0cI58sMTvHlsxSEJSmOe/+uzB8GaUumH85FrOM3YWbSwfQLbgHq6ZDb7jIM= X-Received: by 2002:a05:600c:25a:: with SMTP id 26mr247532wmj.39.1604030007030; Thu, 29 Oct 2020 20:53:27 -0700 (PDT) MIME-Version: 1.0 References: <20201026210039.3884312-1-arnd@kernel.org> <20201026210039.3884312-4-arnd@kernel.org> In-Reply-To: <20201026210039.3884312-4-arnd@kernel.org> From: Alex Deucher Date: Thu, 29 Oct 2020 23:53:15 -0400 Message-ID: Subject: Re: [PATCH 4/5] drm/amdgpu: fix build_coefficients() argument To: Arnd Bergmann X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lewis Huang , Aric Cyr , Krunoslav Kovac , Arnd Bergmann , Leo Li , Anthony Koo , LKML , Maling list - DRI developers , Nicholas Kazlauskas , Josip Pavic , David Airlie , Reza Amini , Denis Efremov , Daniel Vetter , Alex Deucher , amd-gfx list , Harry Wentland , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Oct 26, 2020 at 5:01 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > gcc -Wextra warns about a function taking an enum argument > being called with a bool: > > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c: In function 'apply_degamma_for_user_regamma': > drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:1617:29: warning: implicit conversion from 'enum ' to 'enum dc_transfer_func_predefined' [-Wenum-conversion] > 1617 | build_coefficients(&coeff, true); > > It appears that a patch was added using the old calling conventions > after the type was changed, and the value should actually be 0 > (TRANSFER_FUNCTION_SRGB) here instead of 1 (true). This looks correct to me. Harry, Leo? Alex > > Fixes: 55a01d4023ce ("drm/amd/display: Add user_regamma to color module") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c > index b8695660b480..09bc2c249e1a 100644 > --- a/drivers/gpu/drm/amd/display/modules/color/color_gamma.c > +++ b/drivers/gpu/drm/amd/display/modules/color/color_gamma.c > @@ -1614,7 +1614,7 @@ static void apply_degamma_for_user_regamma(struct pwl_float_data_ex *rgb_regamma > struct pwl_float_data_ex *rgb = rgb_regamma; > const struct hw_x_point *coord_x = coordinates_x; > > - build_coefficients(&coeff, true); > + build_coefficients(&coeff, TRANSFER_FUNCTION_SRGB); > > i = 0; > while (i != hw_points_num + 1) { > -- > 2.27.0 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx