From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B757C433E1 for ; Mon, 29 Jun 2020 21:59:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B92206A5 for ; Mon, 29 Jun 2020 21:59:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q0M3F/Lp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32B92206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 01C0489C1F; Mon, 29 Jun 2020 21:59:08 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id A437789C1F for ; Mon, 29 Jun 2020 21:59:07 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id o8so16907138wmh.4 for ; Mon, 29 Jun 2020 14:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=llEzq10FQ4xf80k9hEEuHp3zdhQVka6KUuAt6abF4G4=; b=q0M3F/Lpxpq9sgllozdk7X23l+Ha8ANnguIcVUTZ2H8M54dBvXrSqtXDpZ01SW+4v9 31ybmw7xaW2MHMHdUYt+dyfAkaHWds8qrdH/Pb6EjC9dY4nsxmA6f3Air2e8JzRfRHWp 7oo0PudQjmcl7N0QOS3/WKkl0p6ANx3SxAFHHCnC8v5/4b1mv+9IXyEzc9WkCnSjLgX2 LwQLXefwy4vcWMkuY+vypM9ytCw/NHcTVBsmA8sJHY/vECfKwQqMLNrZgNH6UAlbxMYY fml+shU0zlcIUtmfqECWaLgEaVcMuyQzcMBfKe3IWJx8c9R40zhOF9M9MA7AmattU5UC 3F9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=llEzq10FQ4xf80k9hEEuHp3zdhQVka6KUuAt6abF4G4=; b=IUDB5GlLhGw5aiME0ExYC1MTJvywFSDfKu8DFAllb5YDKxHS/AiTQiEMzck5ofoy27 ycoRWiAZ29coV2OvHa05hfQ0tBEeXEmpYVDMQ2Xwx7beU4qj2DZhaXHL25owo0gNoWP4 H/UtLlkwXiX4sGQ3NzkBef2Lp4xiLkfcXgnidmMx6O4jsNI7V3/q20OWBjoOLG+CfDdK zfL8Q8m2PfkdjLXw4c7Ct+vUgvMQejFL7G6MJAvlh7ko7pa/TfEA2qMuw/OcYQCzTOsa cro60TzrhhlenM17XFHvvVZ5CMUWymbo++xObmRrTT6spuHbY86vb1fbJvI5WuLG2xz0 wTqw== X-Gm-Message-State: AOAM530hRXHyMtFvm4scSPlULHFt2aH6R/1WmJ9Y3Tpm6t+KdLuAlImv W2K7CLD2hQUDyQma4ge6mEs+9dBv4fn1MmPJNSs= X-Google-Smtp-Source: ABdhPJzdktDyNp1p2R7yd/Lk2vq4mC/NMapJ33qVHnp+TRuZ+zeMYurOuQhkKbwzZr8/r9AqOj17LNX31AN3cV4jlRg= X-Received: by 2002:a1c:3954:: with SMTP id g81mr18383805wma.73.1593467946358; Mon, 29 Jun 2020 14:59:06 -0700 (PDT) MIME-Version: 1.0 References: <20200629204924.13426-1-nicholas.kazlauskas@amd.com> In-Reply-To: <20200629204924.13426-1-nicholas.kazlauskas@amd.com> From: Alex Deucher Date: Mon, 29 Jun 2020 17:58:55 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: Only revalidate bandwidth on medium and fast updates To: Nicholas Kazlauskas X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hersen Wu , Rodrigo Siqueira , Bhawanpreet Lakha , amd-gfx list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Jun 29, 2020 at 4:49 PM Nicholas Kazlauskas wrote: > > [Why] > Changes that are fast don't require updating DLG parameters making > this call unnecessary. Considering this is an expensive call it should > not be done on every flip. > > DML touches clocks, p-state support, DLG params and a few other DC > internal flags and these aren't expected during fast. A hang has been > reported with this change when called on every flip which suggests that > modifying these fields is not recommended behavior on fast updates. > > [How] > Guard the validation to only happen if update type isn't FAST. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1191 > Fixes: e1995f0909e3 ("drm/amd/display: Revalidate bandwidth before commiting DC updates") > Cc: Hersen Wu > Cc: Bhawanpreet Lakha > Cc: Rodrigo Siqueira > Signed-off-by: Nicholas Kazlauskas Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/core/dc.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c > index 67402d75e67e..942ceb0f6383 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c > @@ -2607,10 +2607,12 @@ void dc_commit_updates_for_stream(struct dc *dc, > > copy_stream_update_to_stream(dc, context, stream, stream_update); > > - if (!dc->res_pool->funcs->validate_bandwidth(dc, context, false)) { > - DC_ERROR("Mode validation failed for stream update!\n"); > - dc_release_state(context); > - return; > + if (update_type > UPDATE_TYPE_FAST) { > + if (!dc->res_pool->funcs->validate_bandwidth(dc, context, false)) { > + DC_ERROR("Mode validation failed for stream update!\n"); > + dc_release_state(context); > + return; > + } > } > > commit_planes_for_stream( > -- > 2.25.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx