From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH -next] drm/amd/display: remove set but not used variable 'bpc' Date: Mon, 11 Nov 2019 13:01:11 -0500 Message-ID: References: <20191109093538.23964-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20191109093538.23964-1-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: YueHaibing Cc: "Wentland, Harry" , "Leo (Sunpeng) Li" , "Deucher, Alexander" , Christian Koenig , Chunming Zhou , Dave Airlie , Daniel Vetter , Bhawanpreet Lakha , Jun Lei , Anthony Koo , Zhan Liu , Maling list - DRI developers , amd-gfx list , LKML List-Id: amd-gfx.lists.freedesktop.org Applied. Thanks! Alex On Sun, Nov 10, 2019 at 9:30 PM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c: In function get_pbn_from_timing: > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:2364:11: warning: > variable bpc set but not used [-Wunused-but-set-variable] > > It is not used since commit e49f69363adf ("drm/amd/display: use > proper formula to calculate bandwidth from timing") > > Signed-off-by: YueHaibing > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > index bdc8be3..53394e2 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > @@ -2653,13 +2653,11 @@ static int get_color_depth(enum dc_color_depth color_depth) > > static struct fixed31_32 get_pbn_from_timing(struct pipe_ctx *pipe_ctx) > { > - uint32_t bpc; > uint64_t kbps; > struct fixed31_32 peak_kbps; > uint32_t numerator; > uint32_t denominator; > > - bpc = get_color_depth(pipe_ctx->stream_res.pix_clk_params.color_depth); > kbps = dc_bandwidth_in_kbps_from_timing(&pipe_ctx->stream->timing); > > /* > -- > 2.7.4 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F7EC43331 for ; Mon, 11 Nov 2019 18:01:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AB02206BA for ; Mon, 11 Nov 2019 18:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AB02206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E0646E9B3; Mon, 11 Nov 2019 18:01:27 +0000 (UTC) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id C34586E9B2; Mon, 11 Nov 2019 18:01:25 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id z19so225325wmk.3; Mon, 11 Nov 2019 10:01:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LZm0O+9adBfpx+ovnSPJOcOY1JX1dPWpztVmEz4llkE=; b=agd0ztKbuwi6fJF4++Wx5CpvwgAANS0swSxRA7aW9+bRjGHPTzCvdZrr5lpdqAtLHz opKZkNKJ26pstunu6X3E6HeNhzQC+uzokGU7D262Vy01AY8LSPeis6Y/EDWXR+cr4Hne F09yzDXHFh3YluBEBMNDotBp7ayCYAmAMd26aJnlf/bOPpFy7RbGybIObqdDzeTsZgmX o4xzdpiK9D9CDRXxJAEZvZrY07nzL5tyJ/wPDeDgbaTjbITk2RBBhFY5mfuYhA28eDL1 baTpHbAorObRfjpitv3gQuy3B/d17vkRlHTQgRyQ6u1c/sIreWJK39MKdQjInmg3ETjX MYeA== X-Gm-Message-State: APjAAAVcxxQg6dZF0zf+PHDiH+yObEyeEYrA3pLYgoUyMYiCchDrchfE q6AOJTtu+EUtk6IFwrASTK8CnmcrnkCuIm7wr5E= X-Google-Smtp-Source: APXvYqx3F2xEQnEwJIJbF32491P4OsB8Wm3WOoRDkOVtWpzT+0v4cABkBIFm0/KZ3L3bKl0dq1GLJiYXU85t9P2VkwI= X-Received: by 2002:a1c:790b:: with SMTP id l11mr200549wme.127.1573495284364; Mon, 11 Nov 2019 10:01:24 -0800 (PST) MIME-Version: 1.0 References: <20191109093538.23964-1-yuehaibing@huawei.com> In-Reply-To: <20191109093538.23964-1-yuehaibing@huawei.com> From: Alex Deucher Date: Mon, 11 Nov 2019 13:01:11 -0500 Message-ID: Subject: Re: [PATCH -next] drm/amd/display: remove set but not used variable 'bpc' To: YueHaibing X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LZm0O+9adBfpx+ovnSPJOcOY1JX1dPWpztVmEz4llkE=; b=Csn/2IzCJ6MEF+fyZKlzifXzPAy8ny1P4ICBVPnPsRGKuub7/rNPpw/Qn3CGNuuxy5 WtxeQ+DpHHi1LRluKoais2+875spWmUBYjiSIqIbluzGGNliVcglPlVSR46ebYq76qAc BcyVjUlIWB9KPVe5mWhY8rRxEIG2ZD/KiSvIBmEGVxQBqa1koidTmQ6V3yXmH0aigPSF Jq+AY0MRvqSBxIW8ZOSGQLOWNbhMcnW1i/SlF47dc4bnPvjvFGMPOG0wdcuUa71RLpGF oMqKEmjNCin2r9u4BYC2Gorsi/pDfgPb2JCpbApUeu2+KOJ1tHcbXk4M/fUGmWNgauDO FbpA== X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chunming Zhou , "Leo \(Sunpeng\) Li" , Bhawanpreet Lakha , Zhan Liu , LKML , Maling list - DRI developers , Dave Airlie , amd-gfx list , Daniel Vetter , "Deucher, Alexander" , Jun Lei , "Wentland, Harry" , Christian Koenig , Anthony Koo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Message-ID: <20191111180111.pG5JJO6vHO8qUORAAJ8E7HfUwENzRv_LfilykhTu96E@z> QXBwbGllZC4gIFRoYW5rcyEKCkFsZXgKCk9uIFN1biwgTm92IDEwLCAyMDE5IGF0IDk6MzAgUE0g WXVlSGFpYmluZyA8eXVlaGFpYmluZ0BodWF3ZWkuY29tPiB3cm90ZToKPgo+IEZpeGVzIGdjYyAn LVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZScgd2FybmluZzoKPgo+IGRyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvZGMvY29yZS9kY19saW5rLmM6IEluIGZ1bmN0aW9uIGdldF9w Ym5fZnJvbV90aW1pbmc6Cj4gZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvLi4vZGlzcGxheS9k Yy9jb3JlL2RjX2xpbmsuYzoyMzY0OjExOiB3YXJuaW5nOgo+ICB2YXJpYWJsZSBicGMgc2V0IGJ1 dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPgo+IEl0IGlzIG5vdCB1c2Vk IHNpbmNlIGNvbW1pdCBlNDlmNjkzNjNhZGYgKCJkcm0vYW1kL2Rpc3BsYXk6IHVzZQo+IHByb3Bl ciBmb3JtdWxhIHRvIGNhbGN1bGF0ZSBiYW5kd2lkdGggZnJvbSB0aW1pbmciKQo+Cj4gU2lnbmVk LW9mZi1ieTogWXVlSGFpYmluZyA8eXVlaGFpYmluZ0BodWF3ZWkuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvZGMvY29yZS9kY19saW5rLmMgfCAyIC0tCj4gIDEgZmls ZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvZGlzcGxheS9kYy9jb3JlL2RjX2xpbmsuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlz cGxheS9kYy9jb3JlL2RjX2xpbmsuYwo+IGluZGV4IGJkYzhiZTMuLjUzMzk0ZTIgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NvcmUvZGNfbGluay5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2NvcmUvZGNfbGluay5jCj4gQEAgLTI2 NTMsMTMgKzI2NTMsMTEgQEAgc3RhdGljIGludCBnZXRfY29sb3JfZGVwdGgoZW51bSBkY19jb2xv cl9kZXB0aCBjb2xvcl9kZXB0aCkKPgo+ICBzdGF0aWMgc3RydWN0IGZpeGVkMzFfMzIgZ2V0X3Bi bl9mcm9tX3RpbWluZyhzdHJ1Y3QgcGlwZV9jdHggKnBpcGVfY3R4KQo+ICB7Cj4gLSAgICAgICB1 aW50MzJfdCBicGM7Cj4gICAgICAgICB1aW50NjRfdCBrYnBzOwo+ICAgICAgICAgc3RydWN0IGZp eGVkMzFfMzIgcGVha19rYnBzOwo+ICAgICAgICAgdWludDMyX3QgbnVtZXJhdG9yOwo+ICAgICAg ICAgdWludDMyX3QgZGVub21pbmF0b3I7Cj4KPiAtICAgICAgIGJwYyA9IGdldF9jb2xvcl9kZXB0 aChwaXBlX2N0eC0+c3RyZWFtX3Jlcy5waXhfY2xrX3BhcmFtcy5jb2xvcl9kZXB0aCk7Cj4gICAg ICAgICBrYnBzID0gZGNfYmFuZHdpZHRoX2luX2ticHNfZnJvbV90aW1pbmcoJnBpcGVfY3R4LT5z dHJlYW0tPnRpbWluZyk7Cj4KPiAgICAgICAgIC8qCj4gLS0KPiAyLjcuNAo+Cj4KPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QK YW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4