From: Alex Deucher <alexdeucher@gmail.com>
To: Lee Jones <lee@kernel.org>
Cc: "Leo Li" <sunpeng.li@amd.com>,
"Wenjing Liu" <wenjing.liu@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, "Daniel Vetter" <daniel@ffwll.ch>,
"Harry Wentland" <harry.wentland@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 32/37] drm/amd/display/dc/link/protocols/link_dp_capability: Remove unused variable and mark another as __maybe_unused
Date: Fri, 17 Mar 2023 16:41:30 -0400 [thread overview]
Message-ID: <CADnq5_OPSz7mv3MHXY559pe_We45-C+Au4mgSoBEK5bcoaMp+g@mail.gmail.com> (raw)
In-Reply-To: <20230317081718.2650744-33-lee@kernel.org>
Applied. Thanks!
Alex
On Fri, Mar 17, 2023 at 4:23 AM Lee Jones <lee@kernel.org> wrote:
>
> ‘ds_port’ is clearly not used anywhere and ‘result_write_min_hblank’ is
> only utilised when debugging is enabled. The alternative would be to
> allocate the variable under the same clause as the debugging code, but
> that would become very messy, very quickly.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c: In function ‘dp_wa_power_up_0010FA’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:280:42: warning: variable ‘ds_port’ set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c: In function ‘dpcd_set_source_specific_data’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_dp_capability.c:1296:32: warning: variable ‘result_write_min_hblank’ set but not used [-Wunused-but-set-variable]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Wenjing Liu <wenjing.liu@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee@kernel.org>
> ---
> .../gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> index e9bcb35ae185a..51427f5081642 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_capability.c
> @@ -1284,7 +1284,7 @@ bool dp_overwrite_extended_receiver_cap(struct dc_link *link)
> void dpcd_set_source_specific_data(struct dc_link *link)
> {
> if (!link->dc->vendor_signature.is_valid) {
> - enum dc_status result_write_min_hblank = DC_NOT_SUPPORTED;
> + enum dc_status __maybe_unused result_write_min_hblank = DC_NOT_SUPPORTED;
> struct dpcd_amd_signature amd_signature = {0};
> struct dpcd_amd_device_id amd_device_id = {0};
>
> --
> 2.40.0.rc1.284.g88254d51c5-goog
>
next prev parent reply other threads:[~2023-03-17 20:41 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230317081718.2650744-1-lee@kernel.org>
2023-03-17 8:16 ` [PATCH 01/37] drm/amd/display/dc/dc_hdmi_types: Move string definition to the only file it's used in Lee Jones
2023-03-17 20:15 ` Alex Deucher
2023-03-17 8:16 ` [PATCH 03/37] drm/amd/amdgpu/amdgpu_device: Provide missing kerneldoc entry for 'reset_context' Lee Jones
2023-03-17 20:16 ` Alex Deucher
2023-03-17 8:16 ` [PATCH 13/37] drm/amd/amdgpu/amdgpu_ucode: Remove unused function ‘amdgpu_ucode_print_imu_hdr’ Lee Jones
2023-03-17 20:18 ` Alex Deucher
2023-03-17 8:16 ` [PATCH 14/37] drm/amd/amdgpu/amdgpu_vm_pt: Supply description for amdgpu_vm_pt_free_dfs()'s unlocked param Lee Jones
2023-03-17 20:21 ` Alex Deucher
2023-03-17 8:16 ` [PATCH 15/37] drm/amd/amdgpu/gmc_v11_0: Provide a few missing param descriptions relating to hubs and flushes Lee Jones
2023-03-17 20:22 ` Alex Deucher
2023-03-17 8:16 ` [PATCH 16/37] drm/amd/amdgpu/ih_v6_0: Repair misspelling and provide descriptions for 'ih' Lee Jones
2023-03-17 20:23 ` Alex Deucher
2023-03-17 8:16 ` [PATCH 17/37] drm/amd/amdgpu/amdgpu_mes: Ensure amdgpu_bo_create_kernel()'s return value is checked Lee Jones
2023-03-17 20:25 ` Alex Deucher
2023-03-17 8:16 ` [PATCH 18/37] drm/amd/amdgpu/amdgpu_vce: Provide description for amdgpu_vce_validate_bo()'s 'p' param Lee Jones
2023-03-17 20:27 ` Alex Deucher
2023-03-17 8:17 ` [PATCH 19/37] drm/amd/pm/swsmu/smu11/vangogh_ppt: Provide a couple of missing parameter descriptions Lee Jones
2023-03-17 20:28 ` Alex Deucher
2023-03-17 8:17 ` [PATCH 20/37] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move defines out to where they are actually used Lee Jones
2023-03-17 20:30 ` Alex Deucher
2023-03-17 8:17 ` [PATCH 26/37] drm/amd/display/amdgpu_dm/amdgpu_dm_helpers: Move SYNAPTICS_DEVICE_ID into CONFIG_DRM_AMD_DC_DCN ifdef Lee Jones
2023-03-17 20:32 ` Alex Deucher
2023-03-17 8:17 ` [PATCH 27/37] drm/amd/display/dc/dce/dmub_psr: Demote kerneldoc abuse Lee Jones
2023-03-17 20:33 ` Alex Deucher
2023-03-17 8:17 ` [PATCH 28/37] drm/amd/display/dc/core/dc_stat: Convert a couple of doc headers to kerneldoc format Lee Jones
2023-03-17 20:36 ` Alex Deucher
2023-03-20 8:19 ` Lee Jones
2023-03-20 13:11 ` Harry Wentland
2023-03-20 13:25 ` Lee Jones
2023-03-20 14:04 ` Hamza Mahfooz
2023-03-17 8:17 ` [PATCH 29/37] drm/amd/display/dc/link/link_detection: Remove unused variable 'status' Lee Jones
2023-03-17 20:38 ` Alex Deucher
2023-03-17 8:17 ` [PATCH 30/37] drm/amd/display/dc/link/protocols/link_dp_training: Remove set but unused variable 'result' Lee Jones
2023-03-17 20:39 ` Alex Deucher
2023-03-17 8:17 ` [PATCH 32/37] drm/amd/display/dc/link/protocols/link_dp_capability: Remove unused variable and mark another as __maybe_unused Lee Jones
2023-03-17 20:41 ` Alex Deucher [this message]
2023-03-17 8:17 ` [PATCH 33/37] drm/amd/display/dc/link/protocols/link_dp_capability: Demote non-compliant kerneldoc Lee Jones
2023-03-17 20:42 ` Alex Deucher
2023-03-17 8:17 ` [PATCH 35/37] drm/amd/display/dc/dce60/Makefile: Fix previous attempt to silence known override-init warnings Lee Jones
2023-03-17 20:43 ` Alex Deucher
2023-03-17 8:17 ` [PATCH 36/37] drm/amd/display/dc/link/link_detection: Demote a couple of kerneldoc abuses Lee Jones
2023-03-17 20:44 ` Alex Deucher
2023-03-20 8:23 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_OPSz7mv3MHXY559pe_We45-C+Au4mgSoBEK5bcoaMp+g@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
--cc=wenjing.liu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).