From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0EECC433DF for ; Wed, 24 Jun 2020 15:11:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B40B520656 for ; Wed, 24 Jun 2020 15:11:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SLLo7z94" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B40B520656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 52F7A6E102; Wed, 24 Jun 2020 15:11:59 +0000 (UTC) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0026A6E0F9; Wed, 24 Jun 2020 15:11:57 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id b6so2629557wrs.11; Wed, 24 Jun 2020 08:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ujwQciPl+L7lbdcyijKwCUqH7IK4/9USSSXUk6qmZOg=; b=SLLo7z94ccgwtDRo0DFIuN0STQWBcNUVZRVpDAX0TnbXHV/3AfY7PhJ3vY6yeCIH/p J/bRTe2lxeuS/kMB3cPIpFqxkvT0V9JUW7F1Ogi7YXj5mrC0SW4YKpNJGfXyMdgUTSBN SL7zioevlWWqq2F5+Iyq0KGMeVPqSp2qDGZpkKCoQzpDrArtAR+pd1Fg3z7EVwTM3afV rv5/iz2fwdHuzU1R8q0Hq0Bm1wz3GL/3HDF1q9XuOipEvbPrfp6UC8cg3iTIEEsBxCq0 sJN8yqiKVu+Zr9WIQvF4U2zzpiW7BoCgHCEFi3VDNhDmtRVpsaAFiutq3h55vS7ysc2w jVRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ujwQciPl+L7lbdcyijKwCUqH7IK4/9USSSXUk6qmZOg=; b=LSnyPfWXTd7usnL2jgUjYa2vraWxULgD0ZVyTmxAEkpGUwvaUqIEnSmq1uB8Pjxvbw f2NBpLz0MIbTRs2x8Be+u7UUBwuYRNwTkgl3LOEhWeBXMJiwquQpCbVcdCsIleoFXSAw qYCqLoKTbZfKMtBkWDXdcH8RSOAq4IuQ4oQkrQ7Hpl76MS5xMps3ulyfM+31g48Bz7yw Y4k89q/Q7vAeKSqIwOMb32Ho3WbTspXAHdX5mrsUu7F2f1psFUHf0Rvne4A25eXPs+bY 7qKYwsWeXwCcxmqJUeffVQi8s/5cZ2rIVYrEDRCa11LVIhY9ieyeIndLkub4Unu46qdV 94cw== X-Gm-Message-State: AOAM530nkseW5IawdpZfKSMHejVmvyYV5AL/u7e4uYTQWQ63kgIR8PRv jd9knNcgPFAo5Wp/Pt5SiTbccnTgTEIpnI1z4GY= X-Google-Smtp-Source: ABdhPJxcZ8Rrz4WTVA4JzfkWUwnDA9iyEW5D2N5Bj7502ovzHh8Sp8ZDl5fWVo+v3zOctaqg18jwU0autp6y1oTfP34= X-Received: by 2002:a5d:5549:: with SMTP id g9mr28913930wrw.419.1593011516671; Wed, 24 Jun 2020 08:11:56 -0700 (PDT) MIME-Version: 1.0 References: <20200624141423.6307-1-colin.king@canonical.com> In-Reply-To: From: Alex Deucher Date: Wed, 24 Jun 2020 11:11:45 -0400 Message-ID: Subject: Re: [PATCH][next] drm: amdgpu: fix premature goto because of missing braces To: Nirmoy X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel-janitors@vger.kernel.org, LKML , amd-gfx list , Sonny Jiang , Nirmoy Das , Maling list - DRI developers , Daniel Vetter , Alex Deucher , Colin King , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Applied. Thanks! Alex On Wed, Jun 24, 2020 at 10:32 AM Nirmoy wrote: > > Acked-by: Nirmoy Das > > > Thanks, > > Nirmoy > > On 6/24/20 4:14 PM, Colin King wrote: > > From: Colin Ian King > > > > Currently the goto statement is skipping over a lot of setup code > > because it is outside of an if-block and should be inside it. Fix > > this by adding missing if statement braces. > > > > Addresses-Coverity: ("Structurally dead code") > > Fixes: fd151ca5396d ("drm amdgpu: SI UVD v3_1") > > Signed-off-by: Colin Ian King > > --- > > drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c b/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c > > index 599719e89c31..7cf4b11a65c5 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c > > +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c > > @@ -642,9 +642,10 @@ static int uvd_v3_1_hw_init(void *handle) > > uvd_v3_1_start(adev); > > > > r = amdgpu_ring_test_helper(ring); > > - if (r) > > + if (r) { > > DRM_ERROR("amdgpu: UVD ring test fail (%d).\n", r); > > - goto done; > > + goto done; > > + } > > > > r = amdgpu_ring_alloc(ring, 10); > > if (r) { > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx