From: Alex Deucher <alexdeucher@gmail.com>
To: Simon Ser <contact@emersion.fr>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/display: drop cursor position check in atomic test
Date: Wed, 27 May 2020 17:04:55 -0400 [thread overview]
Message-ID: <CADnq5_PP_5vzhZ1XOeci=HtDq_N7vZpzKyEU6UsswZaGTBPaYg@mail.gmail.com> (raw)
In-Reply-To: <HB1_5z8Vnk8KvqVJezbdCJ0uUkI29R_Q7ksMByqCNQ3DG9HWd_iJP6b0WL1jIIJLBPdN25D8iC4BN-Jbf8NbKSL_Ep6IKVn3DaHpe_h5Ljg=@emersion.fr>
Applied. Thanks!
Alex
On Sat, May 23, 2020 at 7:53 AM Simon Ser <contact@emersion.fr> wrote:
>
> get_cursor_position already handles the case where the cursor has
> negative off-screen coordinates by not setting
> dc_cursor_position.enabled.
>
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Fixes: 626bf90fe03f ("drm/amd/display: add basic atomic check for cursor plane")
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 28e651b173ab..7fc15b82fe48 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -7880,13 +7880,6 @@ static int dm_update_plane_state(struct dc *dc,
> return -EINVAL;
> }
>
> - if (new_plane_state->crtc_x <= -new_acrtc->max_cursor_width ||
> - new_plane_state->crtc_y <= -new_acrtc->max_cursor_height) {
> - DRM_DEBUG_ATOMIC("Bad cursor position %d, %d\n",
> - new_plane_state->crtc_x, new_plane_state->crtc_y);
> - return -EINVAL;
> - }
> -
> return 0;
> }
>
> --
> 2.26.2
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-05-27 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 11:53 [PATCH] drm/amd/display: drop cursor position check in atomic test Simon Ser
2020-05-27 21:04 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_PP_5vzhZ1XOeci=HtDq_N7vZpzKyEU6UsswZaGTBPaYg@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=contact@emersion.fr \
--cc=nicholas.kazlauskas@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).