From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47977C43457 for ; Mon, 19 Oct 2020 12:40:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C05C421D81 for ; Mon, 19 Oct 2020 12:40:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZuKx3psk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C05C421D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B5636E964; Mon, 19 Oct 2020 12:40:49 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 84B106E964; Mon, 19 Oct 2020 12:40:48 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id d3so12667812wma.4; Mon, 19 Oct 2020 05:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KD+BMUqlL8wKcvAQHjeqQa4AlxPbqLKdwN0aw33PDWE=; b=ZuKx3pskOFIhNVzrkDHvjM49ZIGxQ76XGRnQWJmbTBXZfYiX1LDzdRcdCPFKE1++f+ Sp96erK2VvPAg7tm4VHmdIP8kxJzZDhU+93j2iB1u2YDLpphjMnYgx6aNIdRkM3/8WoB svK9c2enlSaP81dcmJbtt7R3ZHXvu+Niu9Hma6oA29KSaFmhCIvs90tbN+WKwWbFAxmu wSTQzpujp6HuB5qp9tcfeG4xME3lLSa5TQWS/fz0YEs8SNBzE5V0FVWavzbiZLAEBMqF 81lJI1Gv/fA5FotsOS4j+3XMTIf4dXzfWILCwn89429kUNNYEEOCUzUK3sBOjvxhzksZ xkFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KD+BMUqlL8wKcvAQHjeqQa4AlxPbqLKdwN0aw33PDWE=; b=MsAJUL44BEXhH2h5ZSCmzYSM52Z7yVv2j/0n+IDAwAi+0IGVS6XT32A2l3M8azAceC 6GFk61dSFmc93TUhxIyA62Qxxp3nfLiLV6sa6yYOyII13M3ZkmJkNy8xC1Xl1Sx1VCDf 0u0/QuVS5WbQAjBoVfomAYeFFepVngZYm05UQKbchwf4FY5uAGAyboAh3ajvqmOXPazI 0PD6pPRXUslqds+gPMelQejXs9gDOuvAuabPSt0FcpdE396dZB6KCZ4KpwgLZMXh/YHX ooqqhy1ljk/z62okeyTrc/8RAy1HEnlx7Rte4WZhNMgH3A03C4ezUaNvYOJ9WOsyslk3 Vr5g== X-Gm-Message-State: AOAM532hFMVXoalC4RVOgQAX9PLhFRGXmcj4LbbdmL3h+D0LlFhbAL9f JLsgGBQ4pujTqyCM1jEeC1cwcq+F/sFtntXzEr2th7BZ X-Google-Smtp-Source: ABdhPJz8b4JCtuKc4oS7EITtuMlo5x0b6+dBRcrE7oyGxznW6BSmG1BTTBjwCyZGUZlhONL0O17463CJLalJFiDsqns= X-Received: by 2002:a1c:4b05:: with SMTP id y5mr2614165wma.56.1603111247144; Mon, 19 Oct 2020 05:40:47 -0700 (PDT) MIME-Version: 1.0 References: <20201018191807.4052726-1-sashal@kernel.org> <20201018191807.4052726-90-sashal@kernel.org> In-Reply-To: <20201018191807.4052726-90-sashal@kernel.org> From: Alex Deucher Date: Mon, 19 Oct 2020 08:40:36 -0400 Message-ID: Subject: Re: [PATCH AUTOSEL 5.9 090/111] drm/amd/display: Fix a list corruption To: Sasha Levin X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xinhui pan , LKML , amd-gfx list , Maling list - DRI developers , Feifei Xu , Alex Deucher , "for 3.8" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Sun, Oct 18, 2020 at 3:19 PM Sasha Levin wrote: > > From: xinhui pan > > [ Upstream commit 1545fbf97eafc1dbdc2923e58b4186b16a834784 ] > > Remove the private obj from the internal list before we free aconnector. > > [ 56.925828] BUG: unable to handle page fault for address: ffff8f84a870a560 > [ 56.933272] #PF: supervisor read access in kernel mode > [ 56.938801] #PF: error_code(0x0000) - not-present page > [ 56.944376] PGD 18e605067 P4D 18e605067 PUD 86a614067 PMD 86a4d0067 PTE 800ffff8578f5060 > [ 56.953260] Oops: 0000 [#1] SMP DEBUG_PAGEALLOC NOPTI > [ 56.958815] CPU: 6 PID: 1407 Comm: bash Tainted: G O 5.9.0-rc2+ #46 > [ 56.967092] Hardware name: System manufacturer System Product Name/PRIME Z390-A, BIOS 1401 11/26/2019 > [ 56.977162] RIP: 0010:__list_del_entry_valid+0x31/0xa0 > [ 56.982768] Code: 00 ad de 55 48 8b 17 4c 8b 47 08 48 89 e5 48 39 c2 74 27 48 b8 22 01 00 00 00 00 ad de 49 39 c0 74 2d 49 8b 30 48 39 fe 75 3d <48> 8b 52 08 48 39 f2 75 4c b8 01 00 00 00 5d c3 48 89 7 > [ 57.003327] RSP: 0018:ffffb40c81687c90 EFLAGS: 00010246 > [ 57.009048] RAX: dead000000000122 RBX: ffff8f84ea41f4f0 RCX: 0000000000000006 > [ 57.016871] RDX: ffff8f84a870a558 RSI: ffff8f84ea41f4f0 RDI: ffff8f84ea41f4f0 > [ 57.024672] RBP: ffffb40c81687c90 R08: ffff8f84ea400998 R09: 0000000000000001 > [ 57.032490] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000006 > [ 57.040287] R13: ffff8f84ea422a90 R14: ffff8f84b4129a20 R15: fffffffffffffff2 > [ 57.048105] FS: 00007f550d885740(0000) GS:ffff8f8509600000(0000) knlGS:0000000000000000 > [ 57.056979] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 57.063260] CR2: ffff8f84a870a560 CR3: 00000007e5144001 CR4: 00000000003706e0 > [ 57.071053] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 57.078849] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 57.086684] Call Trace: > [ 57.089381] drm_atomic_private_obj_fini+0x29/0x82 [drm] > [ 57.095247] amdgpu_dm_fini+0x83/0x170 [amdgpu] > [ 57.100264] dm_hw_fini+0x23/0x30 [amdgpu] > [ 57.104814] amdgpu_device_fini+0x1df/0x4fe [amdgpu] > [ 57.110271] amdgpu_driver_unload_kms+0x43/0x70 [amdgpu] > [ 57.116136] amdgpu_pci_remove+0x3b/0x60 [amdgpu] > [ 57.121291] pci_device_remove+0x3e/0xb0 > [ 57.125583] device_release_driver_internal+0xff/0x1d0 > [ 57.131223] device_release_driver+0x12/0x20 > [ 57.135903] pci_stop_bus_device+0x70/0xa0 > [ 57.140401] pci_stop_and_remove_bus_device_locked+0x1b/0x30 > [ 57.146571] remove_store+0x7b/0x90 > [ 57.150429] dev_attr_store+0x17/0x30 > [ 57.154441] sysfs_kf_write+0x4b/0x60 > [ 57.158479] kernfs_fop_write+0xe8/0x1d0 > [ 57.162788] vfs_write+0xf5/0x230 > [ 57.166426] ksys_write+0x70/0xf0 > [ 57.170087] __x64_sys_write+0x1a/0x20 > [ 57.174219] do_syscall_64+0x38/0x90 > [ 57.178145] entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > Signed-off-by: xinhui pan > Acked-by: Feifei Xu > Signed-off-by: Alex Deucher > Signed-off-by: Sasha Levin This ended up getting reverted. Please drop this one. Alex > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index a717a4904268e..57ad6450e20b2 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -4882,6 +4882,7 @@ static void amdgpu_dm_connector_destroy(struct drm_connector *connector) > struct amdgpu_device *adev = connector->dev->dev_private; > struct amdgpu_display_manager *dm = &adev->dm; > > + drm_atomic_private_obj_fini(&aconnector->mst_mgr.base); > #if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) ||\ > defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE) > > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx