AMD-GFX Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates"
@ 2020-06-29 15:36 Alex Deucher
  2020-06-29 15:40 ` Kazlauskas, Nicholas
  0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2020-06-29 15:36 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alex Deucher

Seems to cause stability issues for some users.

This reverts commit a24eaa5c51255b344d5a321f1eeb3205f2775498.

Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1191
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 67402d75e67e..94230bb3195d 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -2607,12 +2607,6 @@ void dc_commit_updates_for_stream(struct dc *dc,
 
 	copy_stream_update_to_stream(dc, context, stream, stream_update);
 
-	if (!dc->res_pool->funcs->validate_bandwidth(dc, context, false)) {
-		DC_ERROR("Mode validation failed for stream update!\n");
-		dc_release_state(context);
-		return;
-	}
-
 	commit_planes_for_stream(
 				dc,
 				srf_updates,
-- 
2.25.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates"
  2020-06-29 15:36 [PATCH] Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates" Alex Deucher
@ 2020-06-29 15:40 ` Kazlauskas, Nicholas
  2020-06-29 16:13   ` Kazlauskas, Nicholas
  0 siblings, 1 reply; 4+ messages in thread
From: Kazlauskas, Nicholas @ 2020-06-29 15:40 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx; +Cc: Alex Deucher

On 2020-06-29 11:36 a.m., Alex Deucher wrote:
> Seems to cause stability issues for some users.
> 
> This reverts commit a24eaa5c51255b344d5a321f1eeb3205f2775498.
> 
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1191
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

I don't see the error in their log. How do we know this commit is 
actually causing the issue?

I don't really want to revert this commit because it means that we 
missed rejecting a commit during atomic check, meaning we're either 
going to get underflow on the screen or a pipe hang.

Regards,
Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 67402d75e67e..94230bb3195d 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -2607,12 +2607,6 @@ void dc_commit_updates_for_stream(struct dc *dc,
>   
>   	copy_stream_update_to_stream(dc, context, stream, stream_update);
>   
> -	if (!dc->res_pool->funcs->validate_bandwidth(dc, context, false)) {
> -		DC_ERROR("Mode validation failed for stream update!\n");
> -		dc_release_state(context);
> -		return;
> -	}
> -
>   	commit_planes_for_stream(
>   				dc,
>   				srf_updates,
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates"
  2020-06-29 15:40 ` Kazlauskas, Nicholas
@ 2020-06-29 16:13   ` Kazlauskas, Nicholas
  2020-06-29 16:20     ` Alex Deucher
  0 siblings, 1 reply; 4+ messages in thread
From: Kazlauskas, Nicholas @ 2020-06-29 16:13 UTC (permalink / raw)
  To: Alex Deucher, amd-gfx; +Cc: Alex Deucher

On 2020-06-29 11:40 a.m., Kazlauskas, Nicholas wrote:
> On 2020-06-29 11:36 a.m., Alex Deucher wrote:
>> Seems to cause stability issues for some users.
>>
>> This reverts commit a24eaa5c51255b344d5a321f1eeb3205f2775498.
>>
>> Bug: 
>> https://gitlab.freedesktop.org/drm/amd/-/issues/1191 
>>
>> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> 
> I don't see the error in their log. How do we know this commit is 
> actually causing the issue?
> 
> I don't really want to revert this commit because it means that we 
> missed rejecting a commit during atomic check, meaning we're either 
> going to get underflow on the screen or a pipe hang.
> 
> Regards,
> Nicholas Kazlauskas

Actually, we only want to be doing this on full updates - it's not a 
very fast operation. Not sure if this is causing their stability issue 
though.

Regards,
Nicholas Kazlauskas

> 
>> ---
>>   drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ------
>>   1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c 
>> b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> index 67402d75e67e..94230bb3195d 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> @@ -2607,12 +2607,6 @@ void dc_commit_updates_for_stream(struct dc *dc,
>>       copy_stream_update_to_stream(dc, context, stream, stream_update);
>> -    if (!dc->res_pool->funcs->validate_bandwidth(dc, context, false)) {
>> -        DC_ERROR("Mode validation failed for stream update!\n");
>> -        dc_release_state(context);
>> -        return;
>> -    }
>> -
>>       commit_planes_for_stream(
>>                   dc,
>>                   srf_updates,
>>
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx 
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates"
  2020-06-29 16:13   ` Kazlauskas, Nicholas
@ 2020-06-29 16:20     ` Alex Deucher
  0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2020-06-29 16:20 UTC (permalink / raw)
  To: Kazlauskas, Nicholas; +Cc: Alex Deucher, amd-gfx list

On Mon, Jun 29, 2020 at 12:13 PM Kazlauskas, Nicholas
<nicholas.kazlauskas@amd.com> wrote:
>
> On 2020-06-29 11:40 a.m., Kazlauskas, Nicholas wrote:
> > On 2020-06-29 11:36 a.m., Alex Deucher wrote:
> >> Seems to cause stability issues for some users.
> >>
> >> This reverts commit a24eaa5c51255b344d5a321f1eeb3205f2775498.
> >>
> >> Bug:
> >> https://gitlab.freedesktop.org/drm/amd/-/issues/1191
> >>
> >> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> >
> > I don't see the error in their log. How do we know this commit is
> > actually causing the issue?
> >
> > I don't really want to revert this commit because it means that we
> > missed rejecting a commit during atomic check, meaning we're either
> > going to get underflow on the screen or a pipe hang.
> >
> > Regards,
> > Nicholas Kazlauskas
>
> Actually, we only want to be doing this on full updates - it's not a
> very fast operation. Not sure if this is causing their stability issue
> though.

Maybe.  Several people have reported reverting it fixes hangs.  Maybe
something in the validation code hangs?  Maybe some sort of software
deadlock?

Alex


>
> Regards,
> Nicholas Kazlauskas
>
> >
> >> ---
> >>   drivers/gpu/drm/amd/display/dc/core/dc.c | 6 ------
> >>   1 file changed, 6 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> index 67402d75e67e..94230bb3195d 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> @@ -2607,12 +2607,6 @@ void dc_commit_updates_for_stream(struct dc *dc,
> >>       copy_stream_update_to_stream(dc, context, stream, stream_update);
> >> -    if (!dc->res_pool->funcs->validate_bandwidth(dc, context, false)) {
> >> -        DC_ERROR("Mode validation failed for stream update!\n");
> >> -        dc_release_state(context);
> >> -        return;
> >> -    }
> >> -
> >>       commit_planes_for_stream(
> >>                   dc,
> >>                   srf_updates,
> >>
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> >
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 15:36 [PATCH] Revert "drm/amd/display: Revalidate bandwidth before commiting DC updates" Alex Deucher
2020-06-29 15:40 ` Kazlauskas, Nicholas
2020-06-29 16:13   ` Kazlauskas, Nicholas
2020-06-29 16:20     ` Alex Deucher

AMD-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/amd-gfx/0 amd-gfx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 amd-gfx amd-gfx/ https://lore.kernel.org/amd-gfx \
		amd-gfx@lists.freedesktop.org
	public-inbox-index amd-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.amd-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git