Re: amd/display: allow non-linear multi-planar formats

From: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
To: Simon Ser <contact@emersion.fr>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Harry Wentland <hwentlan@amd.com>,
	Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
	amd-gfx mailing list <amd-gfx@lists.freedesktop.org>
Subject: Re: amd/display: allow non-linear multi-planar formats
Date: Mon, 12 Apr 2021 00:20:41 +0200	[thread overview]
Message-ID: <CAP+8YyHeiB5OyTgQkTAuFv1MhP7ZpeLqmZe9oHBj5f0ez6Pa3Q@mail.gmail.com> (raw)
In-Reply-To: <YsPGje8t2-fY1GTI6waUph1jQzm5WtagjUUi0lFy3Q7_I20gG8Ln1bIBqi00nj5RMzdkFhrftPbUrpqwrV2bSvEJbDD8IG9dPHAaZNTLQM8=@emersion.fr>

[-- Attachment #1.1: Type: text/plain, Size: 2113 bytes --]

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>

On Fri, Apr 9, 2021 at 3:19 PM Simon Ser <contact@emersion.fr> wrote:

> Hi,
>
> Can you have a look at this patch?
>
> Thanks,
>
> Simon
>
> On Friday, March 26th, 2021 at 5:59 PM, Simon Ser <contact@emersion.fr>
> wrote:
>
> > Accept non-linear buffers which use a multi-planar format, as long
> > as they don't use DCC.
> >
> > Tested on GFX9 with NV12.
> >
> > Signed-off-by: Simon Ser <contact@emersion.fr>
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: Harry Wentland <hwentlan@amd.com>
> > Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> > Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 11 ++++-------
> >  1 file changed, 4 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 36ee52104007..66e3ecf123d1 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -4216,13 +4216,6 @@ static bool dm_plane_format_mod_supported(struct
> drm_plane *plane,
> >       if (modifier == DRM_FORMAT_MOD_LINEAR)
> >               return true;
> >
> > -     /*
> > -      * The arbitrary tiling support for multiplane formats has not
> been hooked
> > -      * up.
> > -      */
> > -     if (info->num_planes > 1)
> > -             return false;
> > -
> >       /*
> >        * For D swizzle the canonical modifier depends on the bpp, so
> check
> >        * it here.
> > @@ -4241,6 +4234,10 @@ static bool dm_plane_format_mod_supported(struct
> drm_plane *plane,
> >               /* Per radeonsi comments 16/64 bpp are more complicated. */
> >               if (info->cpp[0] != 4)
> >                       return false;
> > +             /* We support multi-planar formats, but not when combined
> with
> > +              * additional DCC metadata planes. */
> > +             if (info->num_planes > 1)
> > +                     return false;
> >       }
> >
> >       return true;
>

[-- Attachment #1.2: Type: text/html, Size: 3252 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx