From: "Liu, Zhan" <Zhan.Liu@amd.com>
To: "Guo Zhengkui" <guozhengkui@vivo.com>,
"Wentland, Harry" <Harry.Wentland@amd.com>,
"Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Liu, Charlene" <Charlene.Liu@amd.com>,
"Lei, Jun" <Jun.Lei@amd.com>,
"José Expósito" <jose.exposito89@gmail.com>,
"open list:AMD DISPLAY CORE" <amd-gfx@lists.freedesktop.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list" <linux-kernel@vger.kernel.org>
Cc: "zhengkui_guo@outlook.com" <zhengkui_guo@outlook.com>
Subject: RE: [PATCH] drm/amd/display: fix if == else warning
Date: Sun, 24 Apr 2022 20:15:15 +0000 [thread overview]
Message-ID: <DM4PR12MB52143C2204F820E49D377A519EF99@DM4PR12MB5214.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220424090640.1865-1-guozhengkui@vivo.com>
[AMD Official Use Only - General]
> -----Original Message-----
> From: Guo Zhengkui <guozhengkui@vivo.com>
> Sent: 2022/April/24, Sunday 5:06 AM
> To: Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo)
> <Sunpeng.Li@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>;
> Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; David Airlie
> <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Liu, Charlene
> <Charlene.Liu@amd.com>; Lei, Jun <Jun.Lei@amd.com>; Guo Zhengkui
> <guozhengkui@vivo.com>; Liu, Zhan <Zhan.Liu@amd.com>; José Expósito
> <jose.exposito89@gmail.com>; open list:AMD DISPLAY CORE <amd-
> gfx@lists.freedesktop.org>; open list:DRM DRIVERS <dri-
> devel@lists.freedesktop.org>; open list <linux-kernel@vger.kernel.org>
> Cc: zhengkui_guo@outlook.com
> Subject: [PATCH] drm/amd/display: fix if == else warning
>
> Fix the following coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c:98:8-10:
> WARNING: possible condition with no effect (if == else)
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Thanks a lot for fixing this warning.
Reviewed-by: Zhan Liu <zhan.liu@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> index fe22530242d2..05b3fba9ccce 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> @@ -95,8 +95,6 @@ static void gpu_addr_to_uma(struct dce_hwseq *hwseq,
> } else if (hwseq->fb_offset.quad_part <= addr->quad_part &&
> addr->quad_part <= hwseq->uma_top.quad_part) {
> is_in_uma = true;
> - } else if (addr->quad_part == 0) {
> - is_in_uma = false;
> } else {
> is_in_uma = false;
> }
> --
> 2.20.1
next prev parent reply other threads:[~2022-04-24 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 9:06 [PATCH] drm/amd/display: fix if == else warning Guo Zhengkui
2022-04-24 20:15 ` Liu, Zhan [this message]
2022-04-25 21:55 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB52143C2204F820E49D377A519EF99@DM4PR12MB5214.namprd12.prod.outlook.com \
--to=zhan.liu@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Charlene.Liu@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Sunpeng.Li@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=guozhengkui@vivo.com \
--cc=jose.exposito89@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengkui_guo@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).