From: "Russell, Kent" <Kent.Russell@amd.com>
To: "Kuehling, Felix" <Felix.Kuehling@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH 1/1] drm/amdkfd: Remove redundand kfd2kgd interface lookup
Date: Thu, 2 Jul 2020 11:45:27 +0000 [thread overview]
Message-ID: <DM6PR12MB372186B4CA42970CF2CAF551856D0@DM6PR12MB3721.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20200701023330.23118-1-Felix.Kuehling@amd.com>
[AMD Public Use]
Reviewed-by: Kent Russell <kent.russell@amd.com>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Felix
> Kuehling
> Sent: Tuesday, June 30, 2020 10:34 PM
> To: amd-gfx@lists.freedesktop.org
> Subject: [PATCH 1/1] drm/amdkfd: Remove redundand kfd2kgd interface
> lookup
>
> kfd_pasid.c isn't using the kfd2kgd interface any more. Remove redundant
> code trying to look up a device for finding that interface.
>
> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_pasid.c | 31 +++++++-------------------
> 1 file changed, 8 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> index 33b08ff00b50..2a07c4f2cd0d 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> @@ -25,7 +25,7 @@
> #include "amdgpu_ids.h"
>
> static unsigned int pasid_bits = 16;
> -static const struct kfd2kgd_calls *kfd2kgd;
> +static bool pasids_allocated; /* = false */
>
> bool kfd_set_pasid_limit(unsigned int new_limit) { @@ -33,7 +33,7 @@ bool
> kfd_set_pasid_limit(unsigned int new_limit)
> return false;
>
> if (new_limit < (1U << pasid_bits)) {
> - if (kfd2kgd)
> + if (pasids_allocated)
> /* We've already allocated user PASIDs, too late to
> * change the limit
> */
> @@ -53,32 +53,17 @@ unsigned int kfd_get_pasid_limit(void)
>
> unsigned int kfd_pasid_alloc(void)
> {
> - int r;
> + int r = amdgpu_pasid_alloc(pasid_bits);
>
> - /* Find the first best KFD device for calling KGD */
> - if (!kfd2kgd) {
> - struct kfd_dev *dev = NULL;
> - unsigned int i = 0;
> -
> - while ((kfd_topology_enum_kfd_devices(i, &dev)) == 0) {
> - if (dev && dev->kfd2kgd) {
> - kfd2kgd = dev->kfd2kgd;
> - break;
> - }
> - i++;
> - }
> -
> - if (!kfd2kgd)
> - return false;
> + if (r > 0) {
> + pasids_allocated = true;
> + return r;
> }
>
> - r = amdgpu_pasid_alloc(pasid_bits);
> -
> - return r > 0 ? r : 0;
> + return 0;
> }
>
> void kfd_pasid_free(unsigned int pasid) {
> - if (kfd2kgd)
> - amdgpu_pasid_free(pasid);
> + amdgpu_pasid_free(pasid);
> }
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fr
> eedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&data=02%7C01%7Ckent.russell%40amd.com%7C6064ff0aff58480be0
> ae08d81d673758%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
> 7291676460049430&sdata=pELFzqkP3isRtcEgtYkaaTuvGB4Xtf%2BrOp615
> PARX4g%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-07-02 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 2:33 [PATCH 1/1] drm/amdkfd: Remove redundand kfd2kgd interface lookup Felix Kuehling
2020-07-02 11:45 ` Russell, Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB372186B4CA42970CF2CAF551856D0@DM6PR12MB3721.namprd12.prod.outlook.com \
--to=kent.russell@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).