AMD-GFX Archive on lore.kernel.org
 help / color / Atom feed
From: "Russell, Kent" <Kent.Russell@amd.com>
To: "Russell, Kent" <Kent.Russell@amd.com>,
	"Greathouse, Joseph" <Joseph.Greathouse@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Greathouse, Joseph" <Joseph.Greathouse@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Add Arcturus GWS support and fix VG10
Date: Tue, 30 Jun 2020 13:30:55 +0000
Message-ID: <DM6PR12MB37218713D46441B0E396AD5D856F0@DM6PR12MB3721.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM6PR12MB3721BBE5C48881F357B90E8B856F0@DM6PR12MB3721.namprd12.prod.outlook.com>

[AMD Public Use]

Thanks for answering my question offline. Patch is
Reviewed-by: Kent Russell <kent.russell@amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Russell,
> Kent
> Sent: Tuesday, June 30, 2020 8:00 AM
> To: Greathouse, Joseph <Joseph.Greathouse@amd.com>; amd-
> gfx@lists.freedesktop.org
> Cc: Greathouse, Joseph <Joseph.Greathouse@amd.com>
> Subject: RE: [PATCH] drm/amdkfd: Add Arcturus GWS support and fix VG10
> 
> [AMD Public Use]
> 
> One inquiry inline
> 
> > -----Original Message-----
> > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> > Joseph Greathouse
> > Sent: Monday, June 29, 2020 9:55 PM
> > To: amd-gfx@lists.freedesktop.org
> > Cc: Greathouse, Joseph <Joseph.Greathouse@amd.com>
> > Subject: [PATCH] drm/amdkfd: Add Arcturus GWS support and fix VG10
> >
> > Add support for GWS in Arcturus, which needs MEC2 firmware #48 or above.
> > Fix the MEC2 version check for Vega 10 GWS support, since Vega 10
> > firmware adds 0x8000 to the actual firmware revision. We were
> > previously declaring support where it did not exist.
> >
> > Signed-off-by: Joseph Greathouse <Joseph.Greathouse@amd.com>
> > Change-Id: I9b44dfe59bdd8a38a0342e5155cdb071cf646cc5
> > ---
> >  drivers/gpu/drm/amd/amdkfd/kfd_device.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > index 80393e0583bb..50886de3ba0a 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > @@ -602,9 +602,13 @@ static int kfd_gws_init(struct kfd_dev *kfd)
> >  		return 0;
> >
> >  	if (hws_gws_support
> > -		|| (kfd->device_info->asic_family >= CHIP_VEGA10
> > +		|| (kfd->device_info->asic_family == CHIP_VEGA10
> > +			&& kfd->mec2_fw_version >= 0x81b3)
> > +		|| (kfd->device_info->asic_family >= CHIP_VEGA12
> >  			&& kfd->device_info->asic_family <= CHIP_RAVEN
> > -			&& kfd->mec2_fw_version >= 0x1b3))
> > +			&& kfd->mec2_fw_version >= 0x1b3)
> [KR] Is it 0x1b3 for both VG12 and RV? I wasn't sure if it was 0x1b4 for VG12, or
> did they just update the FW again and I missed the original?
> > +		|| (kfd->device_info->asic_family == CHIP_ARCTURUS
> > +			&& kfd->mec2_fw_version >= 0x30))
> >  		ret = amdgpu_amdkfd_alloc_gws(kfd->kgd,
> >  				amdgpu_amdkfd_get_num_gws(kfd->kgd),
> > &kfd->gws);
> >
> > --
> > 2.20.1
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> > s.fr
> > eedesktop.org%2Fmailman%2Flistinfo%2Famd-
> >
> gfx&amp;data=02%7C01%7Ckent.russell%40amd.com%7C763e1f08fe29488bf1
> >
> 6c08d81c98b2c5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
> >
> 7290790080559728&amp;sdata=22Hd8tIxsjF%2BLXiBKQgSt6EbOTIHqifVSYMb
> > W1AWxV4%3D&amp;reserved=0
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fr
> eedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&amp;data=02%7C01%7Ckent.russell%40amd.com%7Ca4e3323d9bcc417be
> 40808d81ced2013%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
> 37291152507197101&amp;sdata=zrfmEq3xf5Y2MoFGnBK8EP5eYqZmWXPm3y
> KlrEtcMdU%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30  1:55 Joseph Greathouse
2020-06-30 11:59 ` Russell, Kent
2020-06-30 13:30   ` Russell, Kent [this message]
2020-06-30 13:34   ` Greathouse, Joseph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB37218713D46441B0E396AD5D856F0@DM6PR12MB3721.namprd12.prod.outlook.com \
    --to=kent.russell@amd.com \
    --cc=Joseph.Greathouse@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

AMD-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/amd-gfx/0 amd-gfx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 amd-gfx amd-gfx/ https://lore.kernel.org/amd-gfx \
		amd-gfx@lists.freedesktop.org
	public-inbox-index amd-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.amd-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git