[PATCH] drm/amd/display: drop cursor position check in atomic test

[PATCH] drm/amd/display: drop cursor position check in atomic test

[Simon Ser]

get_cursor_position already handles the case where the cursor has
negative off-screen coordinates by not setting
dc_cursor_position.enabled.

Signed-off-by: Simon Ser <contact@emersion.fr>
Fixes: 626bf90fe03f ("drm/amd/display: add basic atomic check for cursor plane")
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 28e651b173ab..7fc15b82fe48 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -7880,13 +7880,6 @@ static int dm_update_plane_state(struct dc *dc,
 			return -EINVAL;
 		}
 
-		if (new_plane_state->crtc_x <= -new_acrtc->max_cursor_width ||
-			new_plane_state->crtc_y <= -new_acrtc->max_cursor_height) {
-			DRM_DEBUG_ATOMIC("Bad cursor position %d, %d\n",
-							 new_plane_state->crtc_x, new_plane_state->crtc_y);
-			return -EINVAL;
-		}
-
 		return 0;
 	}
 
-- 
2.26.2


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/display: drop cursor position check in atomic test

[Alex Deucher]

Applied.  Thanks!

Alex

On Sat, May 23, 2020 at 7:53 AM Simon Ser <contact@emersion.fr> wrote:
>
> get_cursor_position already handles the case where the cursor has
> negative off-screen coordinates by not setting
> dc_cursor_position.enabled.
>
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Fixes: 626bf90fe03f ("drm/amd/display: add basic atomic check for cursor plane")
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 28e651b173ab..7fc15b82fe48 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -7880,13 +7880,6 @@ static int dm_update_plane_state(struct dc *dc,
>                         return -EINVAL;
>                 }
>
> -               if (new_plane_state->crtc_x <= -new_acrtc->max_cursor_width ||
> -                       new_plane_state->crtc_y <= -new_acrtc->max_cursor_height) {
> -                       DRM_DEBUG_ATOMIC("Bad cursor position %d, %d\n",
> -                                                        new_plane_state->crtc_x, new_plane_state->crtc_y);
> -                       return -EINVAL;
> -               }
> -
>                 return 0;
>         }
>
> --
> 2.26.2
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx