AMD-GFX Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/1] drm/amd/powerplay: Fix DCEFCLK related compilation error for arcturus
@ 2020-06-23 15:59 Nirmoy Das
  2020-06-23 16:04 ` Nirmoy
  0 siblings, 1 reply; 3+ messages in thread
From: Nirmoy Das @ 2020-06-23 15:59 UTC (permalink / raw)
  To: amd-gfx; +Cc: Alexander.Deucher, nirmoy.das

arcturus doesn't support DCEFCLK

Fixes: c67c791cd87d (drm/amd/powerplay: return current DCEFCLK on sysfs read)

Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
index daeae14fd380..d93f8a43a96f 100644
--- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
@@ -962,9 +962,6 @@ static int arcturus_get_smu_metrics_data(struct smu_context *smu,
 	case METRICS_CURR_FCLK:
 		*value = metrics->CurrClock[PPCLK_FCLK];
 		break;
-	case METRICS_CURR_DCEFCLK:
-		*value = metrics->CurrClock[PPCLK_DCEFCLK];
-		break;
 	case METRICS_AVERAGE_GFXCLK:
 		*value = metrics->AverageGfxclkFrequency;
 		break;
-- 
2.27.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] drm/amd/powerplay: Fix DCEFCLK related compilation error for arcturus
  2020-06-23 15:59 [PATCH 1/1] drm/amd/powerplay: Fix DCEFCLK related compilation error for arcturus Nirmoy Das
@ 2020-06-23 16:04 ` Nirmoy
  2020-06-23 16:40   ` Deucher, Alexander
  0 siblings, 1 reply; 3+ messages in thread
From: Nirmoy @ 2020-06-23 16:04 UTC (permalink / raw)
  To: Nirmoy Das, amd-gfx; +Cc: Alexander.Deucher, nirmoy.das


On 6/23/20 5:59 PM, Nirmoy Das wrote:
> arcturus doesn't support DCEFCLK
>
> Fixes: c67c791cd87d (drm/amd/powerplay: return current DCEFCLK on sysfs read)


Hi Alex,


Can you please squash this with c67c791cd87d (drm/amd/powerplay: return 
current DCEFCLK on sysfs read)

I was bit too confident that arcturus changes would just work.


Regards,

Nirmoy


>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> ---
>   drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> index daeae14fd380..d93f8a43a96f 100644
> --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> @@ -962,9 +962,6 @@ static int arcturus_get_smu_metrics_data(struct smu_context *smu,
>   	case METRICS_CURR_FCLK:
>   		*value = metrics->CurrClock[PPCLK_FCLK];
>   		break;
> -	case METRICS_CURR_DCEFCLK:
> -		*value = metrics->CurrClock[PPCLK_DCEFCLK];
> -		break;
>   	case METRICS_AVERAGE_GFXCLK:
>   		*value = metrics->AverageGfxclkFrequency;
>   		break;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] drm/amd/powerplay: Fix DCEFCLK related compilation error for arcturus
  2020-06-23 16:04 ` Nirmoy
@ 2020-06-23 16:40   ` Deucher, Alexander
  0 siblings, 0 replies; 3+ messages in thread
From: Deucher, Alexander @ 2020-06-23 16:40 UTC (permalink / raw)
  To: Das, Nirmoy, Nirmoy Das, amd-gfx

[-- Attachment #1.1: Type: text/plain, Size: 1737 bytes --]

[AMD Public Use]

No problem.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: Das, Nirmoy <Nirmoy.Das@amd.com>
Sent: Tuesday, June 23, 2020 12:04 PM
To: Nirmoy Das <nirmoy.aiemd@gmail.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Das, Nirmoy <Nirmoy.Das@amd.com>
Subject: Re: [PATCH 1/1] drm/amd/powerplay: Fix DCEFCLK related compilation error for arcturus


On 6/23/20 5:59 PM, Nirmoy Das wrote:
> arcturus doesn't support DCEFCLK
>
> Fixes: c67c791cd87d (drm/amd/powerplay: return current DCEFCLK on sysfs read)


Hi Alex,


Can you please squash this with c67c791cd87d (drm/amd/powerplay: return
current DCEFCLK on sysfs read)

I was bit too confident that arcturus changes would just work.


Regards,

Nirmoy


>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> ---
>   drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> index daeae14fd380..d93f8a43a96f 100644
> --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> @@ -962,9 +962,6 @@ static int arcturus_get_smu_metrics_data(struct smu_context *smu,
>        case METRICS_CURR_FCLK:
>                *value = metrics->CurrClock[PPCLK_FCLK];
>                break;
> -     case METRICS_CURR_DCEFCLK:
> -             *value = metrics->CurrClock[PPCLK_DCEFCLK];
> -             break;
>        case METRICS_AVERAGE_GFXCLK:
>                *value = metrics->AverageGfxclkFrequency;
>                break;

[-- Attachment #1.2: Type: text/html, Size: 3622 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 15:59 [PATCH 1/1] drm/amd/powerplay: Fix DCEFCLK related compilation error for arcturus Nirmoy Das
2020-06-23 16:04 ` Nirmoy
2020-06-23 16:40   ` Deucher, Alexander

AMD-GFX Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/amd-gfx/0 amd-gfx/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 amd-gfx amd-gfx/ https://lore.kernel.org/amd-gfx \
		amd-gfx@lists.freedesktop.org
	public-inbox-index amd-gfx

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.freedesktop.lists.amd-gfx


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git