From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Jinzhou Su <Jinzhou.Su@amd.com>, amd-gfx@lists.freedesktop.org
Cc: ray.huang@amd.com
Subject: Re: [PATCH] drm/amdgpu: Add mem sync flag for SDMA IB test
Date: Tue, 20 Apr 2021 08:39:27 +0200 [thread overview]
Message-ID: <a5be6441-625f-3605-0ed7-c2cec03c9a18@gmail.com> (raw)
In-Reply-To: <20210420022340.365464-1-Jinzhou.Su@amd.com>
Am 20.04.21 um 04:23 schrieb Jinzhou Su:
> The buffer for SDMA IB test is allocated by sa bo
> which may be used by other purpose. Better to flush
> the cache before commit the IB.
Good point, but shouldn't we do this for a lot of other cases as well?
I think the only place where we should not set the flag is in the CS IOCTL.
Regards,
Christian.
>
> Signed-off-by: Jinzhou Su <Jinzhou.Su@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
> index b1ad9e52b234..da67f440b102 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
> @@ -1000,6 +1000,7 @@ static int sdma_v5_2_ring_test_ib(struct amdgpu_ring *ring, long timeout)
> ib.ptr[7] = SDMA_PKT_NOP_HEADER_OP(SDMA_OP_NOP);
> ib.length_dw = 8;
>
> + ib.flags = AMDGPU_IB_FLAG_EMIT_MEM_SYNC;
> r = amdgpu_ib_schedule(ring, 1, &ib, NULL, &f);
> if (r)
> goto err1;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-04-20 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 2:23 [PATCH] drm/amdgpu: Add mem sync flag for SDMA IB test Jinzhou Su
2021-04-20 6:39 ` Christian König [this message]
2021-04-20 6:55 ` Su, Jinzhou (Joe)
2021-04-20 7:39 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5be6441-625f-3605-0ed7-c2cec03c9a18@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Jinzhou.Su@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).