amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Roman Li <roman.li@amd.com>,
	amd-gfx@lists.freedesktop.org, linux-next@vger.kernel.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Chaitanya Dhere <chaitanya.dhere@amd.com>
Subject: Re: [PATCH 2/2] drm/amd/display: Fix stack size issue on DML2
Date: Sun, 5 Nov 2023 09:55:55 -0800	[thread overview]
Message-ID: <aa6344f8-abd4-4f9e-86cf-febecd6fd747@roeck-us.net> (raw)
In-Reply-To: <20231016142031.241912-3-Rodrigo.Siqueira@amd.com>

On Mon, Oct 16, 2023 at 08:19:18AM -0600, Rodrigo Siqueira wrote:
> This commit is the last part of the fix that reduces the stack size in
> the DML2 code.
> 

That does not really help when trying to build allmodconfig or allyesconfig
with gcc 11.4 or 12.3.

drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_prefetch_check':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:6707:1: error: the frame size of 2056 bytes is larger than 2048 bytes

This is with v6.6-14500-g1c41041124bd.

I am overwriting it by forcing CONFIG_FRAME_WARN=0 in my test builds for
x86_64, but of course that affects all code. Maybe consider increasing
frame-larger-than in drivers/gpu/drm/amd/display/dc/dml2/Makefile ?
Currently it is

ifneq ($(CONFIG_FRAME_WARN),0)
frame_warn_flag := -Wframe-larger-than=2048
endif

Guenter

  parent reply	other threads:[~2023-11-06  9:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16 14:19 [PATCH 0/2] Reduce stack size for DML2 Rodrigo Siqueira
2023-10-16 14:19 ` [PATCH 1/2] drm/amd/display: Reduce stack size by splitting function Rodrigo Siqueira
2023-10-16 14:19 ` [PATCH 2/2] drm/amd/display: Fix stack size issue on DML2 Rodrigo Siqueira
2023-10-16 17:35   ` Alex Deucher
2023-11-05 17:55   ` Guenter Roeck [this message]
2023-11-06 12:13     ` Hamza Mahfooz
2023-10-17 17:22 ` [PATCH 0/2] Reduce stack size for DML2 Nathan Chancellor
2023-10-17 17:45   ` Rodrigo Siqueira Jordao
2023-10-17 21:19     ` Nathan Chancellor
2023-10-17 18:02   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa6344f8-abd4-4f9e-86cf-febecd6fd747@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Rodrigo.Siqueira@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=chaitanya.dhere@amd.com \
    --cc=linux-next@vger.kernel.org \
    --cc=roman.li@amd.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).