From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B138DC433E0 for ; Tue, 23 Jun 2020 19:00:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E43F20707 for ; Tue, 23 Jun 2020 19:00:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E43F20707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suffe.me.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 37B506EA3C; Tue, 23 Jun 2020 19:00:20 +0000 (UTC) X-Greylist: delayed 428 seconds by postgrey-1.36 at gabe; Tue, 23 Jun 2020 17:56:09 UTC Received: from lb1-smtp-cloud9.xs4all.net (lb1-smtp-cloud9.xs4all.net [194.109.24.22]) by gabe.freedesktop.org (Postfix) with ESMTPS id A29356EA1D for ; Tue, 23 Jun 2020 17:56:09 +0000 (UTC) Received: from kirika.xs4all.nl ([62.251.34.220]) by smtp-cloud9.xs4all.net with ESMTP id nn2WjhZHZvh6gnn2Xj2fnn; Tue, 23 Jun 2020 19:48:59 +0200 Received: from localhost (localhost [IPv6:::1]) by kirika.xs4all.nl (Postfix) with ESMTPS id 7CDE31A401B0 for ; Tue, 23 Jun 2020 19:48:56 +0200 (CEST) Date: Tue, 23 Jun 2020 19:48:56 +0200 (CEST) From: John van der Kamp X-X-Sender: sjonny@kirika.lan To: amd-gfx@lists.freedesktop.org Subject: Mutex stays locked on error Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463811583-82272270-1592934536=:3391" X-CMAE-Envelope: MS4wfDE5h04KZN7Zntb2g3slg5UMZnb360z0zII7u6w4AU0LE65XG+av/FePReOtIROE2LeGpMsdn5t+gPe33/P4IzLGV7+6VqOrljYSAym/EuzIzxFqC0D+ 2vjnuFf57kJGTuTsHB4LaKLY7wbwvcIsRfoppCQ0COInLXb3Eic1x3MGSJk3smEJMpaornY7N737bA== X-Mailman-Approved-At: Tue, 23 Jun 2020 19:00:18 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811583-82272270-1592934536=:3391 Content-Type: text/plain; format=flowed; charset=US-ASCII Hello, I was reading some code and came across this which looks like a mutex not being unlocked when an error happens. I don't know what the code does or how to test it, but it looks quite obvious. Patch is attached. John ---1463811583-82272270-1592934536=:3391 Content-Type: text/x-diff; name=amdgpu_dm_dhcp-mutex_unlock_fix.diff Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=amdgpu_dm_dhcp-mutex_unlock_fix.diff ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRn cHVfZG0vYW1kZ3B1X2RtX2hkY3AuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv ZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtX2hkY3AuYw0KaW5kZXggZGNm ODRhNjFkZTM3Li45NDlkMTBlZjgzMDQgMTAwNjQ0DQotLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbV9oZGNw LmMNCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVf ZG0vYW1kZ3B1X2RtX2hkY3AuYw0KQEAgLTUxMCw4ICs1MTAsMTAgQEAgc3Rh dGljIHNzaXplX3Qgc3JtX2RhdGFfcmVhZChzdHJ1Y3QgZmlsZSAqZmlscCwg c3RydWN0IGtvYmplY3QgKmtvYmosIHN0cnVjdCBiaW4NCiANCiAJc3JtID0g cHNwX2dldF9zcm0od29yay0+aGRjcC5jb25maWcucHNwLmhhbmRsZSwgJnNy bV92ZXJzaW9uLCAmc3JtX3NpemUpOw0KIA0KLQlpZiAoIXNybSkNCi0JCXJl dHVybiAtRUlOVkFMOw0KKwlpZiAoIXNybSkgew0KKwkJcmV0ID0gLUVJTlZB TDsNCisJCWdvdG8gcmV0Ow0KKwl9DQogDQogCWlmIChwb3MgPj0gc3JtX3Np emUpDQogCQlyZXQgPSAwOw0K ---1463811583-82272270-1592934536=:3391 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ---1463811583-82272270-1592934536=:3391--