From: Julia Lawall <julia.lawall@inria.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: opensource.kernel@vivo.com, "David Airlie" <airlied@linux.ie>,
"Bernard Zhao" <bernard@vivo.com>,
"Felix Kühling" <Felix.Kuehling@amd.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v3] drm/amd: Fix memory leak according to error branch
Date: Sat, 20 Jun 2020 15:21:43 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2006201520590.2918@hadrien> (raw)
In-Reply-To: <119b7d8c-b164-ef23-84cc-4904d34ac023@web.de>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Sat, 20 Jun 2020, Markus Elfring wrote:
> > The function kobject_init_and_add alloc memory like:
> > kobject_init_and_add->kobject_add_varg->kobject_set_name_vargs
> > ->kvasprintf_const->kstrdup_const->kstrdup->kmalloc_track_caller
> > ->kmalloc_slab, in err branch this memory not free. If use
> > kmemleak, this path maybe catched.
> > These changes are to add kobject_put in kobject_init_and_add
> > failed branch, fix potential memleak.
> …
> > Changes since V2:
> > *remove duplicate kobject_put in kfd_procfs_init.
>
> Under which circumstances are going to improve this change description accordingly?
Bernard, please update the log message as well. The mail you sent was
much more clear, but mail just gets lost over time. The log message
itself should be improved.
julia
>
> Would you like to add the tag “Fixes” to the commit message?
>
> Regards,
> Markus
>
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-06-22 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 12:37 [PATCH v3] drm/amd: Fix memory leak according to error branch Markus Elfring
2020-06-20 13:21 ` Julia Lawall [this message]
2020-06-20 14:56 ` Felix Kuehling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2006201520590.2918@hadrien \
--to=julia.lawall@inria.fr \
--cc=Felix.Kuehling@amd.com \
--cc=Markus.Elfring@web.de \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bernard@vivo.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).