From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 125CFC433EF for ; Wed, 20 Apr 2022 18:50:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB57D10E70F; Wed, 20 Apr 2022 18:50:02 +0000 (UTC) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2052.outbound.protection.outlook.com [40.107.223.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4CD910E2C3; Wed, 20 Apr 2022 18:50:01 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eKYEYbPAWIijNP01T0iHUFbGMcg5XXzUMTv04lpRyxwZMOHpSmhUKJfd8xljCUoOgg2mO9aNzQLvCQVUE19nqtgOzB37qCDPzw3pW+B0WYLF9U+mqSQSLXiROZci2SmfoCt8++zJ4iPkgj62R2Awee8rhM+GQQuXjflI9ICfFTd0KxhR57BEgRHxzfc1wqBzHFNs27h//mggIQpZtOJR2K1UDEPto7o5qlN6hxh0cQB6AmHSOgqNdpm9FthllwpqnCddfupnCZp2H4WVzPTCik6V1QUFkUmFGKqtQ9KYnSqXK9EVtfHR8itPJMLpRHyrGV+c9jSKawyxP6ACG+4cSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MZvzCibjrFi8oaBViBIR6iaRj4X6REwO3ZbIP16Yv/U=; b=f/YHzv6U4c9dGYZxe5IwJURsAokVxxp9O26fM10ll/41DjtxbH8pYSwKdLlKTiwi2RikIdMLWi8uewDXZCKuU7g1/Q4xsckPoTMAFu5XA6d0mG2GO4IneRsJ3/rQdhFYOdt5stzNNrk4qDHrhepvPSmGex+NtntajrPAyq6VjiKRQWexRRPzZuEniR8xst1PBHulTlGGCyrWlFG8OiTMbK2JgfnSQT9FwzcWHYKREYd1Q6tWhN8eyDvuHbB/ZEUk+APBnaLVtRmMKv2IsmYCfvoWF2177xnfAjDBdk7Yj1HIePISJ3KV9/Jc1YKmJmmfSpWddR/osMpeRmHjkvDhAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MZvzCibjrFi8oaBViBIR6iaRj4X6REwO3ZbIP16Yv/U=; b=qu5nDsvs/VcjiC6WMMsVmp8v0EjmI4/CYzrP9S6UCIppSR+6RQGpG+4jMtJebE7zzwJFoI6GQcVAqQ/kCTf1DrmmQrHBHxMcmmibyybPJphqqoUXwMGAOJN7WuhmfzTUUHRGysAw1vUfn31SUtbxPnNYqGffoajCNRvdrhiZPCI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) by BYAPR12MB2725.namprd12.prod.outlook.com (2603:10b6:a03:6b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Wed, 20 Apr 2022 18:49:59 +0000 Received: from BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::a5fb:7137:5e64:cf8]) by BN8PR12MB3587.namprd12.prod.outlook.com ([fe80::a5fb:7137:5e64:cf8%5]) with mapi id 15.20.5164.026; Wed, 20 Apr 2022 18:49:59 +0000 Message-ID: Date: Wed, 20 Apr 2022 20:49:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 03/15] dma-buf & drm/amdgpu: remove dma_resv workaround Content-Language: en-US To: Zack Rusin , "dri-devel@lists.freedesktop.org" , "linux-media@vger.kernel.org" , "daniel.vetter@ffwll.ch" , "linaro-mm-sig@lists.linaro.org" , "ckoenig.leichtzumerken@gmail.com" , "intel-gfx@lists.freedesktop.org" References: <20220407085946.744568-1-christian.koenig@amd.com> <20220407085946.744568-4-christian.koenig@amd.com> <60ab53ce1ce1333f5e6a15fc83c3c05cd9bd1084.camel@vmware.com> <4c2e9414-3926-c9d7-8482-0d6d9191c2ac@amd.com> <54d00af9-9384-5794-490c-7d4cafe086b6@gmail.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P192CA0074.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::15) To BN8PR12MB3587.namprd12.prod.outlook.com (2603:10b6:408:43::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31b5c3f4-c2ba-4dfd-8330-08da22fe91ed X-MS-TrafficTypeDiagnostic: BYAPR12MB2725:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3wmhVe9mRT8qHcU9cu/bODx21vurTsNvxv63BvO021+98MJc/Y6JhRI5/LDawr1ApxvoXUGQlN585snu+mUn+Hc+/tCdPIhFm3IYjXETsjEwgp1P7wrwPd2fO8NMz6O46S4lKAP+nsVhyxTgaCo2RlozfOtB+pCkLv3jWr/1Lpz1fiQwaMytF1rDYPRlffVdCNiF6I1PbjDnnTzqPrghbd5ruALbsaqCVk4DtHSvx/N1v5d2a0zLqPvJhvhJVq4mxn/HORWP7nHQIohbz4MIJlrcimYVBbvXGS6dFYzVeR1cHHsmoyF5EhCYeZRgKNtvGPB/5LlTF3CWZk2sP29fF4FZZmDxdqdfTVAM+UciLnG9lepg8/Wf6diwLglG6btFX1oJnLLj2rFiaZ8NwQi97X6uNxeThvd36PVFzL6CimJomM7iGmTSOgciBnbSP1x5gDJSO2XI4iZ3nX9axk02GqUeRSrP313WS5K4YLcbRKrlXN/1kBan/Mr8W9dMPDtixI4tZ8pBfycEegYGPq3K5ho+6D5RX8MXxlRlXmPmkw3TZkKYs6fUEXxrWIsBmGorh6NyX9iDYkN2lt1AFA+HMzS5908iHkOXFqxaWaZAwlzcpfwDSpkFm3CsWXFo5bl9K2ertojpODqHIhxx/Cey7ONuIWM80ZuQxOzaTUrr1lq8GgCvPxx/3nn6ZIpNPfdyclq+zcREn33ovJXiZWdL8MGTwJ/+JeN6r6XDRKH6tv6qk5dvUHrtrRLH5uyMdg5P X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR12MB3587.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(36756003)(86362001)(316002)(8936002)(38100700002)(2906002)(6486002)(5660300002)(6512007)(66946007)(8676002)(110136005)(66476007)(508600001)(66556008)(4326008)(6506007)(6666004)(2616005)(31686004)(31696002)(83380400001)(186003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVRpeDN1N1NYZ2NFUEt6SmVtbVF4bkN5Mm92LytVSTRjQnAzcEF0SUNBOVdO?= =?utf-8?B?U2JyK1dkNk1IWEphOUR4NzBJVkliUDJkTDgvYkNvTWtncnZPV2VjOTNOKzhJ?= =?utf-8?B?V0lGNC9aNzdWTS8vUGV4RnlxVnNkMHIzOVg1anV5NS95NnRHdEdGNkFqbXBZ?= =?utf-8?B?RUxmbWQxSGJrTUtjVnkvUllReFYxazk3TnV0bDFISys2dG5oY1FRWFA2TWtp?= =?utf-8?B?eXcvbWpPNjRGbDBOcFlvMVF0YjM3YkcwdHo2cDM5MWFmMjA4MkxHaVd3Wjdm?= =?utf-8?B?SWsxZTBmdE1iNmhOaUl0RzNBZnVVMXhiR2FFZUErOHNGSEJNaDB5eSt4ZWdJ?= =?utf-8?B?REpoWDV4K2JNVjRFVlBzN1VtM2xDU3MrcFpJcGpjU01OWC9CcDBtRzcrVGV4?= =?utf-8?B?QmJoU1Y0RHJtS2NkbFJQOERsK1NKZFVSU1BEcUFkRnBpZEEyWkRDaTV5Vk84?= =?utf-8?B?UUllUkRyMlkxN3ZKcHcvTXNkMytQVHFPZExVZk12bmdLQmhIRkxyMkY4aEJS?= =?utf-8?B?bTdRdGJJL09NOFNEdStvYW1wUHQvQmw2ZEcwWFRNalhjMXNjam1tOUNnU250?= =?utf-8?B?THc4V3Y4YWVxS01lZ3NSR1B4b1MwZ3YxUnhrVGZlakJyVUx5UFM1SkdTMXRy?= =?utf-8?B?YWQwMDFSaGpwa3UxWXgvZEVMN29FcnBQRkszUWRjREw4ZEE0WmZ5VzVreEtn?= =?utf-8?B?QjNaRTNUbEJXd1k4Qlp0MDMvekJrNEhLMGFHK0tvaXBJU0Zkdnh5ckVPdlFO?= =?utf-8?B?MnFkRDFacUpWbzhHcG5EeVJRVG1ZckFUNXZwRGxmSndsWWtJeGNZa2lJZStP?= =?utf-8?B?bXV3cEdGMXI4YlRLSFNnai9QalRqL2hNa0lmUGlnSVd5MU82WENyZnpOT0Jm?= =?utf-8?B?T1I3bXNuSDBVTXIxd3BKZ3FqR2R2RlJOOEx2NDJRc1A0WUVuSUozcXN4R09J?= =?utf-8?B?SkRSZW1UajlEV3JuVDJSL3RPU3Y5Z2NPSk1ENEFOWFBhQ1k4dTlCcE1OVDRD?= =?utf-8?B?OUdFdjVkZUc2QWhidzNqOWtxck1pQ1MwM2ZZc1VOVU1IZ0NEM3FzMk04VVpk?= =?utf-8?B?MU1Db0JqRmYwTmhCM1YxeEdUQXhtOEs2bk04elB1Q0xNTkV5VmlqREl4TmtO?= =?utf-8?B?SjFUL3VSMm02dktOZWRWZ1FURmw4Sld4VHVvSWZKbWtUS21lUnA5TjMzWk8v?= =?utf-8?B?ci9CRmxJazBnVGxLeURrdi9pN2RiWG40L2YwaDhiR0JGTm1Ua2dwUTNzZk5N?= =?utf-8?B?aVo2YjdXUGg2djlXYlRzOXFUbUV3dmdUWGdNcG9DK0FtSHc2bHJVL2w0d2V6?= =?utf-8?B?dmpFWVpEZ3lxclF5NkRvMzRVRDZiVDNGdEhBeEd6bG1RdHhIK1didVhndXVM?= =?utf-8?B?ZXErbVFOVTFtMzA0Sm05ZTBmT3BMMlBMaDdJeDByV2ZkM25lKzEyUnNROFlL?= =?utf-8?B?bUp2Z2s5YmJVa0R4MENrbVBucmsyNjlsdjYzdUUzVVFQalJGN0FmTEZ6SnJW?= =?utf-8?B?Ry95djhxTmxrR3Y2RHVqRStLME1zSWpkZy9SM1dUVi94OUtCdnM3bTZkbDhu?= =?utf-8?B?NmUzczZ6VkYvZ1granM0WXYyZEw4WExXZW5FS2JHUUxEMGxMcmlaRFl5Rm9S?= =?utf-8?B?NjVwcnhmdG5FdWtKYTAwdU50YTNvemc0cDNXeEpCbjhDS0ZWOCtsL3lRenVo?= =?utf-8?B?YisrK2VXMFlvbnc4QzVVZDFSd1Jkc0lETTRHdFFxTi9hTG9UK1daNGxBT3VR?= =?utf-8?B?MGtMSzFXWko2dXBYdzFmRWF4RHhCTDgzOFJzT3JJL2VKWnBoRkxiaFJwMW5a?= =?utf-8?B?WnJIT2hmN2VmUWNrZElJMlNUakx6TDNUSWh4NUEzQ01kN0hFVnNCcWhjSHhK?= =?utf-8?B?dG9BVUlWY3p5VERzbVFLbVhaNXhIS1lteEo1ZUZsWkJkS1dvRk1oM0dGOUdr?= =?utf-8?B?MGRGeGQyaW1kNTFzZVlON0ZPbEszamVwcjlQdG1qcWk5QTRRWnJlK2dneENC?= =?utf-8?B?bzZoRG1Lalk2M1ZTbzhscncyOG04VjJFbzlKS05HT0NteTNWSkg3OWEyb0VN?= =?utf-8?B?WDk1bVFEeWJCc09ma0U3akJQNVU1SEM4SlFlZk9sQUdWRGlXejI4N3hqYXZr?= =?utf-8?B?dXNtSVI2NTZFVmVYdGVVcEJJVWExL2xDQWljU0ErQWc0aHlFd1JZUjNRSVRl?= =?utf-8?B?bW1IYkdWRFpRWGlGY3FKamxVVGJ1T2xJRU5QOHY4NVZzNUVPTVcxaXd1Ynlo?= =?utf-8?B?Z3NXUC9KLzI2dUovU0Y2WXFKYjhBMlF4SkRKN3VrRlRFQWYyVVpZdjlGZy8z?= =?utf-8?B?WGFYYkhKWFMrVFk3ZjN4aDd1a0laaldJM3c2ZWJGVmoxdTZibGdZREp0QlBD?= =?utf-8?Q?A6J+0EKwO+fGwgUVZZptp19DNKSvFG8fhuA8PlQxfkpSR?= X-MS-Exchange-AntiSpam-MessageData-1: 5bqitQnTNaKFhg== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31b5c3f4-c2ba-4dfd-8330-08da22fe91ed X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 18:49:59.4302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: emkEjwsjlWwBq0d+ahFrgi0qC40HT6pTimkJ5Zj9u59+cHkBPyP3UJskKH4wYxog X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2725 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "amd-gfx@lists.freedesktop.org" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Am 20.04.22 um 20:41 schrieb Zack Rusin: > On Wed, 2022-04-20 at 19:40 +0200, Christian König wrote: >> Am 20.04.22 um 19:38 schrieb Zack Rusin: >>> On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote: >>>> ⚠ External Email >>>> >>>> Hi Zack, >>>> >>>> Am 20.04.22 um 05:56 schrieb Zack Rusin: >>>>> On Thu, 2022-04-07 at 10:59 +0200, Christian König wrote: >>>>>> Rework the internals of the dma_resv object to allow adding >>>>>> more >>>>>> than >>>>>> one >>>>>> write fence and remember for each fence what purpose it had. >>>>>> >>>>>> This allows removing the workaround from amdgpu which used a >>>>>> container >>>>>> for >>>>>> this instead. >>>>>> >>>>>> Signed-off-by: Christian König >>>>>> Reviewed-by: Daniel Vetter >>>>>> Cc: amd-gfx@lists.freedesktop.org >>>>> afaict this change broke vmwgfx which now kernel oops right >>>>> after >>>>> boot. >>>>> I haven't had the time to look into it yet, so I'm not sure >>>>> what's >>>>> the >>>>> problem. I'll look at this tomorrow, but just in case you have >>>>> some >>>>> clues, the backtrace follows: >>>> that's a known issue and should already be fixed with: >>>> >>>> commit d72dcbe9fce505228dae43bef9da8f2b707d1b3d >>>> Author: Christian König >>>> Date:   Mon Apr 11 15:21:59 2022 +0200 >>> Unfortunately that doesn't seem to be it. The backtrace is from the >>> current (as of the time of sending of this email) drm-misc-next, >>> which >>> has this change, so it's something else. >> Ok, that's strange. In this case I need to investigate further. >> >> Maybe VMWGFX is adding more than one fence and we actually need to >> reserve multiple slots. > This might be helper code issue with CONFIG_DEBUG_MUTEXES set. On that config > dma_resv_reset_max_fences does: > fences->max_fences = fences->num_fences; > For some objects num_fences is 0 and so after max_fences and num_fences are both 0. > And then BUG_ON(num_fences >= max_fences) is triggered. Yeah, but that's expected behavior. What's not expected is that max_fences is still 0 (or equal to old num_fences) when VMWGFX tries to add a new fence. The function ttm_eu_reserve_buffers() should have reserved at least one fence slot. So the underlying problem is that either ttm_eu_reserve_buffers() was never called or VMWGFX tried to add more than one fence. Regards, Christian. > > z >