From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Luben Tuikov <luben.tuikov@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Alexander Deucher <Alexander.Deucher@amd.com>,
John Clements <john.clements@amd.com>,
Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH 0/4] Normalize redundant variables
Date: Wed, 5 May 2021 08:39:17 +0200 [thread overview]
Message-ID: <c05d4983-bcb5-e735-171a-fb878c448124@gmail.com> (raw)
In-Reply-To: <20210504214756.3816-1-luben.tuikov@amd.com>
Acked-by: Christian König <christian.koenig@amd.com> for the series.
Am 04.05.21 um 23:47 schrieb Luben Tuikov:
> Classic normalization of a redundant variable.
> There is no need to have two variables representing
> the same quantity. Move up to the structure which
> represents the object which determines their values.
> Rename to a consistent name, and export to debugfs
> for debugging.
>
> Luben Tuikov (4):
> drm/amdgpu: Remove redundant ras->supported
> drm/amdgpu: Move up ras_hw_supported
> drm/amdgpu: Rename to ras_*_enabled
> drm/amdgpu: Export ras_*_enabled to debugfs
>
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 91 +++++++++----------
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 5 +-
> drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/soc15.c | 7 +-
> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 6 +-
> .../drm/amd/pm/powerplay/hwmgr/vega20_baco.c | 2 +-
> .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c | 3 +-
> 11 files changed, 63 insertions(+), 66 deletions(-)
>
> Cc: Alexander Deucher <Alexander.Deucher@amd.com>
> Cc: John Clements <john.clements@amd.com>
> Cc: Hawking Zhang <Hawking.Zhang@amd.com>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-05-05 6:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 21:47 [PATCH 0/4] Normalize redundant variables Luben Tuikov
2021-05-04 21:47 ` [PATCH 1/4] drm/amdgpu: Remove redundant ras->supported Luben Tuikov
2021-05-04 21:47 ` [PATCH 2/4] drm/amdgpu: Move up ras_hw_supported Luben Tuikov
2021-05-04 21:47 ` [PATCH 3/4] drm/amdgpu: Rename to ras_*_enabled Luben Tuikov
2021-05-04 21:47 ` [PATCH 4/4] drm/amdgpu: Export ras_*_enabled to debugfs Luben Tuikov
2021-05-05 6:39 ` Christian König [this message]
2021-05-07 14:45 ` [PATCH 0/4] Normalize redundant variables Clements, John
2021-05-05 7:30 Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c05d4983-bcb5-e735-171a-fb878c448124@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Alexander.Deucher@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=john.clements@amd.com \
--cc=luben.tuikov@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).