From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_FONT_SIZE_LARGE,HTML_MESSAGE, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254F8C4741F for ; Tue, 10 Nov 2020 17:54:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9406A20809 for ; Tue, 10 Nov 2020 17:54:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="RaKuH3Ic" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9406A20809 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4EEE89157; Tue, 10 Nov 2020 17:54:26 +0000 (UTC) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2050.outbound.protection.outlook.com [40.107.93.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E29E898A3; Tue, 10 Nov 2020 17:54:25 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PXUTUxO0ssV9cjluf/W+j847nR+IEyHW9EbVZCr7gp5XBtASUdbppPK5mQTPml74YsNwoSeKWCvSDdleqm6yY8/X2pHy1ofj33vq6jHaKsWbJnQ/3MouEK6vJQcjTu//cTmH043dHFhdkBcT9UVd/PsQn40QB09wz89zU7K0ZA+2rQ/M417gJn9Gov1RuQ14V8+1SjeQuDKkqS4viCBtNP6tIYffL949SUVruN6t3B3r6W+rpjGtFWYk4dAZChwwg2O1VND9PcehqSBTn4y7/8NOSIgtIAA7Er0pZ+SoD6F8sm/4QzDzvtAPC0Ja0jAZMN1+TQSHFpCZ0zzFMN97vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OvTvtagcGkSi1kbBKpXY9Y0F9MvjlQ8xiWSam7ejYbA=; b=UIaghE7mu4mtwcdToaOsbqZbxaxreiL9fZwJNNvBG+4sXgjOzvKHmhgLVjkc8acxlln8E3ZC13ECJsyMNqVJG+cTBqUInAVeXeaq+QaGBKt3zfobd1zaFdbc4SZ9NgJC+C1GH1r0w6d4whZBAlqNYWieDBTFeubsIrJzY+i/lXMLOMIGNvqZkXvKw9jIhP9VDUgSxfPCzepwQaQ2oilSg+6BNNIy5iE+Ywmldx60j0rYy5/n8ywDZvCLaHJrfVJwAzpqm2jrBdd8baboEhjGODtC/N28FMV37eequ2xkAnS970BqwxkLTJ9kqpV7Ms0RWoXQInc4/CWNVztrRAVl4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OvTvtagcGkSi1kbBKpXY9Y0F9MvjlQ8xiWSam7ejYbA=; b=RaKuH3Icp+NEBCQzV18Tw+qdwYwWEWsB/zAWmr2sq9/PsQMgJa/FU3KvBAWmgMP9IKMriKrRHGb3QVi6ZCh7PVxR3JHW0Vy/zeYCDtc4vNX+CicDRsEMklsXpfyo2i3ZZGfDuLQPNoxN5524nZitKB+vnV0OzO1grKNtIMk2hqA= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4340.namprd12.prod.outlook.com (2603:10b6:5:2a8::7) by DM6PR12MB4578.namprd12.prod.outlook.com (2603:10b6:5:2a9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Tue, 10 Nov 2020 17:54:23 +0000 Received: from DM6PR12MB4340.namprd12.prod.outlook.com ([fe80::a881:155d:45db:b435]) by DM6PR12MB4340.namprd12.prod.outlook.com ([fe80::a881:155d:45db:b435%9]) with mapi id 15.20.3541.021; Tue, 10 Nov 2020 17:54:23 +0000 Subject: Re: [PATCH v2 5/8] drm/amdgpu: Refactor sysfs removal To: Greg KH References: <1592719388-13819-1-git-send-email-andrey.grodzovsky@amd.com> <1592719388-13819-6-git-send-email-andrey.grodzovsky@amd.com> <20200622095124.GE20149@phenom.ffwll.local> <20200622112139.GA3421602@kroah.com> <20200622164551.GA112181@kroah.com> <4787b2a9-e7bf-ea3c-02e9-484a4fcb4742@amd.com> <20200623060532.GB3818201@kroah.com> <090c5a35-3088-d6d0-dcaf-5ce5542a4298@amd.com> <20200624061153.GA933050@kroah.com> From: Andrey Grodzovsky Message-ID: Date: Tue, 10 Nov 2020 12:54:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 In-Reply-To: <20200624061153.GA933050@kroah.com> Content-Language: en-US X-Originating-IP: [2607:fea8:3edf:49b0:757a:f239:6b01:6396] X-ClientProxiedBy: YT1PR01CA0075.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2d::14) To DM6PR12MB4340.namprd12.prod.outlook.com (2603:10b6:5:2a8::7) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2607:fea8:3edf:49b0:757a:f239:6b01:6396] (2607:fea8:3edf:49b0:757a:f239:6b01:6396) by YT1PR01CA0075.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Tue, 10 Nov 2020 17:54:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4f245fa1-e06b-498c-2e6d-08d885a1a85c X-MS-TrafficTypeDiagnostic: DM6PR12MB4578: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:534; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J7UrnQBpQbDH2XylefVyOcSOsAF7+0bR+n+s890r0KqDvIA4JZDTLgnlI9ngKfx/qqBf/l9hL7/HPtx6MqJSwN5AexKxGTO5W54hNsRsc1nLelzPUva4AptFI1dM3EIi6+82C2FFRpiGaz4fur5GhI5wygQ/H2LXLOfNfO6rQYuTO8xJZYvwIKcIEMJvv/w318Gm/KZ7xSx+tmOXqjzeSdIi+DfCm8WiWUgeipsxAzv6E+3uw3Rc3RFPAIcUsrQ+uIP2ZzgRW4UHUnr68jacrEoqRoJD90+UER5bm90oaNwHMfjofm66IZWQnU40Dwo7oemXMGfiabl1dM6u73vLRCRrKE9jR7C1S7xfMHDrLQ5lLO/xVcETwegRWLvGXPuhLRlX4yElbfy0jtNeKLoDDgHq60VLk5B0d+DlZ8pXpzM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4340.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(5660300002)(8936002)(4326008)(66476007)(86362001)(52116002)(966005)(8676002)(2906002)(316002)(166002)(66946007)(36756003)(66556008)(6916009)(2616005)(33964004)(16526019)(31686004)(6486002)(186003)(478600001)(53546011)(31696002)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?WGNVaU9FWlFYeGVTbkUremFRdGhvczVnSlpaSmYxcTJEQ2hWZE9wR2NqZFk3?= =?utf-8?B?YWFVRTBXL1pXTFllMEhSS3R4bUdxelE3eU1yRDk0SHJkN0NBMDVwblhOY2Q4?= =?utf-8?B?SnpibHFQRkt5QTZGMWIrQU1SaUV6S21nb3AvRjlRUlpOUmtQMVhIL2pzZ2gz?= =?utf-8?B?STdtSlFUTjFhK1NwV1NQNlhudHVCTHpHSktXUXdXOUhocW85RnRqQmM5cDFu?= =?utf-8?B?T0U2NG5RaHQrUkNWeVFKNHM4YzhZc2o5bmNZb1NyRXZsOWVzYUx5ZDlmdDdP?= =?utf-8?B?NTRDbUp5S01QNlVNNGx6U0tWMUoxQUl4ZUF4ZGNWb3FzOVE2T3l6SVpFb0Nr?= =?utf-8?B?RlBFTm1PdzFEc0huZzA2aThBS2c4dXRUcHE2T1ZSRFhVTmdXckN5N3ZYRzh0?= =?utf-8?B?eXhwbDZ1K0RWdk5MSnA0MGE4R1RpbUlPSVJ6Y2dZQk9HcHFXMHppSVlVTCtF?= =?utf-8?B?MXVrRVpUM2NGQU9vU0UycnRXc0dKSEtHb1ZkT3Q3anZ1VlJvNjdadDhiS2Nx?= =?utf-8?B?WnBuemplZDJaVUZqWllBZm1DemlFZjNxWlJvMHJxMWhlL2pBQXp0bEM5NzJs?= =?utf-8?B?YkhsWDZ0VU5Rbmo1Yk9tcGd0aFFGb3N0TmZqT3ZSeVBZbHBiSWY2MEMyVXk2?= =?utf-8?B?OEhXVG1RM2VjdFJBcFkycGY1RFY2UlZZK0F6bHBCZk9jL1laeFMyRWREUkxi?= =?utf-8?B?RVVPZDZzVWo2OUhwL1I2S0dzZkE1WXFON2xudEdpUnN2T2IzZ2tyMUJqU0sx?= =?utf-8?B?M2w3SVhnYjZEVUVSN01QTEY2ckptd0JIamFtMlhhV3U0VmZydU5aQWJmVVRR?= =?utf-8?B?L0YvZ3ZQQzNDTmZVbkpDUWUxOVFLZG1JRklPKzhtMzdJb2R4R1lwZG9NYUpI?= =?utf-8?B?WmgydG1rVjNjR2FMdFg3cnc1bDZMV2dnMnNlQVpFZ2tCa2I1MmJBUk1GMWhs?= =?utf-8?B?WVF3c2xyWkRmMWh1bUszUkdhMnYrNmxFMDR2SnZmdVZIZmRkd093MTB4WjV4?= =?utf-8?B?MjY5OE9qTlhodHcrV3A5RjF5RDZ0RXo3OXh2TjlQbDJYNHMzSXN6RVFqNW5i?= =?utf-8?B?WVdpRjVMT1VLaERXU3dqa3U0TnNxemsvcStEa0w2WnRDRnNBQUVHcm56Ulhv?= =?utf-8?B?UGpFNktkR1g1cEV3M2VJbmhRYmlXald4dWVwQytqaUhoVDNzNlNMeGtCU1Bl?= =?utf-8?B?UVNhd1JGSXNXUjB5cFFYSkg5ZXpRVVFOOTdYTE9WaGNnWFV1cDdpOFBGUnox?= =?utf-8?B?dUtHcmpCUytRWXp4Um92LzNwcXZySW9JemlMTmRjOUFDVDVKdz09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f245fa1-e06b-498c-2e6d-08d885a1a85c X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4340.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2020 17:54:23.5161 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Faq/tu02K3f9pStN4PmpHDP2Gw2L4tefQNzWCXFokrGg8OyIXdMv8nQUnFx2zk9J/WD/X8r0wBR+xTqE/CRdZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4578 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.vetter@ffwll.ch, michel@daenzer.net, dri-devel@lists.freedesktop.org, ppaalanen@gmail.com, amd-gfx@lists.freedesktop.org, Daniel Vetter , ckoenig.leichtzumerken@gmail.com, alexdeucher@gmail.com Content-Type: multipart/mixed; boundary="===============2023924899==" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" --===============2023924899== Content-Type: multipart/alternative; boundary="------------9B0C735053E2719B7A5EBAB3" Content-Language: en-US --------------9B0C735053E2719B7A5EBAB3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, back to this after a long context switch for some higher priority stuff. So here I was able eventually to drop all this code and this change here https://cgit.freedesktop.org/~agrodzov/linux/commit/?h=amd-staging-drm-next-device-unplug&id=61852c8a59b4dd89d637693552c73175b9f2ccd6 was enough for me. Seems like while device_remove_file can handle the use case where the file and the parent directory already gone, sysfs_remove_group goes down in flames in that case due to kobj->sd being unset on device removal. Andrey On 6/24/20 2:11 AM, Greg KH wrote: >>> But why are things being removed twice? >> Not sure I understand what removed twice ? I remove only once per sysfs attribute. > This code path shows that the kernel is trying to remove a file that is > not present, so someone removed it already... > > thanks, > > gre k-h > --------------9B0C735053E2719B7A5EBAB3 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi, back to this after a long context switch for some higher priority stuff.

So here I was able eventually to drop all this code and this change here https://cgit.freedesktop.org/~agrodzov/linux/commit/?h=amd-staging-drm-next-device-unplug&id=61852c8a59b4dd89d637693552c73175b9f2ccd6
was enough for me. Seems like while device_remove_file can handle the use case where the file and the parent directory already gone, sysfs_remove_group goes down in flames in that case
due to kobj->sd being unset on device removal.

Andrey

On 6/24/20 2:11 AM, Greg KH wrote:
But why are things being removed twice?

Not sure I understand what removed twice ? I remove only once per sysfs attribute.

This code path shows that the kernel is trying to remove a file that is
not present, so someone removed it already...

thanks,

gre k-h
--------------9B0C735053E2719B7A5EBAB3-- --===============2023924899== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --===============2023924899==--