From: Tales Lelo da Aparecida <tales.aparecida@gmail.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: airlied@linux.ie, Xinhui.Pan@amd.com,
Abaci Robot <abaci@linux.alibaba.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, daniel@ffwll.ch,
alexander.deucher@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH] drm/amd/display: remove unreachable code
Date: Fri, 12 Aug 2022 14:36:56 -0300 [thread overview]
Message-ID: <e95a5040-6cd2-3b74-1b65-50bc7c6b6ddb@gmail.com> (raw)
In-Reply-To: <20220812031911.62729-1-jiapeng.chong@linux.alibaba.com>
Hi,
On 12/08/2022 00:19, Jiapeng Chong wrote:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:1658 dml32_TruncToValidBPP() warn: ignoring unreachable code.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1894
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> index 05fc14a47fba..0758e1da55a9 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> @@ -1654,10 +1654,6 @@ double dml32_TruncToValidBPP(
> else
> return DesiredBPP;
> }
> -
> - *RequiredSlots = dml_ceil(DesiredBPP / MaxLinkBPP * 64, 1);
> -
> - return BPP_INVALID;
> } // TruncToValidBPP
>
> double dml32_RequiredDTBCLK(
Seems correct.
Reviewed-by: Tales Aparecida <tales.aparecida@gmail.com>
I feel like RequiredSlots is not actually used anywhere in the code,
just passed around dml32_TruncToValidBPP() and
dml32_CalculateOutputLink(). I've looked for any mentions of it in the
mailing list, but could not find anything that implied it's part of
ground working. I wonder if it's something outside the Linux tree for
other platforms or related to HW gospel.
prev parent reply other threads:[~2022-08-12 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 3:19 [PATCH] drm/amd/display: remove unreachable code Jiapeng Chong
2022-08-12 17:36 ` Tales Lelo da Aparecida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e95a5040-6cd2-3b74-1b65-50bc7c6b6ddb@gmail.com \
--to=tales.aparecida@gmail.com \
--cc=20220812031911.62729-1-jiapeng.chong@linux.alibaba.com \
--cc=Xinhui.Pan@amd.com \
--cc=abaci@linux.alibaba.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).