From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EDC9C433ED for ; Wed, 14 Apr 2021 06:45:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10CA361222 for ; Wed, 14 Apr 2021 06:45:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10CA361222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 95CAD6E8BA; Wed, 14 Apr 2021 06:45:18 +0000 (UTC) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FD7E6E8BA for ; Wed, 14 Apr 2021 06:45:17 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id l4so29655262ejc.10 for ; Tue, 13 Apr 2021 23:45:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=yCIpCh29NQQGTE1399nxkw0Wa/tIfauAN8Ac+xwWwg4=; b=HZjMjORtFuw+m2EamPO82U/UpL7RGonWgEl1cRnqSJHLa9kxBEgU25f7xaF1kUw019 EH5gaomEhTqV0R9Uy4yIinU2MbNzKKtCe489EZtS/wb9t8e39Ql6kkNyBZjk6iDIThc5 k+nZdi7ohk78cVImhIj/N346qTmbJbqJvqQf6kiC2O0VI6RLpT45YqRNJCAh6adcWrb9 kWHqaBF4C4FGX92wclc2AatNHGSFYxPWptpg28qq+ymC7W2U+bI4aaFY2P5bAE2uwVio VgbjqcrdV3/HJOobilLMY+HqHtN6DQG+SjO1uJ+PRht8/0kTQd/ZD/Cknox3Ztj3/2yj hQSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=yCIpCh29NQQGTE1399nxkw0Wa/tIfauAN8Ac+xwWwg4=; b=WT4OdW4tjIWj/ZbM+lEI4NCrxPpoi2bdQmWgwdDHZhiJy+Hhqmwt5FTZuSXWkvGTAT BXwSVuBJdMTRdtgtiS72UyMmryQ2YxSBRJEG+x2JM2L0HochIOGiOTJ8Y4YqJYhqZbjr jue+BySC9gxWeG2cdAghiKjYHITdS7MKxrS78S5JWmkl4FJOpDNHZ1TJ+nFVPmlBKMlX XtUJt4YJFVvYmHjREH3juCQ+zT7btY4lSVSEzOwTffDxMtMeSIMNgQpZlwWhUsSdbF0T UhYLEkCSMjD30Hv0IJjRSTSe9tb1rDqHKc5ViJA/X84F/pfOpqKnVIkMZ5TxbRPb6Bfb 2EDw== X-Gm-Message-State: AOAM531sDhn+apI9p/rFcTyOV9CCiHS97k6WnNVQt3z0o/Pa/pLDcgFM OD53K4gyer7UlYchj92kp+88hcdEO28= X-Google-Smtp-Source: ABdhPJzndFsfQoK2u+sEEu+FQEt7mVWdQ/ED4OfS6lH3wyuKJ9tn0e5fhY6zyA6OqTz7fU9VDxdSXg== X-Received: by 2002:a17:906:341a:: with SMTP id c26mr25319252ejb.238.1618382715898; Tue, 13 Apr 2021 23:45:15 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:eb49:bad8:5b80:ea48? ([2a02:908:1252:fb60:eb49:bad8:5b80:ea48]) by smtp.gmail.com with ESMTPSA id a21sm1645801ejk.15.2021.04.13.23.45.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 23:45:15 -0700 (PDT) Subject: Re: [PATCH] drm/amdgpu: Use iterator methods exposed by amdgpu_res_cursor.h in building SG_TABLE's for a VRAM BO To: Ramesh Errabolu , amd-gfx@lists.freedesktop.org References: <20210413182607.7367-1-Ramesh.Errabolu@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Wed, 14 Apr 2021 08:45:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210413182607.7367-1-Ramesh.Errabolu@amd.com> Content-Language: en-US X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" QW0gMTMuMDQuMjEgdW0gMjA6MjYgc2NocmllYiBSYW1lc2ggRXJyYWJvbHU6Cj4gRXh0ZW5kIGN1 cnJlbnQgaW1wbGVtZW50YXRpb24gb2YgU0dfVEFCTEUgY29uc3RydWN0aW9uIG1ldGhvZCB0bwo+ IGFsbG93IGV4cG9ydGF0aW9uIG9mIHN1Yi1idWZmZXJzIG9mIGEgVlJBTSBCTy4gVGhpcyBjYXBh YmlsaXR5IHdpbGwKPiBlbmFibGUgbG9naWNhbCBwYXJ0aXRpb25pbmcgb2YgYSBWUkFNIEJPIGlu dG8gbXVsdGlwbGUgbm9uLW92ZXJsYXBwaW5nCj4gc3ViLWJ1ZmZlcnMuIE9uZSBleGFtcGxlIG9m IHRoaXMgdXNlIGNhc2UgaXMgdG8gcGFydGl0aW9uIGEgVlJBTSBCTwo+IGludG8gdHdvIHN1Yi1i dWZmZXJzLCBvbmUgZm9yIFNSQyBhbmQgYW5vdGhlciBmb3IgRFNULgo+Cj4gU2lnbmVkLW9mZi1i eTogUmFtZXNoIEVycmFib2x1IDxSYW1lc2guRXJyYWJvbHVAYW1kLmNvbT4KClJldmlld2VkLWJ5 OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAg ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RtYV9idWYuYyAgfCAgNCArLS0KPiAg IGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uaCAgICAgIHwgIDEgKwo+ICAg ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZyYW1fbWdyLmMgfCAzNCArKysrKysr KysrKysrKy0tLS0tLQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAxMiBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfZG1hX2J1Zi5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RtYV9i dWYuYwo+IGluZGV4IGUwYzRmN2M3ZjFiOS4uYmFhOTgwYTQ3N2Q5IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kbWFfYnVmLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZG1hX2J1Zi5jCj4gQEAgLTI5MSw4ICsyOTEsOCBA QCBzdGF0aWMgc3RydWN0IHNnX3RhYmxlICphbWRncHVfZG1hX2J1Zl9tYXAoc3RydWN0IGRtYV9i dWZfYXR0YWNobWVudCAqYXR0YWNoLAo+ICAgCQlicmVhazsKPiAgIAo+ICAgCWNhc2UgVFRNX1BM X1ZSQU06Cj4gLQkJciA9IGFtZGdwdV92cmFtX21ncl9hbGxvY19zZ3QoYWRldiwgJmJvLT50Ym8u bWVtLCBhdHRhY2gtPmRldiwKPiAtCQkJCQkgICAgICBkaXIsICZzZ3QpOwo+ICsJCXIgPSBhbWRn cHVfdnJhbV9tZ3JfYWxsb2Nfc2d0KGFkZXYsICZiby0+dGJvLm1lbSwgMCwKPiArCQkJCWJvLT50 Ym8uYmFzZS5zaXplLCBhdHRhY2gtPmRldiwgZGlyLCAmc2d0KTsKPiAgIAkJaWYgKHIpCj4gICAJ CQlyZXR1cm4gRVJSX1BUUihyKTsKPiAgIAkJYnJlYWs7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV90dG0uaAo+IGluZGV4IGRlYzBkYjhiMGIxMy4uOWUzODQ3NWUwZjhkIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uaAo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uaAo+IEBAIC0xMTIsNiArMTEy LDcgQEAgaW50IGFtZGdwdV9ndHRfbWdyX3JlY292ZXIoc3RydWN0IHR0bV9yZXNvdXJjZV9tYW5h Z2VyICptYW4pOwo+ICAgdTY0IGFtZGdwdV92cmFtX21ncl9ib192aXNpYmxlX3NpemUoc3RydWN0 IGFtZGdwdV9ibyAqYm8pOwo+ICAgaW50IGFtZGdwdV92cmFtX21ncl9hbGxvY19zZ3Qoc3RydWN0 IGFtZGdwdV9kZXZpY2UgKmFkZXYsCj4gICAJCQkgICAgICBzdHJ1Y3QgdHRtX3Jlc291cmNlICpt ZW0sCj4gKwkJCSAgICAgIHU2NCBvZmZzZXQsIHU2NCBzaXplLAo+ICAgCQkJICAgICAgc3RydWN0 IGRldmljZSAqZGV2LAo+ICAgCQkJICAgICAgZW51bSBkbWFfZGF0YV9kaXJlY3Rpb24gZGlyLAo+ ICAgCQkJICAgICAgc3RydWN0IHNnX3RhYmxlICoqc2d0KTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZyYW1fbWdyLmMgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGdwdS9hbWRncHVfdnJhbV9tZ3IuYwo+IGluZGV4IDU5MmEyZGQxNjQ5My4uYmNlMTA1 ZTI5NzNlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV92 cmFtX21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZyYW1f bWdyLmMKPiBAQCAtMjUsNiArMjUsNyBAQAo+ICAgI2luY2x1ZGUgPGxpbnV4L2RtYS1tYXBwaW5n Lmg+Cj4gICAjaW5jbHVkZSAiYW1kZ3B1LmgiCj4gICAjaW5jbHVkZSAiYW1kZ3B1X3ZtLmgiCj4g KyNpbmNsdWRlICJhbWRncHVfcmVzX2N1cnNvci5oIgo+ICAgI2luY2x1ZGUgImFtZGdwdV9hdG9t ZmlybXdhcmUuaCIKPiAgICNpbmNsdWRlICJhdG9tLmgiCj4gICAKPiBAQCAtNTY1LDYgKzU2Niw4 IEBAIHN0YXRpYyB2b2lkIGFtZGdwdV92cmFtX21ncl9kZWwoc3RydWN0IHR0bV9yZXNvdXJjZV9t YW5hZ2VyICptYW4sCj4gICAgKgo+ICAgICogQGFkZXY6IGFtZGdwdSBkZXZpY2UgcG9pbnRlcgo+ ICAgICogQG1lbTogVFRNIG1lbW9yeSBvYmplY3QKPiArICogQG9mZnNldDogYnl0ZSBvZmZzZXQg ZnJvbSB0aGUgYmFzZSBvZiBWUkFNIEJPCj4gKyAqIEBsZW5ndGg6IG51bWJlciBvZiBieXRlcyB0 byBleHBvcnQgaW4gc2dfdGFibGUKPiAgICAqIEBkZXY6IHRoZSBvdGhlciBkZXZpY2UKPiAgICAq IEBkaXI6IGRtYSBkaXJlY3Rpb24KPiAgICAqIEBzZ3Q6IHJlc3VsdGluZyBzZyB0YWJsZQo+IEBA IC01NzMsMzkgKzU3Niw0NyBAQCBzdGF0aWMgdm9pZCBhbWRncHVfdnJhbV9tZ3JfZGVsKHN0cnVj dCB0dG1fcmVzb3VyY2VfbWFuYWdlciAqbWFuLAo+ICAgICovCj4gICBpbnQgYW1kZ3B1X3ZyYW1f bWdyX2FsbG9jX3NndChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgIAkJCSAgICAgIHN0 cnVjdCB0dG1fcmVzb3VyY2UgKm1lbSwKPiArCQkJICAgICAgdTY0IG9mZnNldCwgdTY0IGxlbmd0 aCwKPiAgIAkJCSAgICAgIHN0cnVjdCBkZXZpY2UgKmRldiwKPiAgIAkJCSAgICAgIGVudW0gZG1h X2RhdGFfZGlyZWN0aW9uIGRpciwKPiAgIAkJCSAgICAgIHN0cnVjdCBzZ190YWJsZSAqKnNndCkK PiAgIHsKPiAtCXN0cnVjdCBkcm1fbW1fbm9kZSAqbm9kZTsKPiArCXN0cnVjdCBhbWRncHVfcmVz X2N1cnNvciBjdXJzb3I7Cj4gICAJc3RydWN0IHNjYXR0ZXJsaXN0ICpzZzsKPiAgIAlpbnQgbnVt X2VudHJpZXMgPSAwOwo+IC0JdW5zaWduZWQgaW50IHBhZ2VzOwo+ICAgCWludCBpLCByOwo+ICAg Cj4gICAJKnNndCA9IGttYWxsb2Moc2l6ZW9mKCoqc2d0KSwgR0ZQX0tFUk5FTCk7Cj4gICAJaWYg KCEqc2d0KQo+ICAgCQlyZXR1cm4gLUVOT01FTTsKPiAgIAo+IC0JZm9yIChwYWdlcyA9IG1lbS0+ bnVtX3BhZ2VzLCBub2RlID0gbWVtLT5tbV9ub2RlOwo+IC0JICAgICBwYWdlczsgcGFnZXMgLT0g bm9kZS0+c2l6ZSwgKytub2RlKQo+IC0JCSsrbnVtX2VudHJpZXM7Cj4gKwkvKiBEZXRlcm1pbmUg dGhlIG51bWJlciBvZiBEUk1fTU0gbm9kZXMgdG8gZXhwb3J0ICovCj4gKwlhbWRncHVfcmVzX2Zp cnN0KG1lbSwgb2Zmc2V0LCBsZW5ndGgsICZjdXJzb3IpOwo+ICsJd2hpbGUgKGN1cnNvci5yZW1h aW5pbmcpIHsKPiArCQludW1fZW50cmllcysrOwo+ICsJCWFtZGdwdV9yZXNfbmV4dCgmY3Vyc29y LCBjdXJzb3Iuc2l6ZSk7Cj4gKwl9Cj4gICAKPiAgIAlyID0gc2dfYWxsb2NfdGFibGUoKnNndCwg bnVtX2VudHJpZXMsIEdGUF9LRVJORUwpOwo+ICAgCWlmIChyKQo+ICAgCQlnb3RvIGVycm9yX2Zy ZWU7Cj4gICAKPiArCS8qIEluaXRpYWxpemUgc2NhdHRlcmxpc3Qgbm9kZXMgb2Ygc2dfdGFibGUg Ki8KPiAgIAlmb3JfZWFjaF9zZ3RhYmxlX3NnKCgqc2d0KSwgc2csIGkpCj4gICAJCXNnLT5sZW5n dGggPSAwOwo+ICAgCj4gLQlub2RlID0gbWVtLT5tbV9ub2RlOwo+ICsJLyoKPiArCSAqIFdhbGsg ZG93biBEUk1fTU0gbm9kZXMgdG8gcG9wdWxhdGUgc2NhdHRlcmxpc3Qgbm9kZXMKPiArCSAqIEBu b3RlOiBVc2UgaXRlcmF0b3IgYXBpIHRvIGdldCBmaXJzdCB0aGUgRFJNX01NIG5vZGUKPiArCSAq IGFuZCB0aGUgbnVtYmVyIG9mIGJ5dGVzIGZyb20gaXQuIEFjY2VzcyB0aGUgZm9sbG93aW5nCj4g KwkgKiBEUk1fTU0gbm9kZShzKSBpZiBtb3JlIGJ1ZmZlciBuZWVkcyB0byBleHBvcnRlZAo+ICsJ ICovCj4gKwlhbWRncHVfcmVzX2ZpcnN0KG1lbSwgb2Zmc2V0LCBsZW5ndGgsICZjdXJzb3IpOwo+ ICAgCWZvcl9lYWNoX3NndGFibGVfc2coKCpzZ3QpLCBzZywgaSkgewo+IC0JCXBoeXNfYWRkcl90 IHBoeXMgPSAobm9kZS0+c3RhcnQgPDwgUEFHRV9TSElGVCkgKwo+IC0JCQlhZGV2LT5nbWMuYXBl cl9iYXNlOwo+IC0JCXNpemVfdCBzaXplID0gbm9kZS0+c2l6ZSA8PCBQQUdFX1NISUZUOwo+ICsJ CXBoeXNfYWRkcl90IHBoeXMgPSBjdXJzb3Iuc3RhcnQgKyBhZGV2LT5nbWMuYXBlcl9iYXNlOwo+ ICsJCXNpemVfdCBzaXplID0gY3Vyc29yLnNpemU7Cj4gICAJCWRtYV9hZGRyX3QgYWRkcjsKPiAg IAo+IC0JCSsrbm9kZTsKPiAgIAkJYWRkciA9IGRtYV9tYXBfcmVzb3VyY2UoZGV2LCBwaHlzLCBz aXplLCBkaXIsCj4gICAJCQkJCURNQV9BVFRSX1NLSVBfQ1BVX1NZTkMpOwo+ICAgCQlyID0gZG1h X21hcHBpbmdfZXJyb3IoZGV2LCBhZGRyKTsKPiBAQCAtNjE1LDcgKzYyNiwxMCBAQCBpbnQgYW1k Z3B1X3ZyYW1fbWdyX2FsbG9jX3NndChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgIAkJ c2dfc2V0X3BhZ2Uoc2csIE5VTEwsIHNpemUsIDApOwo+ICAgCQlzZ19kbWFfYWRkcmVzcyhzZykg PSBhZGRyOwo+ICAgCQlzZ19kbWFfbGVuKHNnKSA9IHNpemU7Cj4gKwo+ICsJCWFtZGdwdV9yZXNf bmV4dCgmY3Vyc29yLCBjdXJzb3Iuc2l6ZSk7Cj4gICAJfQo+ICsKPiAgIAlyZXR1cm4gMDsKPiAg IAo+ICAgZXJyb3JfdW5tYXA6CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n ZngK