From: Vinod Koul <vkoul@kernel.org>
To: "Martin Povišer" <povik+lin@cutebit.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dmaengine: apple-sio: Add Apple SIO driver
Date: Thu, 3 Aug 2023 16:55:43 +0530 [thread overview]
Message-ID: <ZMuOt2THchrNDjDH@matsya> (raw)
In-Reply-To: <7D43A9F3-892C-4E74-9618-DB37360B7641@cutebit.org>
On 01-08-23, 23:55, Martin Povišer wrote:
> > can you use virt_dma_chan, that should simplify list handling etc
>
> I looked into that when I wrote the sister driver apple-admac.c, I don’t
> remember anymore why I decided against it, and I don’t think it came up
> during review. Now that this driver is done, I hope we can take it as is.
>
> There’s some benefit from the drivers having a similar structure, I sent
> one or two fixes to apple-admac for things I found out because I was
> writing this other driver.
And this would be a chance to covert the other one and get rid of list
handling code in that driver as well
>
> >> +};
> >> +
> >> +#define SIO_NTAGS 16
> >> +
> >> +typedef void (*sio_ack_callback)(struct sio_chan *, void *, bool);
> >
> > any reason not to use dmaengine callbacks?
>
> Not sure what dmaengine callback you mean here. This callback means
> the coprocessor acked a tag, not sure how we can fit something dmaengine
> onto it.
Okay lets understand, how is this one used
--
~Vinod
next prev parent reply other threads:[~2023-08-03 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:38 [PATCH 0/2] Apple SIO driver Martin Povišer
2023-07-12 13:38 ` [PATCH 1/2] dt-bindings: dma: apple,sio: Add schema Martin Povišer
2023-07-12 13:38 ` [PATCH 2/2] dmaengine: apple-sio: Add Apple SIO driver Martin Povišer
2023-08-01 18:14 ` Vinod Koul
2023-08-01 21:55 ` Martin Povišer
2023-08-03 8:32 ` Martin Povišer
2023-08-03 11:34 ` Vinod Koul
2023-08-24 15:25 ` Martin Povišer
2023-08-03 11:25 ` Vinod Koul [this message]
2023-08-24 15:34 ` Martin Povišer
2023-07-12 19:42 ` [PATCH 0/2] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMuOt2THchrNDjDH@matsya \
--to=vkoul@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).