ath10k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Carl Huang <cjhuang@codeaurora.org>
To: Abhishek Kumar <kuabhs@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	ath10k <ath10k@lists.infradead.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	kuabhs@google.com
Subject: Re: [PATCH 1/3] nl80211: add common API to configure SAR power limitations.
Date: Fri, 20 Nov 2020 15:01:44 +0800	[thread overview]
Message-ID: <02fee7badc98864c5a51f91604f7a416@codeaurora.org> (raw)
In-Reply-To: <CACTWRwtcd2rdE-JQTh0t=Xwu9Vv-2He2M4wVDXbbiV1FOyNq7g@mail.gmail.com>

On 2020-11-20 04:25, Abhishek Kumar wrote:
> Hi,
> 
> Johannes has some good comments, apart for that I have some nits.
>> > And wait, I thought we agreed to remove the index? Now I'm confused.
>> >
>> Using index in SET operation doesn't add burden to userspace and 
>> kernel,
>> but it provides some flexibility so userspace can skip some certain
>> ranges.
> 
> I agree with Carl's comment, we do need the frequency index. If the
> frequency index is provided, then the order is not important which
> makes the data more clear or the set_sar_spec function needs to parse
> the frequency ranges (and ofcourse userspace has to populate that as
> well). If the frequency index is not provided, then the driver has to
> assume that the userspace is not making any error in mapping of the
> power and desired frequency.
> Other reason is, might be a bit unlikely, but if in future there are
> new subbands, then it gives a flexibility to the userspace to
> explicitly provide the band for which it needs to set the power for.
> 
>> + *     used with %NL80211_CMD_SET_SAR_SPECS. The message contains 
>> fileds
>> + *     of %nl80211_sar_attrs which specifies the sar type and related
> 
> typo: fileds .. you mean fields
> 
I will fix all the spelling errors and send V2.

> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2020-11-20  7:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 10:07 [PATCH 0/3] add common API to configure SAR Carl Huang
2020-11-06 10:07 ` [PATCH 1/3] nl80211: add common API to configure SAR power limitations Carl Huang
2020-11-06 10:25   ` Johannes Berg
2020-11-11  7:44     ` Carl Huang
2020-11-19 20:25       ` Abhishek Kumar
2020-11-20  7:01         ` Carl Huang [this message]
2020-11-06 10:07 ` [PATCH 2/3] mac80211: add ieee80211_set_sar_specs Carl Huang
2020-11-06 10:07 ` [PATCH 3/3] ath10k: allow dynamic SAR power limits via common API Carl Huang
2020-11-19 20:02   ` Abhishek Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02fee7badc98864c5a51f91604f7a416@codeaurora.org \
    --to=cjhuang@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=briannorris@chromium.org \
    --cc=dianders@chromium.org \
    --cc=johannes@sipsolutions.net \
    --cc=kuabhs@chromium.org \
    --cc=kuabhs@google.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).