ath10k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: wireless: ath10k: Use of_device_get_match_data() helper
@ 2022-03-18  2:53 Meng Tang
  2022-03-21 10:49 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Meng Tang @ 2022-03-18  2:53 UTC (permalink / raw)
  To: kvalo, davem; +Cc: ath10k, linux-wireless, netdev, linux-kernel, Meng Tang

Only the device data is needed, not the entire struct of_device_id.
Use of_device_get_match_data() instead of of_match_device().

Signed-off-by: Meng Tang <tangmeng@uniontech.com>
---
 drivers/net/wireless/ath/ath10k/ahb.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c
index ab8f77ae5e66..f0c615fa5614 100644
--- a/drivers/net/wireless/ath/ath10k/ahb.c
+++ b/drivers/net/wireless/ath/ath10k/ahb.c
@@ -728,20 +728,17 @@ static int ath10k_ahb_probe(struct platform_device *pdev)
 	struct ath10k *ar;
 	struct ath10k_ahb *ar_ahb;
 	struct ath10k_pci *ar_pci;
-	const struct of_device_id *of_id;
 	enum ath10k_hw_rev hw_rev;
 	size_t size;
 	int ret;
 	struct ath10k_bus_params bus_params = {};
 
-	of_id = of_match_device(ath10k_ahb_of_match, &pdev->dev);
-	if (!of_id) {
-		dev_err(&pdev->dev, "failed to find matching device tree id\n");
+	hw_rev = (enum ath10k_hw_rev)of_device_get_match_data(&pdev->dev);
+	if (!hw_rev) {
+		dev_err(&pdev->dev, "OF data missing\n");
 		return -EINVAL;
 	}
 
-	hw_rev = (enum ath10k_hw_rev)of_id->data;
-
 	size = sizeof(*ar_pci) + sizeof(*ar_ahb);
 	ar = ath10k_core_create(size, &pdev->dev, ATH10K_BUS_AHB,
 				hw_rev, &ath10k_ahb_hif_ops);
-- 
2.20.1




_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: wireless: ath10k: Use of_device_get_match_data() helper
  2022-03-18  2:53 [PATCH] net: wireless: ath10k: Use of_device_get_match_data() helper Meng Tang
@ 2022-03-21 10:49 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-03-21 10:49 UTC (permalink / raw)
  To: Meng Tang; +Cc: davem, ath10k, linux-wireless, netdev, linux-kernel, Meng Tang

Meng Tang <tangmeng@uniontech.com> wrote:

> Only the device data is needed, not the entire struct of_device_id.
> Use of_device_get_match_data() instead of of_match_device().
> 
> Signed-off-by: Meng Tang <tangmeng@uniontech.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

c4e9705c5012 ath10k: Use of_device_get_match_data() helper

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220318025331.23030-1-tangmeng@uniontech.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-21 10:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-18  2:53 [PATCH] net: wireless: ath10k: Use of_device_get_match_data() helper Meng Tang
2022-03-21 10:49 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).