From: Kalle Valo <kvalo@kernel.org>
To: Alexander Wetzel <alexander@wetzel-home.de>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Alexander Wetzel" <alexander@wetzel-home.de>,
"Felix Fietkau" <nbd@nbd.name>,
stable@vger.kernel.org
Subject: Re: [PATCH] wifi: ath10k: Serialize wake_tx_queue ops
Date: Fri, 5 May 2023 13:01:34 +0000 (UTC) [thread overview]
Message-ID: <168329168628.4336.2281740515872835038.kvalo@kernel.org> (raw)
In-Reply-To: <20230323165527.156414-1-alexander@wetzel-home.de>
Alexander Wetzel <alexander@wetzel-home.de> wrote:
> Serialize the ath10k implementation of the wake_tx_queue ops.
> ath10k_mac_op_wake_tx_queue() must not run concurrent since it's using
> ieee80211_txq_schedule_start().
>
> The intend of this patch is to sort out an issue discovered in the discussion
> referred to by the Link tag.
>
> I can't test it with real hardware and thus just implemented the per-ac queue
> lock Felix suggested. One obvious alternative to the per-ac lock would be to
> bring back the txqs_lock commit bb2edb733586 ("ath10k: migrate to mac80211 txq
> scheduling") dropped.
>
> Fixes: bb2edb733586 ("ath10k: migrate to mac80211 txq scheduling")
> Reported-by: Felix Fietkau <nbd@nbd.name>
> Link: https://lore.kernel.org/r/519b5bb9-8899-ae7c-4eff-f3116cdfdb56@nbd.name
> CC: <stable@vger.kernel.org>
> Signed-off-by: Alexander Wetzel <alexander@wetzel-home.de>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
b719ebc37a1e wifi: ath10k: Serialize wake_tx_queue ops
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230323165527.156414-1-alexander@wetzel-home.de/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2023-05-05 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:55 [PATCH] wifi: ath10k: Serialize wake_tx_queue ops Alexander Wetzel
2023-05-05 13:01 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168329168628.4336.2281740515872835038.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=alexander@wetzel-home.de \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=stable@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).