From: Markus Theil <markus.theil@tu-ilmenau.de>
To: Robert Marko <robert.marko@sartura.hr>, ath10k@lists.infradead.org
Cc: Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH] ath10k: enable advertising support for channels 32, 68 and 98
Date: Thu, 11 Jun 2020 13:29:07 +0200 [thread overview]
Message-ID: <1f5bab38-4c77-6858-ed02-f52c71ee11fe@tu-ilmenau.de> (raw)
In-Reply-To: <20200327093147.189390-1-robert.marko@sartura.hr>
On 3/27/20 10:31 AM, Robert Marko wrote:
> Enable advertising support for 5G channels: 32, 68 and 96.
> These channels are legal and available for use in ETSI countries.
> So lets advertise these and they will be available in accordance with the regulatory domain used.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> ---
> drivers/net/wireless/ath/ath10k/core.h | 2 +-
> drivers/net/wireless/ath/ath10k/mac.c | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 5101bf2b5b15..480efaa1278c 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -37,7 +37,7 @@
> #define WMI_READY_TIMEOUT (5 * HZ)
> #define ATH10K_FLUSH_TIMEOUT_HZ (5 * HZ)
> #define ATH10K_CONNECTION_LOSS_HZ (3 * HZ)
> -#define ATH10K_NUM_CHANS 41
> +#define ATH10K_NUM_CHANS 44
> #define ATH10K_MAX_5G_CHAN 173
>
> /* Antenna noise floor */
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 7fee35ff966b..f98422427b27 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -8363,6 +8363,7 @@ static const struct ieee80211_channel ath10k_2ghz_channels[] = {
> };
>
> static const struct ieee80211_channel ath10k_5ghz_channels[] = {
> + CHAN5G(32, 5160, 0),
> CHAN5G(36, 5180, 0),
> CHAN5G(40, 5200, 0),
> CHAN5G(44, 5220, 0),
> @@ -8371,6 +8372,8 @@ static const struct ieee80211_channel ath10k_5ghz_channels[] = {
> CHAN5G(56, 5280, 0),
> CHAN5G(60, 5300, 0),
> CHAN5G(64, 5320, 0),
> + CHAN5G(68, 5340, 0),
> + CHAN5G(96, 5480, 0),
> CHAN5G(100, 5500, 0),
> CHAN5G(104, 5520, 0),
> CHAN5G(108, 5540, 0),
Hi, your patch is incomplete. Mgmt frames cannot be received on channel 32, because of the following lines in wmi.c:
/* Hardware can Rx CCK rates on 5GHz. In that case phy_mode is set to
* MODE_11B. This means phy_mode is not a reliable source for the band
* of mgmt rx.
*/
if (channel >= 1 && channel <= 14) {
status->band = NL80211_BAND_2GHZ;
} else if (channel >= 36 && channel <= ATH10K_MAX_5G_CHAN) {
status->band = NL80211_BAND_5GHZ;
} else {
/* Shouldn't happen unless list of advertised channels to
* mac80211 has been changed.
*/
WARN_ON_ONCE(1);
dev_kfree_skb(skb);
return 0;
}
Have you tested this patch?
Markus
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-06-11 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 9:31 [PATCH] ath10k: enable advertising support for channels 32, 68 and 98 Robert Marko
2020-06-04 12:07 ` Robert Marko
2020-06-09 11:57 ` Kalle Valo
2020-06-10 12:18 ` Robert Marko
2020-06-11 11:29 ` Markus Theil [this message]
2020-06-11 12:05 ` Markus Theil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f5bab38-4c77-6858-ed02-f52c71ee11fe@tu-ilmenau.de \
--to=markus.theil@tu-ilmenau.de \
--cc=ath10k@lists.infradead.org \
--cc=luka.perkov@sartura.hr \
--cc=robert.marko@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).