From: "Alvin Šipraga" <alsi@bang-olufsen.dk>
To: ath10k@lists.infradead.org
Cc: "Luis R . Rodriguez" <mcgrof@kernel.org>,
"Wen Gong" <wgong@codeaurora.org>,
linux-wireless@vger.kernel.org,
"Alvin Šipraga" <alsi@bang-olufsen.dk>
Subject: [PATCH] Revert "ath: add support for special 0x0 regulatory domain"
Date: Thu, 30 Jul 2020 14:49:23 +0200 [thread overview]
Message-ID: <20200730124923.271429-1-alsi@bang-olufsen.dk> (raw)
This reverts commit 2dc016599cfa9672a147528ca26d70c3654a5423.
Per Atheros documentation to manufacturers, the EEPROM regulatory domain
code 0x0 must always map to "US". In particular, it should not map to a
custom world regulatory domain. For references, see [1] and [2] below.
Furthermore, __ath_regd_init() has a specific condition to set the
country code to "US" in this case, which emits the following log
message:
[ 7.814307] ath: EEPROM indicates default country code should be used
The patch being reverted mistakenly maps 0x0 to the custom world
regulatory domain 0x64 - the most restrictive of the world regulatory
domains. The premise of the patch is that in the case of EEPROM
regulatory domain code 0x0, ath_is_world_regd() should return true. But,
as stated above, 0x0 should not map to a world regulatory domain, and so
the function should return false. The original behaviour, whereby
NL80211_REGDOM_SET_BY_COUNTRY_IE is ignored, was correct according to
the manufacturer's intent and should not have been changed.
[1] https://wireless.wiki.kernel.org/en/users/drivers/ath#the_0x0_regulatory_domain
[2] http://article.gmane.org/gmane.linux.kernel.wireless.general/38410
Fixes: 2dc016599cfa ("ath: add support for special 0x0 regulatory domain")
Cc: Wen Gong <wgong@codeaurora.org>
Cc: Luis R. Rodriguez <mcgrof@kernel.org>
Cc: linux-wireless@vger.kernel.org
Tested-on: QCA9880 hw2.0 PCI 10.2.4-1.0-00047
Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
---
drivers/net/wireless/ath/regd.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/regd.c b/drivers/net/wireless/ath/regd.c
index bee9110b91f3..20f4f8ea9f89 100644
--- a/drivers/net/wireless/ath/regd.c
+++ b/drivers/net/wireless/ath/regd.c
@@ -666,14 +666,14 @@ ath_regd_init_wiphy(struct ath_regulatory *reg,
/*
* Some users have reported their EEPROM programmed with
- * 0x8000 or 0x0 set, this is not a supported regulatory
- * domain but since we have more than one user with it we
- * need a solution for them. We default to 0x64, which is
- * the default Atheros world regulatory domain.
+ * 0x8000 set, this is not a supported regulatory domain
+ * but since we have more than one user with it we need
+ * a solution for them. We default to 0x64, which is the
+ * default Atheros world regulatory domain.
*/
static void ath_regd_sanitize(struct ath_regulatory *reg)
{
- if (reg->current_rd != COUNTRY_ERD_FLAG && reg->current_rd != 0)
+ if (reg->current_rd != COUNTRY_ERD_FLAG)
return;
printk(KERN_DEBUG "ath: EEPROM regdomain sanitized\n");
reg->current_rd = 0x64;
--
2.27.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next reply other threads:[~2020-07-30 12:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 12:49 Alvin Šipraga [this message]
2020-08-27 7:59 ` [PATCH] Revert "ath: add support for special 0x0 regulatory domain" Alvin Šipraga
2020-08-27 10:12 ` Kalle Valo
2020-08-27 10:25 ` Alvin Šipraga
-- strict thread matches above, loose matches on Subject: below --
2020-12-21 12:15 sparks71
2020-10-22 17:21 Félix Sipma
[not found] ` <CANe27jKpYm29QOjYOZ_jwHiRxuWx66J+th8-zgbXK4geiCU0_Q@mail.gmail.com>
2020-10-29 14:06 ` Félix Sipma
2020-10-30 7:20 ` Jouni Malinen
2020-10-30 8:51 ` Félix Sipma
2020-12-20 1:32 ` Julian Phillips
2020-10-30 13:23 ` Alvin Sipraga
2020-12-21 13:43 ` sparks71
2020-05-27 16:57 Brian Norris
2020-05-28 12:02 ` Julian Calaby
[not found] ` <CAJ-Vmomx0UFEa1w2HsGMQsZb+K8hyK=Zz9cKSo7tHv5GiMc1yw@mail.gmail.com>
2020-06-02 18:35 ` Brian Norris
2022-03-07 17:45 ` Kalle Valo
2022-04-23 10:52 ` Patrick Steinhardt
2022-04-25 18:54 ` Brian Norris
2022-05-09 18:16 ` Cale Collins
2022-05-11 22:52 ` Cale Collins
2022-08-30 21:56 ` Brian Norris
2022-09-19 17:24 ` Tim Harvey
2022-09-19 23:42 ` Sergey Ryazanov
2022-09-20 5:42 ` Sebastian Gottschall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730124923.271429-1-alsi@bang-olufsen.dk \
--to=alsi@bang-olufsen.dk \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).