ath10k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: kbuild-all@lists.01.org, ath10k@lists.infradead.org
Subject: [ath6kl:ath11k-qca6390-bringup 11/27] drivers/net/wireless/ath/ath11k/qmi.c:1680:46: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'}
Date: Mon, 14 Dec 2020 20:09:38 +0800	[thread overview]
Message-ID: <202012142035.0lurHH0z-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4857 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-qca6390-bringup
head:   60fad49a69e7b2f896ce7b1ade4ed532227b8e22
commit: 7d4892f101fc6bcd3cecbdfc7419a4a2bf6bb58b [11/27] ath11k: qmi: print allocated memory segment addresses and sizes
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=7d4892f101fc6bcd3cecbdfc7419a4a2bf6bb58b
        git remote add ath6kl https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git
        git fetch --no-tags ath6kl ath11k-qca6390-bringup
        git checkout 7d4892f101fc6bcd3cecbdfc7419a4a2bf6bb58b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/wireless/ath/ath11k/qmi.c: In function 'ath11k_qmi_respond_fw_mem_request':
>> drivers/net/wireless/ath/ath11k/qmi.c:1680:46: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
    1680 |    ath11k_info(ab, "qmi req mem_seg[%d] 0x%llx %u %u\n", i,
         |                                           ~~~^
         |                                              |
         |                                              long long unsigned int
         |                                           %x
    1681 |         ab->qmi.target_mem[i].paddr,
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~           
         |                              |
         |                              dma_addr_t {aka unsigned int}

vim +1680 drivers/net/wireless/ath/ath11k/qmi.c

  1648	
  1649	static int ath11k_qmi_respond_fw_mem_request(struct ath11k_base *ab)
  1650	{
  1651		struct qmi_wlanfw_respond_mem_req_msg_v01 *req;
  1652		struct qmi_wlanfw_respond_mem_resp_msg_v01 resp;
  1653		struct qmi_txn txn = {};
  1654		int ret = 0, i;
  1655		bool delayed = false;
  1656	
  1657		req = kzalloc(sizeof(*req), GFP_KERNEL);
  1658		if (!req)
  1659			return -ENOMEM;
  1660	
  1661		memset(&resp, 0, sizeof(resp));
  1662	
  1663		/* For QCA6390 by default FW requests a block of ~4M contiguous
  1664		 * DMA memory, it's hard to allocate from OS. So host returns
  1665		 * failure to FW and FW will then request mulitple blocks of small
  1666		 * chunk size memory.
  1667		 */
  1668		if (!ab->bus_params.fixed_mem_region && ab->qmi.target_mem_delayed) {
  1669			delayed = true;
  1670			ath11k_dbg(ab, ATH11K_DBG_QMI, "qmi delays mem_request %d\n",
  1671				   ab->qmi.mem_seg_count);
  1672			memset(req, 0, sizeof(*req));
  1673		} else {
  1674			req->mem_seg_len = ab->qmi.mem_seg_count;
  1675	
  1676			for (i = 0; i < req->mem_seg_len ; i++) {
  1677				req->mem_seg[i].addr = ab->qmi.target_mem[i].paddr;
  1678				req->mem_seg[i].size = ab->qmi.target_mem[i].size;
  1679				req->mem_seg[i].type = ab->qmi.target_mem[i].type;
> 1680				ath11k_info(ab, "qmi req mem_seg[%d] 0x%llx %u %u\n", i,
  1681					    ab->qmi.target_mem[i].paddr,
  1682					    ab->qmi.target_mem[i].size,
  1683					    ab->qmi.target_mem[i].type);
  1684			}
  1685		}
  1686	
  1687		ret = qmi_txn_init(&ab->qmi.handle, &txn,
  1688				   qmi_wlanfw_respond_mem_resp_msg_v01_ei, &resp);
  1689		if (ret < 0)
  1690			goto out;
  1691	
  1692		ret = qmi_send_request(&ab->qmi.handle, NULL, &txn,
  1693				       QMI_WLANFW_RESPOND_MEM_REQ_V01,
  1694				       QMI_WLANFW_RESPOND_MEM_REQ_MSG_V01_MAX_LEN,
  1695				       qmi_wlanfw_respond_mem_req_msg_v01_ei, req);
  1696		if (ret < 0) {
  1697			ath11k_warn(ab, "qmi failed to respond memory request, err = %d\n",
  1698				    ret);
  1699			goto out;
  1700		}
  1701	
  1702		ret = qmi_txn_wait(&txn, msecs_to_jiffies(ATH11K_QMI_WLANFW_TIMEOUT_MS));
  1703		if (ret < 0) {
  1704			ath11k_warn(ab, "qmi failed memory request, err = %d\n", ret);
  1705			goto out;
  1706		}
  1707	
  1708		if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
  1709			/* the error response is expected when
  1710			 * target_mem_delayed is true.
  1711			 */
  1712			if (delayed && resp.resp.error == 0)
  1713				goto out;
  1714	
  1715			ath11k_warn(ab, "Respond mem req failed, result: %d, err: %d\n",
  1716				    resp.resp.result, resp.resp.error);
  1717			ret = -EINVAL;
  1718		}
  1719	out:
  1720		kfree(req);
  1721		return ret;
  1722	}
  1723	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58171 bytes --]

[-- Attachment #3: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

                 reply	other threads:[~2020-12-14 12:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202012142035.0lurHH0z-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kvalo@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).