From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 246A6C433DB for ; Tue, 9 Feb 2021 07:19:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEF3564EC2 for ; Tue, 9 Feb 2021 07:18:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEF3564EC2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Date:Message-Id:To:References:In-Reply-To:From: Subject:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lOOgKRFoTA4z/+524o8iv52wSSjh3j+ouPvH0Y7SLsw=; b=nK0OEi0fGdP+9G15ynbT1tr80 YKGmsr6T8v9rpMJlfvoIj2Mpgyh0PlhgyCpx24wArzhMDvPjeVUseZ1Sl0ujOOLftNg5FtGXl0iJS pieAEyc/Oi/MLn4iZ1cpP6MCqz4t2GgKXq6STQgPIiv1hqgs9pwzTOOCK5nHuHHVqEHn3Wlof50sb VgXz2BzvhqS6do1tWs3jVeShdhDtsVSbWK+LJdQ8vlgzIgJJCL0kFOfOcU0z4WfTqC9qiCVLfJ2YI +8jTBrIE7nxLLfN3ToYh6sQhbneYkyQprSxX5ShkomxRtbD9D+4qa4cTT0EyhOWC8VtmCOp5yrLvp 3PQfU8DHg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9NI6-00026b-4A; Tue, 09 Feb 2021 07:18:30 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9NHy-00020V-M3 for ath10k@lists.infradead.org; Tue, 09 Feb 2021 07:18:26 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612855105; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=Tz8B3SKK8X3XicV4RNnbjFdYo4FlBMTms7jwtNxn2o0=; b=ftWosMadoSLPZRDlZYXDT95SmgOFuhXCGKbrvTFXSo97/z7hpLjE/RmWOE/To07h1ZZOdM/l 4dcqm0khMslfv/cq7qhezBn55FtSWrlHgSAuzwoSKwZ8aG0r4NXuznEwArlr1/xc0jLw85oT HQS9d9d9tez7UQltPDRY29YA0w0= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiZDQ3OSIsICJhdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 6022373af112b7872cb9d255 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 09 Feb 2021 07:18:18 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3B9C8C433ED; Tue, 9 Feb 2021 07:18:18 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5A89CC433CA; Tue, 9 Feb 2021 07:18:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5A89CC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org MIME-Version: 1.0 Subject: Re: [PATCH] ath10k: Fix lockdep assertion warning in ath10k_sta_statistics From: Kalle Valo In-Reply-To: <20210202144033.1.I9e556f9fb1110d58c31d04a8a1293995fb8bb678@changeid> References: <20210202144033.1.I9e556f9fb1110d58c31d04a8a1293995fb8bb678@changeid> To: Anand K Mistry User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210209071818.3B9C8C433ED@smtp.codeaurora.org> Date: Tue, 9 Feb 2021 07:18:18 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210209_021825_665616_2C71CC00 X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anand K Mistry , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Wen Gong , Jakub Kicinski , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org Anand K Mistry wrote: > ath10k_debug_fw_stats_request just be called with conf_mutex held, > otherwise the following warning is seen when lock debugging is enabled: > > WARNING: CPU: 0 PID: 793 at drivers/net/wireless/ath/ath10k/debug.c:357 ath10k_debug_fw_stats_request+0x12c/0x133 [ath10k_core] > Modules linked in: snd_hda_codec_hdmi designware_i2s snd_hda_intel snd_intel_dspcfg snd_hda_codec i2c_piix4 snd_hwdep snd_hda_core acpi_als kfifo_buf industrialio snd_soc_max98357a snd_soc_adau7002 snd_soc_acp_da7219mx98357_mach snd_soc_da7219 acp_audio_dma ccm xt_MASQUERADE fuse ath10k_pci ath10k_core lzo_rle ath lzo_compress mac80211 zram cfg80211 r8152 mii joydev > CPU: 0 PID: 793 Comm: wpa_supplicant Tainted: G W 5.10.9 #5 > Hardware name: HP Grunt/Grunt, BIOS Google_Grunt.11031.104.0 09/05/2019 > RIP: 0010:ath10k_debug_fw_stats_request+0x12c/0x133 [ath10k_core] > Code: 1e bb a1 ff ff ff 4c 89 ef 48 c7 c6 d3 31 2e c0 89 da 31 c0 e8 bd f8 ff ff 89 d8 eb 02 31 c0 5b 41 5c 41 5d 41 5e 41 5f 5d c3 <0f> 0b e9 04 ff ff ff 0f 1f 44 00 00 55 48 89 e5 41 56 53 48 89 fb > RSP: 0018:ffffb2478099f7d0 EFLAGS: 00010246 > RAX: 0000000000000000 RBX: ffff9e432700cce0 RCX: 11c85cfd6b8e3b00 > RDX: ffff9e432700cce0 RSI: ffff9e43127c5668 RDI: ffff9e4318deddf0 > RBP: ffffb2478099f7f8 R08: 0000000000000002 R09: 00000003fd7068cc > R10: ffffffffc01b2749 R11: ffffffffc029efaf R12: ffff9e432700c000 > R13: ffff9e43127c33e0 R14: ffffb2478099f918 R15: ffff9e43127c33e0 > FS: 00007f7ea48e2740(0000) GS:ffff9e432aa00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 000059aa799ddf38 CR3: 0000000118de2000 CR4: 00000000001506f0 > Call Trace: > ath10k_sta_statistics+0x4d/0x270 [ath10k_core] > sta_set_sinfo+0x1be/0xaec [mac80211] > ieee80211_get_station+0x58/0x76 [mac80211] > rdev_get_station+0xf1/0x11e [cfg80211] > nl80211_get_station+0x7f/0x146 [cfg80211] > genl_rcv_msg+0x32e/0x35e > ? nl80211_stop_ap+0x19/0x19 [cfg80211] > ? nl80211_get_station+0x146/0x146 [cfg80211] > ? genl_rcv+0x19/0x36 > ? genl_rcv+0x36/0x36 > netlink_rcv_skb+0x89/0xfb > genl_rcv+0x28/0x36 > netlink_unicast+0x169/0x23b > netlink_sendmsg+0x38a/0x402 > sock_sendmsg+0x72/0x76 > ____sys_sendmsg+0x153/0x1cc > ? copy_msghdr_from_user+0x5d/0x85 > ___sys_sendmsg+0x7c/0xb5 > ? lock_acquire+0x181/0x23d > ? syscall_trace_enter+0x15e/0x160 > ? find_held_lock+0x3d/0xb2 > ? syscall_trace_enter+0x15e/0x160 > ? sched_clock_cpu+0x15/0xc6 > __sys_sendmsg+0x62/0x9a > do_syscall_64+0x43/0x55 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > Fixes: 4913e675630e ("ath10k: enable rx duration report default for wmi tlv") > Signed-off-by: Anand K Mistry > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 7df28718928d ath10k: Fix lockdep assertion warning in ath10k_sta_statistics -- https://patchwork.kernel.org/project/linux-wireless/patch/20210202144033.1.I9e556f9fb1110d58c31d04a8a1293995fb8bb678@changeid/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k