From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC16C433E0 for ; Wed, 10 Feb 2021 08:09:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2827264DF5 for ; Wed, 10 Feb 2021 08:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2827264DF5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Date:Message-Id:To:References:In-Reply-To:From: Subject:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CNtRzSaCm8CgRoGTf+pm7cz5iqkJC7IempOLBD4GrWY=; b=s5z5+G7WpeRcoLbKWnrkln1Q4 FRW21380Z8MN0xYEGxFdlSE7B3V/LWhVTbOlieG9cZx1LbwECNR9SS5x2nkEKluEudh70zg/nTOwL DhzfqVfXdPt3iINx2npNHufYjRbXDWb4IicXt/4j3xeExlAls9m0xswgD4lkGwhbRoQC16p4NQEX1 w/RENT/Pj5p557aSC0jAYGDjoIxFZZ3s6r2/PQBUL1uZTwz+xpWptJktEQKxkTXoI1nz+EWEYbylm 5cW5MqeIrX0P0A1KbBp6c2HicAUuSTZXRgk0wxhn6v2PTNyI4s61CagFiMKKfUZedCSlvGZaUbtXL aG+w6h95A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9kYs-0001en-E6; Wed, 10 Feb 2021 08:09:22 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9kYo-0001dV-RR for ath10k@lists.infradead.org; Wed, 10 Feb 2021 08:09:21 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612944559; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=o7FD7RpIDEZnMLd+c9217BURghIrG/C2huZYnnOqH8g=; b=R4aaMpe2R2ozyxp6YkWar2qDNgpgEnSk6VolBi3c03CGsw6L3UQ86yf3avWvTdLUifJWc45k RCWV8HlhiFTJClJ5s84EMgU8LVh4d+8W6hVuhmEBI5vnJt5sYRd5YnfbmSkaALtdkCIDfUAX Wt+QirxW26EkjdYfZKzUA9hybAw= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiZDQ3OSIsICJhdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 602394ab34db06ef79e5ceb2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 10 Feb 2021 08:09:15 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 92586C433ED; Wed, 10 Feb 2021 08:09:15 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8C5C4C433C6; Wed, 10 Feb 2021 08:09:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8C5C4C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org MIME-Version: 1.0 Subject: Re: [PATCH 1/5] ath10k: fix conf_mutex lock assert in ath10k_debug_fw_stats_request() From: Kalle Valo In-Reply-To: <1c38ef6d39ed89a564bc817d964d923ff0676c53.1612915444.git.skhan@linuxfoundation.org> References: <1c38ef6d39ed89a564bc817d964d923ff0676c53.1612915444.git.skhan@linuxfoundation.org> To: Shuah Khan User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20210210080915.92586C433ED@smtp.codeaurora.org> Date: Wed, 10 Feb 2021 08:09:15 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_030919_966179_226F6331 X-CRM114-Status: UNSURE ( 9.94 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Shuah Khan , kuba@kernel.org, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org Shuah Khan wrote: > ath10k_debug_fw_stats_request() is called ath10k_sta_statistics() > without holding conf_mutex. ath10k_debug_fw_stats_request() simply > returns when CONFIG_ATH10K_DEBUGFS is disabled. > > When CONFIG_ATH10K_DEBUGFS is enabled, ath10k_debug_fw_stats_request() > code path isn't protected. This assert is triggered when CONFIG_LOCKDEP > and CONFIG_ATH10K_DEBUGFS are enabled. > > All other ath10k_debug_fw_stats_request() callers hold conf_mutex. > Fix ath10k_sta_statistics() to do the same. > > WARNING: CPU: 5 PID: 696 at drivers/net/wireless/ath/ath10k/debug.c:357 ath10k_debug_fw_stats_request+0x29a/0x2d0 [ath10k_core] > Modules linked in: rfcomm ccm fuse cmac algif_hash algif_skcipher af_alg bnep binfmt_misc nls_iso8859_1 intel_rapl_msr intel_rapl_common snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio snd_hda_codec_hdmi snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hda_core snd_hwdep snd_pcm amdgpu snd_seq_midi snd_seq_midi_event snd_rawmidi edac_mce_amd snd_seq ath10k_pci ath10k_core aesni_intel gpu_sched drm_ttm_helper btusb ttm glue_helper crypto_simd btrtl ath cryptd drm_kms_helper snd_seq_device btbcm snd_timer rapl btintel cec i2c_algo_bit mac80211 bluetooth fb_sys_fops input_leds ecdh_generic snd wmi_bmof syscopyarea ecc serio_raw efi_pstore ccp k10temp sysfillrect soundcore sysimgblt snd_pci_acp3x cfg80211 ipmi_devintf libarc4 ipmi_msghandler mac_hid sch_fq_codel parport_pc ppdev lp parport drm ip_tables x_tables autofs4 hid_generic usbhid hid crc32_pclmul psmouse ahci nvme libahci i2c_piix4 nvme_core r8169 realtek wmi video > CPU: 5 PID: 696 Comm: NetworkManager Tainted: G W 5.11.0-rc7+ #20 > Hardware name: LENOVO 10VGCTO1WW/3130, BIOS M1XKT45A 08/21/2019 > RIP: 0010:ath10k_debug_fw_stats_request+0x29a/0x2d0 [ath10k_core] > Code: 83 c4 10 44 89 f8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 48 8d bf e8 20 00 00 be ff ff ff ff e8 de 2d 47 fa 85 c0 0f 85 8d fd ff ff <0f> 0b e9 86 fd ff ff 41 bf a1 ff ff ff 44 89 fa 48 c7 c6 2c 71 c4 > RSP: 0018:ffffaffbc124b7d0 EFLAGS: 00010246 > RAX: 0000000000000000 RBX: ffff93d02e4fec70 RCX: 0000000000000001 > RDX: 0000000000000000 RSI: ffff93d00cba5248 RDI: ffff93d00ab309a0 > RBP: ffffaffbc124b808 R08: 0000000000000000 R09: ffff93d02e4fec70 > R10: 0000000000000001 R11: 0000000000000246 R12: ffff93d00cba3160 > R13: ffff93d00cba3160 R14: ffff93d02e4fe4f0 R15: 0000000000000001 > FS: 00007f7ce8d50bc0(0000) GS:ffff93d137d40000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007fc3595ad160 CR3: 000000010d492000 CR4: 00000000003506e0 > Call Trace: > ? sta_info_get_bss+0xeb/0x1f0 [mac80211] > ath10k_sta_statistics+0x4f/0x280 [ath10k_core] > sta_set_sinfo+0xda/0xd20 [mac80211] > ieee80211_get_station+0x58/0x80 [mac80211] > nl80211_get_station+0xbd/0x340 [cfg80211] > genl_family_rcv_msg_doit+0xe7/0x150 > genl_rcv_msg+0xe2/0x1e0 > ? nl80211_dump_station+0x3a0/0x3a0 [cfg80211] > ? nl80211_send_station+0xef0/0xef0 [cfg80211] > ? genl_get_cmd+0xd0/0xd0 > netlink_rcv_skb+0x55/0x100 > genl_rcv+0x29/0x40 > netlink_unicast+0x1a8/0x270 > netlink_sendmsg+0x253/0x480 > sock_sendmsg+0x65/0x70 > ____sys_sendmsg+0x219/0x260 > ? __import_iovec+0x32/0x170 > ___sys_sendmsg+0xb7/0x100 > ? end_opal_session+0x39/0xd0 > ? __fget_files+0xe0/0x1d0 > ? find_held_lock+0x31/0x90 > ? __fget_files+0xe0/0x1d0 > ? __fget_files+0x103/0x1d0 > ? __fget_light+0x32/0x80 > __sys_sendmsg+0x5a/0xa0 > ? syscall_enter_from_user_mode+0x21/0x60 > __x64_sys_sendmsg+0x1f/0x30 > do_syscall_64+0x38/0x50 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > RIP: 0033:0x7f7cea2c791d > Code: 28 89 54 24 1c 48 89 74 24 10 89 7c 24 08 e8 4a ee ff ff 8b 54 24 1c 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 2e 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 33 44 89 c7 48 89 44 24 08 e8 9e ee ff ff 48 > RSP: 002b:00007ffedf612a30 EFLAGS: 00000293 ORIG_RAX: 000000000000002e > RAX: ffffffffffffffda RBX: 00005618c4cfec00 RCX: 00007f7cea2c791d > RDX: 0000000000000000 RSI: 00007ffedf612a80 RDI: 000000000000000b > RBP: 00007ffedf612a80 R08: 0000000000000000 R09: 00005618c4e74000 > R10: 00005618c4da0590 R11: 0000000000000293 R12: 00005618c4cfec00 > R13: 00005618c4cfe2c0 R14: 00007f7cea32ef80 R15: 00005618c4cff340 > irq event stamp: 520897 > hardirqs last enabled at (520903): [] console_unlock+0x4e5/0x5d0 > hardirqs last disabled at (520908): [] console_unlock+0x458/0x5d0 > softirqs last enabled at (520722): [] asm_call_irq_on_stack+0x12/0x20 > softirqs last disabled at (520717): [] asm_call_irq_on_stack+0x12/0x20 > > Signed-off-by: Shuah Khan Bad timing, just yesterday I applied an identical patch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=7df28718928d08034b36168200d67b558ce36f3d Patch set to Superseded. -- https://patchwork.kernel.org/project/linux-wireless/patch/1c38ef6d39ed89a564bc817d964d923ff0676c53.1612915444.git.skhan@linuxfoundation.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k