From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
wgong@codeaurora.org
Subject: Re: [PATCH] ath10k: restore tx sk_buff of htt header for SDIO
Date: Thu, 11 Feb 2021 06:48:19 +0000 (UTC) [thread overview]
Message-ID: <20210211064819.BE9EBC433CA@smtp.codeaurora.org> (raw)
In-Reply-To: <1612839530-2263-1-git-send-email-wgong@codeaurora.org>
Wen Gong <wgong@codeaurora.org> wrote:
> ieee80211_report_used_skb of mac80211 use the frame_control of
> ieee80211_hdr in sk_buff and indicate it to another function
> ieee80211_mgd_conn_tx_status, then it queue work ieee80211_sta_work,
> but ieee80211_is_auth(fc) in ieee80211_sta_work check fail when the
> authentication has transmitted by ath10k.
>
> When the ath10k report it with HTT_TX_COMPL_STATE_DISCARD, it will be
> set without flag IEEE80211_TX_STAT_ACK, then mac80211 should try the
> next authentication immeditely, but in fact mac80211 wait 1 second for
> it, the reason is ieee80211_is_auth(fc) in ieee80211_sta_work check
> fail for the sk_buff which is not restored, the data of sk_buff is not
> the begin of ieee80211_hdr, in fact it is the begin of htt_cmd_hdr.
>
> dmesg without this patch, it wait 1 second for the next retry when
> ath10k report without IEEE80211_TX_STAT_ACK for authentication:
> [ 6973.883116] wlan0: send auth to 5e:6f:2b:0d:fb:d7 (try 1/3)
> [ 6974.705471] wlan0: send auth to 5e:6f:2b:0d:fb:d7 (try 2/3)
> [ 6975.712962] wlan0: send auth to 5e:6f:2b:0d:fb:d7 (try 3/3)
>
> Restore the sk_buff make mac8011 retry the next authentication
> immeditely which meet logic of mac80211.
>
> dmesg with this patch, it retry the next immeditely when ath10k
> report without IEEE80211_TX_STAT_ACK for authentication:
> [ 216.734813] wlan0: send auth to 5e:6f:2b:0d:fb:d7 (try 1/3)
> [ 216.739914] wlan0: send auth to 5e:6f:2b:0d:fb:d7 (try 2/3)
> [ 216.745874] wlan0: send auth to 5e:6f:2b:0d:fb:d7 (try 3/3)
>
> Tested-on: QCA6174 hw3.2 SDIO WLAN.RMH.4.4.1-00049
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
e6f1c0d26a31 ath10k: restore tx sk_buff of htt header for SDIO
--
https://patchwork.kernel.org/project/linux-wireless/patch/1612839530-2263-1-git-send-email-wgong@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2021-02-11 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 2:58 [PATCH] ath10k: restore tx sk_buff of htt header for SDIO Wen Gong
2021-02-11 6:48 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211064819.BE9EBC433CA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).