From: Simon Wunderlich <sw@simonwunderlich.de>
To: Zefir Kurtisi <zefir.kurtisi@neratec.com>
Cc: Julian Calaby <julian.calaby@gmail.com>,
linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
ath10k@lists.infradead.org, Ben Greear <greearb@candelatech.com>,
Mathias Kretschmer <mathias.kretschmer@fit.fraunhofer.de>
Subject: Re: [PATCH 1/3] ath9k: Support channels in licensed bands
Date: Fri, 17 Mar 2017 15:02:05 +0100 [thread overview]
Message-ID: <2318695.ItlGDV16mL@prime> (raw)
In-Reply-To: <096bcee2-a991-eac1-8f4f-d7cf7c34730d@neratec.com>
[-- Attachment #1.1: Type: text/plain, Size: 799 bytes --]
On Friday, March 17, 2017 2:40:50 PM CET Zefir Kurtisi wrote:
> On 03/16/2017 04:13 PM, Simon Wunderlich wrote:
> > @@ -126,10 +142,14 @@ int ath9k_cmn_init_channels_rates(struct ath_common
> > *common)>
> > {
> >
> > struct ath_hw *ah = (struct ath_hw *)common->ah;
> > void *channels;
> >
> > + int num_5ghz_chan = ARRAY_SIZE(ath9k_5ghz_chantable);
> > +
> > + if (!IS_ENABLED(CONFIG_ATH9K_LICENSED_CHAN))
> > + num_5ghz_chan -= ATH9K_NUM_LICENSED_CHANNELS;
>
> These two lines seem wrong to me, since the extra channels are only added to
> the list if CONFIG_ATH9K_LICENSED_CHAN is defined. If it is not, this cuts
> off the last 7 regular channels, no?
Oh, I think you are right!
I'll revise this part and re-send. Seems I can just get rid of those two lines
...
Cheers,
Simon
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-03-17 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 15:13 [PATCH 0/3] Channels in licensed bands, noise floor override Simon Wunderlich
2017-03-16 15:13 ` [PATCH 1/3] ath9k: Support channels in licensed bands Simon Wunderlich
2017-03-17 13:40 ` Zefir Kurtisi
2017-03-17 14:02 ` Simon Wunderlich [this message]
2017-03-17 16:00 ` [PATCHv2 " Simon Wunderlich
2017-03-16 15:13 ` [PATCH 2/3] ath10k: add support for " Simon Wunderlich
2017-03-17 18:49 ` Sebastian Gottschall
2017-03-23 9:00 ` Simon Wunderlich
2017-03-16 15:13 ` [PATCH 3/3] ath9k: add noise floor override option Simon Wunderlich
2017-03-17 8:48 ` Janusz Dziedzic
2017-03-17 8:55 ` Simon Wunderlich
2017-03-17 12:44 ` Janusz Dziedzic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2318695.ItlGDV16mL@prime \
--to=sw@simonwunderlich.de \
--cc=ath10k@lists.infradead.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=greearb@candelatech.com \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fit.fraunhofer.de \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).