From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35B09C7EE30 for ; Fri, 3 Mar 2023 21:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:CC:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i2IX/kf9IB6+wr4v0qniairtrGZ9eVLV0nbE3urDt/4=; b=UBwNqecHxVeoZG Et4A6sPkfR/5aVvRxAfkF93ehM3mpgpHKdW7D7BgPj+xOK4z1TC5pKcpO9FpM4FV3Ol5oJ2DTEZOe C7wKM4eOhTiRD21uU9nEeXM9y3dOohY2HrpCwgth6VOxhiUrYoG7Treu5svP/OSK8iLNeb66wVuCC BW3Xm/PoHzieRmB/eCscYBAKEo7KBDXFCQ8J6HyB/Lp7f85fi1za0ww93w5DwLRzxDJSu7tFSrAVr mMs6HedOE+iayOrI7jXz1O7taCoX1t8Bv/PKRnvYw5NIoqfGsaDnOre4JlTdvKJiqchJ7bNSGe9my oRAyCTiGcGjTOhP2OcVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYCen-007RL6-CX; Fri, 03 Mar 2023 21:09:37 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYCeh-007RIh-Ha for ath10k@lists.infradead.org; Fri, 03 Mar 2023 21:09:33 +0000 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 323Hw71Q027393; Fri, 3 Mar 2023 21:09:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : from : subject : to : cc : references : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=0GV0GIblVbFArHNpmZ1Srz0Rk2Sez5YtbO96Shw/C94=; b=K3GuB/c67HB+9X5scaPeKggDaitwzAl87gNnC3C2vueKKu5ykHfKheQhr1xKU/22aTAG 2+qjLzzrcdUMfHDrMM8J2lxHIyVHw3312cEHlYqeO4nzKWp0jVnGkb3wsqgDTsz83U2S nuBYJpzVB0bP0JlKacrywW+IItuotYBNMh/5qrIlH2w3bzY3RVFj2YEo71ZnLw2D5cs0 kiHUZjliGhYkEWITN3YHvZZeHW/E9PUMeEH2Yv/bx3TZjK2WeuMe2bZZma6hvZxrc/Ta tyt1/AmHVAK43H2/wqZIiWRyYD0i8xWBH4KecTVsak0SRfxB0QClW+YoH0gbO2hx0Rh5 zQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3p3dpxj579-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Mar 2023 21:09:11 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 323L9ALS015416 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 3 Mar 2023 21:09:10 GMT Received: from [10.110.20.90] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 3 Mar 2023 13:09:09 -0800 Message-ID: <2ae96b75-82f1-165a-e56d-7446c90bb7af@quicinc.com> Date: Fri, 3 Mar 2023 13:09:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 From: Elliot Berman Subject: Re: [PATCH] firmware: qcom_scm: Use fixed width src vm bitmap To: Bjorn Andersson , Greg Kroah-Hartman CC: Andy Gross , Konrad Dybcio , Srinivas Kandagatla , Amol Maheshwari , Arnd Bergmann , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mathieu Poirier , "Gokul krishna Krishnakumar" , , , , , , References: <20230213181832.3489174-1-quic_eberman@quicinc.com> <20230213214417.mtcpeultvynyls6s@ripper> <20230214172325.lplxgbprhj3bzvr3@ripper> Content-Language: en-US In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: fFgsdjU-gZTIeIOv6LUxDDseAdoa3PuQ X-Proofpoint-GUID: fFgsdjU-gZTIeIOv6LUxDDseAdoa3PuQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-03_05,2023-03-03_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 mlxlogscore=999 clxscore=1011 priorityscore=1501 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303030177 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_130931_750970_912E4FB0 X-CRM114-Status: GOOD ( 20.56 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org On 2/14/2023 10:52 AM, Elliot Berman wrote: > > > On 2/14/2023 9:23 AM, Bjorn Andersson wrote: >> On Tue, Feb 14, 2023 at 09:58:44AM +0100, Greg Kroah-Hartman wrote: >>> On Mon, Feb 13, 2023 at 01:44:17PM -0800, Bjorn Andersson wrote: >>>> On Mon, Feb 13, 2023 at 10:18:29AM -0800, Elliot Berman wrote: >>>>> The maximum VMID for assign_mem is 63. Use a u64 to represent this >>>>> bitmap instead of architecture-dependent "unsigned int" which >>>>> varies in >>>>> size on 32-bit and 64-bit platforms. >>>>> >>>>> Acked-by: Kalle Valo (ath10k) >>>>> Tested-by: Gokul krishna Krishnakumar >>>>> Signed-off-by: Elliot Berman >>>> >>>> Reviewed-by: Bjorn Andersson >>>> >>>> @Greg, would you mind taking this through your tree for v6.3, you >>>> already have a related change in fastrpc.c in your tree... >>> >>> I tried, but it doesn't apply to my char-misc tree at all: >>> >>> checking file drivers/firmware/qcom_scm.c >>> Hunk #1 succeeded at 898 (offset -7 lines). >>> Hunk #2 succeeded at 915 (offset -7 lines). >>> Hunk #3 succeeded at 930 (offset -7 lines). >>> checking file drivers/misc/fastrpc.c >>> checking file drivers/net/wireless/ath/ath10k/qmi.c >>> checking file drivers/remoteproc/qcom_q6v5_mss.c >>> Hunk #1 succeeded at 227 (offset -8 lines). >>> Hunk #2 succeeded at 404 (offset -10 lines). >>> Hunk #3 succeeded at 939 with fuzz 1 (offset -28 lines). >>> checking file drivers/remoteproc/qcom_q6v5_pas.c >>> Hunk #1 FAILED at 94. >>> 1 out of 1 hunk FAILED >>> checking file drivers/soc/qcom/rmtfs_mem.c >>> Hunk #1 succeeded at 30 (offset -1 lines). >>> can't find file to patch at input line 167 >>> Perhaps you used the wrong -p or --strip option? >>> The text leading up to this was: >>> -------------------------- >>> |diff --git a/include/linux/firmware/qcom/qcom_scm.h >>> b/include/linux/firmware/qcom/qcom_scm.h >>> |index 1e449a5d7f5c..250ea4efb7cb 100644 >>> |--- a/include/linux/firmware/qcom/qcom_scm.h >>> |+++ b/include/linux/firmware/qcom/qcom_scm.h >>> -------------------------- >>> >>> What tree is this patch made against? >>> >> >> Sorry about that, I missed the previous changes in qcom_q6v5_pas in the >> remoteproc tree. Elliot said he based it on linux-next, so I expect that >> it will merge fine on top of -rc1, once that arrives. >> > > Yes, this patch applies on next-20230213. I guess there are enough > changes were coming from QCOM side (via Bjorn's qcom tree) as well as > the fastrpc change (via Greg's char-misc tree). > > Let me know if I should do anything once -rc1 arrives. Happy to post > version on the -rc1 if it helps. > The patch now applies on tip of Linus's tree and on char-misc. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k