ath10k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "sparks71@gmx.de" <sparks71@gmx.de>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ojab // <ojab@ojab.ru>, "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	ath10k@lists.infradead.org,
	Linux Wireless <linux-wireless@vger.kernel.org>,
	netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] ath10k: don't fail if IRAM write fails
Date: Tue, 21 Sep 2021 09:50:29 +0200	[thread overview]
Message-ID: <4656706a-a87d-1bf6-d125-b66af57157ca@gmx.de> (raw)
In-Reply-To: <87wnnav129.fsf@codeaurora.org>

Am 21.09.21 um 09:29 schrieb Kalle Valo:
> "sparks71@gmx.de" <sparks71@gmx.de> writes:
>
>> Have you seen the new patch?
>>
>> https://www.mail-archive.com/ath10k@lists.infradead.org/msg13784.html
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=master-pending&id=973de582639a1e45276e4e3e2f3c2d82a04ad0a6
>>
>>
>> could probably have been communicated better
> Yeah, apparently there are two different fixes now. I'll review both of
> them and try to choose which one to take.
>
I have tested both fixes (x86_64 2x QCA9984)

For me both of them work.

[PATCH V2] ath10k: don't fail if IRAM write fails:


[18245.610112] ath10k_pci 0000:03:00.0: pci irq msi oper_irq_mode 2
irq_mode 0 reset_mode 0
[18245.674800] ath10k_pci 0000:04:00.0: pci irq msi oper_irq_mode 2
irq_mode 0 reset_mode 0
[18245.731606] ath10k_pci 0000:03:00.0: qca9984/qca9994 hw1.0 target
0x01000000 chip_id 0x00000000 sub 168c:cafe
[18245.731620] ath10k_pci 0000:03:00.0: kconfig debug 0 debugfs 1
tracing 1 dfs 0 testmode 0
[18245.733172] ath10k_pci 0000:03:00.0: firmware ver 10.4-3.9.0.2-00152
api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps,peer-fixed-rate,iram-recovery
crc32 723f9771
[18245.790380] ath10k_pci 0000:04:00.0: qca9984/qca9994 hw1.0 target
0x01000000 chip_id 0x00000000 sub 168c:cafe
[18245.790383] ath10k_pci 0000:04:00.0: kconfig debug 0 debugfs 1
tracing 1 dfs 0 testmode 0
[18245.790703] ath10k_pci 0000:04:00.0: firmware ver 10.4-3.9.0.2-00152
api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps,peer-fixed-rate,iram-recovery
crc32 723f9771
[18246.963760] ath10k_pci 0000:03:00.0: board_file api 2 bmi_id 0:1
crc32 85498734
[18247.019699] ath10k_pci 0000:04:00.0: board_file api 2 bmi_id 0:2
crc32 85498734
[18249.514054] ath10k_pci 0000:03:00.0: No hardware memory
[18249.514057] ath10k_pci 0000:03:00.0: failed to copy target iram
contents: -12
[18249.570423] ath10k_pci 0000:04:00.0: No hardware memory
[18249.570426] ath10k_pci 0000:04:00.0: failed to copy target iram
contents: -12
[18249.620637] ath10k_pci 0000:03:00.0: htt-ver 2.2 wmi-op 6 htt-op 4
cal otp max-sta 512 raw 0 hwcrypto 1
[18249.678035] ath10k_pci 0000:04:00.0: htt-ver 2.2 wmi-op 6 htt-op 4
cal otp max-sta 512 raw 0 hwcrypto 1


ath10k: Fix device boot error:

[    3.318932] ath10k_pci 0000:03:00.0: pci irq msi oper_irq_mode 2
irq_mode 0 reset_mode 0
[    3.377071] ath10k_pci 0000:04:00.0: pci irq msi oper_irq_mode 2
irq_mode 0 reset_mode 0
[    3.434051] ath10k_pci 0000:03:00.0: qca9984/qca9994 hw1.0 target
0x01000000 chip_id 0x00000000 sub 168c:cafe
[    3.434054] ath10k_pci 0000:03:00.0: kconfig debug 0 debugfs 1
tracing 1 dfs 0 testmode 0
[    3.434412] ath10k_pci 0000:03:00.0: firmware ver 10.4-3.9.0.2-00152
api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps,peer-fixed-rate,iram-recovery
crc32 723f9771
[    3.487225] ath10k_pci 0000:04:00.0: qca9984/qca9994 hw1.0 target
0x01000000 chip_id 0x00000000 sub 168c:cafe
[    3.487229] ath10k_pci 0000:04:00.0: kconfig debug 0 debugfs 1
tracing 1 dfs 0 testmode 0
[    3.487568] ath10k_pci 0000:04:00.0: firmware ver 10.4-3.9.0.2-00152
api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps,peer-fixed-rate,iram-recovery
crc32 723f9771
[    4.665772] ath10k_pci 0000:03:00.0: board_file api 2 bmi_id 0:1
crc32 85498734
[    4.716549] ath10k_pci 0000:04:00.0: board_file api 2 bmi_id 0:2
crc32 85498734
[    7.423192] ath10k_pci 0000:04:00.0: htt-ver 2.2 wmi-op 6 htt-op 4
cal otp max-sta 512 raw 0 hwcrypto 1
[    7.443109] ath10k_pci 0000:03:00.0: htt-ver 2.2 wmi-op 6 htt-op 4
cal otp max-sta 512 raw 0 hwcrypto 1

the second fixes the error message completely and "IRAM recovery" seems
to work

best regards




_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2021-09-21  7:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 19:35 [PATCH V2] ath10k: don't fail if IRAM write fails ojab
2021-07-22 19:42 ` ojab //
2021-08-02  2:23   ` Axel Rasmussen
2021-08-12 20:21     ` Axel Rasmussen
2021-08-14 11:33       ` sparks71
2021-08-25 16:15 ` ojab //
2021-09-08 23:42   ` ojab //
2021-09-17 19:30     ` ojab //
2021-09-18 10:12       ` sparks71
2021-09-18 11:21         ` ojab //
2021-09-21  7:29         ` Kalle Valo
2021-09-21  7:50           ` sparks71 [this message]
2021-10-20  7:54 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4656706a-a87d-1bf6-d125-b66af57157ca@gmx.de \
    --to=sparks71@gmx.de \
    --cc=ath10k@lists.infradead.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ojab@ojab.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).