From: Thomas Pedersen <thomas@adapt-ip.com>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org, ath10k <ath10k@lists.infradead.org>
Subject: Re: RX rate is wrong in 5.10? (bisected to: mac80211: receive and process S1G beacons)
Date: Mon, 04 Jan 2021 16:25:00 -0800 [thread overview]
Message-ID: <772a3a0517eb4d4cc6cee975e5fde100@adapt-ip.com> (raw)
In-Reply-To: <5dc86950-1672-6900-dad4-3b437f4959c5@candelatech.com>
Hi Ben,
On 2021-01-04 16:18, Ben Greear wrote:
> On 1/4/21 8:18 AM, Ben Greear wrote:
>> Hello,
>>
>> I noticed that RX rate is always 6Mbps when I use -ct firmware and -ct
>> driver in
>> 5.10, and on stock 5.10.0 driver and stock firmware, rx-rate does not
>> show up at
>> all in 'iw dev wlan1 station dump'.
>>
>> I'm using 9984 NIC...
>>
>> Anyone else see this?
>
> After a bisect, the first bad commit shows this:
>
> commit 09a740ce352e1a1d16b9984115514ba9a4f4704b (refs/bisect/bad)
> Author: Thomas Pedersen <thomas@adapt-ip.com>
> Date: Mon Sep 21 19:28:14 2020 -0700
>
> mac80211: receive and process S1G beacons
>
> S1G beacons are 802.11 Extension Frames, so the fixed
> header part differs from regular beacons.
>
> Add a handler to process S1G beacons and abstract out the
> fetching of BSSID and element start locations in the
> beacon body handler.
>
> Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
> Link:
> https://lore.kernel.org/r/20200922022818.15855-14-thomas@adapt-ip.com
> [don't rename, small coding style cleanups]
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>
> From a glance through the diff, I'm at a loss as to why it causes the
> symptom. I manually
> double-checked the bisect, an it appears correct.
>
> What I see is that in the commit before this, I see a useful rx rate
> (1.3Gbps for instance)
> in 'iw dev wlan1 station dump', but in this bad commit, both show
> 6Mbps rate. (Tx rate
> in ath10k is probably broken for other reasons, so I only bisected the
> rx side issue.)
>
> I'm using ath10k 9984 radio with firmware 10.4-3.9.0.2-00070 in station
> mode.
>
> AP is an ath11k Hawkeye...
>
> I'm using a 1Mbps UDP packet 'download' stream to make sure I'm seeing
> rates for data frames
> and not just management frames.
Sorry about that.
> Any idea what might be the issue?
It may be fixed by
https://patchwork.kernel.org/project/linux-wireless/patch/1607483189-3891-1-git-send-email-wgong@codeaurora.org/
--
thomas
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2021-01-05 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 16:18 RX rate is wrong in 5.10? Ben Greear
2021-01-05 0:18 ` RX rate is wrong in 5.10? (bisected to: mac80211: receive and process S1G beacons) Ben Greear
2021-01-05 0:25 ` Thomas Pedersen [this message]
2021-01-05 1:01 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=772a3a0517eb4d4cc6cee975e5fde100@adapt-ip.com \
--to=thomas@adapt-ip.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).