From: Kalle Valo <kvalo@codeaurora.org>
To: Rakesh Pillai <pillair@codeaurora.org>
Cc: 'Abhishek Kumar' <kuabhs@chromium.org>,
'Brian Norris' <briannorris@chromium.org>,
'linux-wireless' <linux-wireless@vger.kernel.org>,
'Doug Anderson' <dianders@chromium.org>,
'ath10k' <ath10k@lists.infradead.org>,
'LKML' <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ath10k: Fix the parsing error in service available event
Date: Fri, 06 Nov 2020 09:16:45 +0200 [thread overview]
Message-ID: <878sbflztu.fsf@codeaurora.org> (raw)
In-Reply-To: <003801d6ad41$a1bb8970$e5329c50$@codeaurora.org> (Rakesh Pillai's message of "Wed, 28 Oct 2020 21:17:19 +0530")
"Rakesh Pillai" <pillair@codeaurora.org> writes:
>> > diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> > index 932266d..3b49e29 100644
>> > --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> > +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c
>> > @@ -1404,9 +1404,12 @@ static int ath10k_wmi_tlv_svc_avail_parse(struct
>> ath10k *ar, u16 tag, u16 len,
>> > arg->service_map_ext_len = *(__le32 *)ptr;
>> > arg->service_map_ext = ptr + sizeof(__le32);
>> > return 0;
>> > + case WMI_TLV_TAG_FIRST_ARRAY_ENUM:
>> > + return 0;
>>
>> This is at least slightly worrying to me. If I were calling this
>> function, I'd expect that if I didn't get back an error that at least
>> "arg->service_map_ext_len" was filled in. Seems like you should do:
>>
>> case WMI_TLV_TAG_FIRST_ARRAY_ENUM:
>> arg->service_map_ext_len = 0;
>> arg->service_map_ext = NULL;
>> return 0;
>>
>> ...and maybe add a comment about why you're doing that?
>>
>> At the moment things are working OK because
>> ath10k_wmi_event_service_available() happens to init the structure to
>> 0 before calling with:
>>
>> struct wmi_svc_avail_ev_arg arg = {};
>>
>> ....but it doesn't seem like a great idea to rely on that.
>>
>> That all being said, I'm just a drive-by reviewer and if everyone else
>> likes it the way it is, feel free to ignore my comments.
>
>
> The TLV TAG " WMI_TLV_TAG_STRUCT_SERVICE_AVAILABLE_EVENT" is the first
> and a mandatory TLV in the service available event. The subsequent
> TLVs are optional ones and may or may not be present (based on FW
> versions).
From ath10k point of view never trust what the firmware sends you. Even
if WMI_TLV_TAG_STRUCT_SERVICE_AVAILABLE_EVENT is a mandatory TLV it
might be missing for whatever reasons. The same is with buffer lengths
etc and always confirm what you are receiving from the firmware.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2020-11-06 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 15:04 [PATCH] ath10k: Fix the parsing error in service available event Rakesh Pillai
2020-10-28 14:37 ` Doug Anderson
2020-10-28 15:47 ` Rakesh Pillai
2020-10-28 16:02 ` Doug Anderson
2020-10-28 16:41 ` Rakesh Pillai
2020-11-06 7:16 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sbflztu.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=kuabhs@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).