* [PATCHv4] ath10k : Fix channel survey dump
@ 2020-05-07 3:03 Venkateswara Naralasetty
2020-05-17 2:25 ` John Deere
2020-05-17 2:26 ` John Deere
0 siblings, 2 replies; 5+ messages in thread
From: Venkateswara Naralasetty @ 2020-05-07 3:03 UTC (permalink / raw)
To: ath10k; +Cc: Venkateswara Naralasetty, linux-wireless
Channel active/busy time are showing incorrect(less than previous or
sometimes zero) for successive survey dump command.
example:
Survey data from wlan0
frequency: 5180 MHz [in use]
channel active time: 54995 ms
channel busy time: 432 ms
channel receive time: 0 ms
channel transmit time: 59 ms
Survey data from wlan0
frequency: 5180 MHz [in use]
channel active time: 32592 ms
channel busy time: 254 ms
channel receive time: 0 ms
channel transmit time: 0 ms
This patch fix this issue by assigning 'wmi_bss_survey_req_type'
as 'WMI_BSS_SURVEY_REQ_TYPE_READ' which accumulate survey data in
FW and send survey data to driver upon the driver request. Wrap around
is taken care by FW.
hardware used : QCA9984
firmware ver : ver 10.4-3.5.3-00057
hardware used : QCA988X
firmware ver : 10.2.4-1.0-00047
Tested-by: Markus Theil <markus.theil@tu-ilmenau.de>
Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
---
v4:
* updated signed-off-by
v3:
* Rebased on TOT and added Tested-by
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index a1147cc..9330b52 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -7275,7 +7275,7 @@ ath10k_mac_update_bss_chan_survey(struct ath10k *ar,
struct ieee80211_channel *channel)
{
int ret;
- enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
+ enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
lockdep_assert_held(&ar->conf_mutex);
--
2.7.4
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCHv4] ath10k : Fix channel survey dump
2020-05-07 3:03 [PATCHv4] ath10k : Fix channel survey dump Venkateswara Naralasetty
@ 2020-05-17 2:25 ` John Deere
2020-05-17 2:26 ` John Deere
1 sibling, 0 replies; 5+ messages in thread
From: John Deere @ 2020-05-17 2:25 UTC (permalink / raw)
To: Venkateswara Naralasetty, ath10k; +Cc: linux-wireless
On 5/7/20 11:03 AM, Venkateswara Naralasetty wrote:
> Channel active/busy time are showing incorrect(less than previous or
> sometimes zero) for successive survey dump command.
>
> example:
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 54995 ms
> channel busy time: 432 ms
> channel receive time: 0 ms
> channel transmit time: 59 ms
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 32592 ms
> channel busy time: 254 ms
> channel receive time: 0 ms
> channel transmit time: 0 ms
>
> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
> as 'WMI_BSS_SURVEY_REQ_TYPE_READ' which accumulate survey data in
> FW and send survey data to driver upon the driver request. Wrap around
> is taken care by FW.
>
> hardware used : QCA9984
> firmware ver : ver 10.4-3.5.3-00057
>
> hardware used : QCA988X
> firmware ver : 10.2.4-1.0-00047
>
> Tested-by: Markus Theil <markus.theil@tu-ilmenau.de>
> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
> ---
> v4:
> * updated signed-off-by
>
> v3:
> * Rebased on TOT and added Tested-by
>
> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index a1147cc..9330b52 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -7275,7 +7275,7 @@ ath10k_mac_update_bss_chan_survey(struct ath10k *ar,
> struct ieee80211_channel *channel)
> {
> int ret;
> - enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
> + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
>
> lockdep_assert_held(&ar->conf_mutex);
>
>
I have tested this on a QCA9980 device on a TP-Link Archer A7v5 with the
firmware version 10.2.4.70.70.
[root@Archer-A7v5 ~]# uptime
10:18:40 up 7 days, 3:52, load average: 0.03, 0.01, 0.00
It has been working fine:
Survey data from wlan0
frequency: 5240 MHz [in use]
noise: -101 dBm
channel active time: 593724580 ms
channel busy time: 9706985 ms
channel receive time: 2053580 ms
channel transmit time: 6473058 ms
Tested-by: John Deere <24601deerej@gmail.com>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv4] ath10k : Fix channel survey dump
2020-05-07 3:03 [PATCHv4] ath10k : Fix channel survey dump Venkateswara Naralasetty
2020-05-17 2:25 ` John Deere
@ 2020-05-17 2:26 ` John Deere
2020-05-20 6:48 ` Markus Theil
1 sibling, 1 reply; 5+ messages in thread
From: John Deere @ 2020-05-17 2:26 UTC (permalink / raw)
To: Venkateswara Naralasetty, ath10k; +Cc: linux-wireless
On 5/7/20 11:03 AM, Venkateswara Naralasetty wrote:
> Channel active/busy time are showing incorrect(less than previous or
> sometimes zero) for successive survey dump command.
>
> example:
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 54995 ms
> channel busy time: 432 ms
> channel receive time: 0 ms
> channel transmit time: 59 ms
> Survey data from wlan0
> frequency: 5180 MHz [in use]
> channel active time: 32592 ms
> channel busy time: 254 ms
> channel receive time: 0 ms
> channel transmit time: 0 ms
>
> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
> as 'WMI_BSS_SURVEY_REQ_TYPE_READ' which accumulate survey data in
> FW and send survey data to driver upon the driver request. Wrap around
> is taken care by FW.
>
> hardware used : QCA9984
> firmware ver : ver 10.4-3.5.3-00057
>
> hardware used : QCA988X
> firmware ver : 10.2.4-1.0-00047
>
> Tested-by: Markus Theil <markus.theil@tu-ilmenau.de>
> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
> ---
> v4:
> * updated signed-off-by
>
> v3:
> * Rebased on TOT and added Tested-by
>
> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index a1147cc..9330b52 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -7275,7 +7275,7 @@ ath10k_mac_update_bss_chan_survey(struct ath10k *ar,
> struct ieee80211_channel *channel)
> {
> int ret;
> - enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
> + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
>
> lockdep_assert_held(&ar->conf_mutex);
>
>
I have tested this on a QCA9980 device on a TP-Link Archer A7v5 with the
firmware version 10.2.4.70.70.
[root@Archer-A7v5 ~]# uptime
10:18:40 up 7 days, 3:52, load average: 0.03, 0.01, 0.00
It has been working fine:
Survey data from wlan0
frequency: 5240 MHz [in use]
noise: -101 dBm
channel active time: 593724580 ms
channel busy time: 9706985 ms
channel receive time: 2053580 ms
channel transmit time: 6473058 ms
Tested-by: John Deere <24601deerej@gmail.com>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv4] ath10k : Fix channel survey dump
2020-05-17 2:26 ` John Deere
@ 2020-05-20 6:48 ` Markus Theil
2020-05-20 13:56 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Markus Theil @ 2020-05-20 6:48 UTC (permalink / raw)
To: John Deere, Venkateswara Naralasetty, ath10k, Kalle Valo; +Cc: linux-wireless
I've seen this patch got dropped again from the ath.git pending branch.
On which hw/firmware combination did it fail to operate?
On 5/17/20 4:26 AM, John Deere wrote:
>
> On 5/7/20 11:03 AM, Venkateswara Naralasetty wrote:
>> Channel active/busy time are showing incorrect(less than previous or
>> sometimes zero) for successive survey dump command.
>>
>> example:
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 54995 ms
>> channel busy time: 432 ms
>> channel receive time: 0 ms
>> channel transmit time: 59 ms
>> Survey data from wlan0
>> frequency: 5180 MHz [in use]
>> channel active time: 32592 ms
>> channel busy time: 254 ms
>> channel receive time: 0 ms
>> channel transmit time: 0 ms
>>
>> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
>> as 'WMI_BSS_SURVEY_REQ_TYPE_READ' which accumulate survey data in
>> FW and send survey data to driver upon the driver request. Wrap around
>> is taken care by FW.
>>
>> hardware used : QCA9984
>> firmware ver : ver 10.4-3.5.3-00057
>>
>> hardware used : QCA988X
>> firmware ver : 10.2.4-1.0-00047
>>
>> Tested-by: Markus Theil <markus.theil@tu-ilmenau.de>
>> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
>> ---
>> v4:
>> * updated signed-off-by
>>
>> v3:
>> * Rebased on TOT and added Tested-by
>>
>> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c
>> b/drivers/net/wireless/ath/ath10k/mac.c
>> index a1147cc..9330b52 100644
>> --- a/drivers/net/wireless/ath/ath10k/mac.c
>> +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> @@ -7275,7 +7275,7 @@ ath10k_mac_update_bss_chan_survey(struct ath10k
>> *ar,
>> struct ieee80211_channel *channel)
>> {
>> int ret;
>> - enum wmi_bss_survey_req_type type =
>> WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;
>> + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ;
>> lockdep_assert_held(&ar->conf_mutex);
>>
>
>
> I have tested this on a QCA9980 device on a TP-Link Archer A7v5 with
> the firmware version 10.2.4.70.70.
>
> [root@Archer-A7v5 ~]# uptime
> 10:18:40 up 7 days, 3:52, load average: 0.03, 0.01, 0.00
>
>
> It has been working fine:
>
> Survey data from wlan0
> frequency: 5240 MHz [in use]
> noise: -101 dBm
> channel active time: 593724580 ms
> channel busy time: 9706985 ms
> channel receive time: 2053580 ms
> channel transmit time: 6473058 ms
>
> Tested-by: John Deere <24601deerej@gmail.com>
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
--
Markus Theil
Technische Universität Ilmenau, Fachgebiet Telematik/Rechnernetze
Postfach 100565
98684 Ilmenau, Germany
Phone: +49 3677 69-4582
Email: markus[dot]theil[at]tu-ilmenau[dot]de
Web: http://www.tu-ilmenau.de/telematik
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv4] ath10k : Fix channel survey dump
2020-05-20 6:48 ` Markus Theil
@ 2020-05-20 13:56 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2020-05-20 13:56 UTC (permalink / raw)
To: Markus Theil; +Cc: Venkateswara Naralasetty, linux-wireless, ath10k, John Deere
Markus Theil <markus.theil@tu-ilmenau.de> writes:
> I've seen this patch got dropped again from the ath.git pending branch.
> On which hw/firmware combination did it fail to operate?
It's deferred at the moment:
https://patchwork.kernel.org/patch/11532357/
The conclusion from the other thread was not clear for me, so I put it
into deferred and will take a closer look once I have time.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-20 13:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 3:03 [PATCHv4] ath10k : Fix channel survey dump Venkateswara Naralasetty
2020-05-17 2:25 ` John Deere
2020-05-17 2:26 ` John Deere
2020-05-20 6:48 ` Markus Theil
2020-05-20 13:56 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).