From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7C43C433F5 for ; Wed, 24 Nov 2021 07:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cOty4/dCKjEsVnMpHHTBFRsTg/dtH5pPnOncMCEQUV0=; b=xY/Az+qvtd7q7D dv5pL+4lusj1d8qIwsMgsxjC4aToCzL2uuWkRuhzu6j26TLk1DzO7/F+Rayr0pQDq9tz7dLr6D9m7 +ZBQok5GRCRUMBfbuCtw+eh4ipi5CWbzn6SB/op9Ke1i5Sz+kg4ouHAS6xl0QkUU5XD2iWBCDCj1l 6H0IQvb2fnjP4RLKcB8nWn8Xu6s1VxjfIEi/yFCTVvagGKpITlozuIq1kpx7LCticJURO0UB148bn B/NcpcfyEKiNdtW1Gqti+vmNtiRtERMLBVCJZzO6QGFXOp+gfNacr4T2kRHYAenTGS2aI0UVzDkcL Rv7OdJTTGkaqRBMS4jJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpmz8-004A9k-SZ; Wed, 24 Nov 2021 07:46:30 +0000 Received: from so254-9.mailgun.net ([198.61.254.9]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpmz5-004A98-Jo for ath10k@lists.infradead.org; Wed, 24 Nov 2021 07:46:29 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1637739985; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=tJQORLqe0Yurb6+bG9qvYorNXDfQLQsIDeVyDCBW9ho=; b=BGu/HGcFaiTvb3s1PApJx6NNVSYttkV7OnG+pIkxdVTC+oD3mUE5aqBWzUcqYn8QydjC8dyJ QQ1uBTuRaybczHHc9u8UTu201bylf5BfWEQtL9vsYMD4xXJknOQss4EfCcfTpGKRmcRCPzWG /ELhcJrEMfmOxdM2ZL9aBvmDGvY= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJiZDQ3OSIsICJhdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 619dedd05daaeec79751953f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 24 Nov 2021 07:46:24 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 74746C43618; Wed, 24 Nov 2021 07:46:24 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8FACAC4338F; Wed, 24 Nov 2021 07:46:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 8FACAC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org From: Kalle Valo To: Fabio Estevam Cc: Fabio Estevam , Wen Gong , ath10k@lists.infradead.org, linux-wireless , erik.stromdahl@gmail.com, alagusankar@silex-india.com Subject: Re: [PATCH] ath10k: Clean the HI_ACS_FLAGS_ALT_DATA_CREDIT_SIZE flag References: <20210915160422.2839595-1-festevam@denx.de> Date: Wed, 24 Nov 2021 09:46:19 +0200 In-Reply-To: (Fabio Estevam's message of "Wed, 24 Nov 2021 00:26:32 -0300") Message-ID: <87ilwi6lo4.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211123_234627_748943_95610BA6 X-CRM114-Status: GOOD ( 24.39 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org Fabio Estevam writes: > Hi Kalle, > > On Mon, Nov 15, 2021 at 3:06 PM Fabio Estevam wrote: >> >> Hi Kalle, >> >> On Wed, Sep 15, 2021 at 1:05 PM Fabio Estevam wrote: >> > >> > On an imx6dl-pico-pi board with a QCA9377 SDIO chip, the following >> > errors are observed when the board works in STA mode: >> > >> > Simply running "ssh user@192.168.0.1" causes: >> > >> > [ 55.824159] ath10k_sdio mmc1:0001:1: failed to transmit packet, dropping: -12 >> > [ 55.832169] ath10k_sdio mmc1:0001:1: failed to submit frame: -12 >> > [ 55.838529] ath10k_sdio mmc1:0001:1: failed to push frame: -12 >> > [ 55.905863] ath10k_sdio mmc1:0001:1: failed to transmit packet, dropping: -12 >> > [ 55.913650] ath10k_sdio mmc1:0001:1: failed to submit frame: -12 >> > [ 55.919887] ath10k_sdio mmc1:0001:1: failed to push frame: -12 >> > >> > and it is not possible to connect via ssh to the other machine. >> > >> > One user inspected the size of frames on Wireshark and reported >> > the followig: >> > >> > "I was able to narrow the issue down to the mtu. If I set the mtu for >> > the wlan0 device to 1486 instead of 1500, the issue does not happen. >> > >> > The size of frames that I see on Wireshark is exactly 1500 after >> > setting it to 1486." >> > >> > Clearing the HI_ACS_FLAGS_ALT_DATA_CREDIT_SIZE avoids the problem and >> > the ssh command works successfully after that. >> > >> > Tested with QCA9377 SDIO with firmware WLAN.TF.1.1.1-00061-QCATFSWPZ-1. >> > >> > Fixes: 2f918ea98606 ("ath10k: enable alt data of TX path for sdio") >> > Signed-off-by: Fabio Estevam >> >> A gentle ping on this one. > > Any comments, please? Without this fix, we can not log via ssh to other machine. I don't have much time for ath10k nowadays, so expect long delays in reviews. I'm worried that this breaks QCA6174 SDIO support. Wen, what do you think of this? Is this because of differences between firmware versions or what? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k